From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#63648: 29.0.90; project.el: with switch-use-entire-map, switch-project errors on non-project commands Date: Tue, 7 Nov 2023 00:49:49 +0200 Message-ID: <6be78df5-f9f5-9423-92d0-a5b4e329b0d2@gutov.dev> References: <6fc81cbf-a21f-c5b4-aa56-e8518b8570d7@gutov.dev> <86msxgatuy.fsf@mail.linkov.net> <86y1gynr2u.fsf@mail.linkov.net> <7c72fd8c-c3f6-a974-8a4b-a081f7a9fe1a@gutov.dev> <86ttqmv7c6.fsf@mail.linkov.net> <56e7d865-0456-db7d-3a5d-1235e62508bf@gutov.dev> <865y31onju.fsf@mail.linkov.net> <8562bdad-e487-886a-af49-7f67d8d14b7a@gutov.dev> <86msw9g5yb.fsf@mail.linkov.net> <56909bdd-14ee-f68c-178f-5057efcd6150@gutov.dev> <86wmva7iey.fsf@mail.linkov.net> <86bkckwnf8.fsf@mail.linkov.net> <86h6mag077.fsf@mail.linkov.net> <86v8akoyve.fsf@mail.linkov.net> <86sf5lxyow.fsf@mail.linkov.net> <86r0l3crbq.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29034"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: Spencer Baugh , 63648-done@debbugs.gnu.org, sbaugh@catern.com To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 06 23:50:52 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r08Ql-0007NG-0A for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 06 Nov 2023 23:50:52 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r08QP-0003QF-LB; Mon, 06 Nov 2023 17:50:29 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r08QK-0003Oq-Ee for bug-gnu-emacs@gnu.org; Mon, 06 Nov 2023 17:50:25 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r08QK-0006Hr-6t for bug-gnu-emacs@gnu.org; Mon, 06 Nov 2023 17:50:24 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r08Qv-0000QO-On for bug-gnu-emacs@gnu.org; Mon, 06 Nov 2023 17:51:01 -0500 Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Nov 2023 22:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 63648 X-GNU-PR-Package: emacs Mail-Followup-To: 63648@debbugs.gnu.org, dmitry@gutov.dev, sbaugh@janestreet.com Original-Received: via spool by 63648-done@debbugs.gnu.org id=D63648.16993110371583 (code D ref 63648); Mon, 06 Nov 2023 22:51:01 +0000 Original-Received: (at 63648-done) by debbugs.gnu.org; 6 Nov 2023 22:50:37 +0000 Original-Received: from localhost ([127.0.0.1]:40987 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r08QW-0000PS-E9 for submit@debbugs.gnu.org; Mon, 06 Nov 2023 17:50:36 -0500 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]:35045) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r08QU-0000PC-VG for 63648-done@debbugs.gnu.org; Mon, 06 Nov 2023 17:50:35 -0500 Original-Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailout.nyi.internal (Postfix) with ESMTP id 39AA15C027D; Mon, 6 Nov 2023 17:49:52 -0500 (EST) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Mon, 06 Nov 2023 17:49:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1699310992; x=1699397392; bh=ab1LlP0W5/MYxaor1iEeBgp3sTwNSX2mQbw zK8xUptE=; b=NIQO2MZO1qkkHDj7uyB9hngR/ajdj/Wgsz3bJXok3C0Ct3dx/mI sPsQfCCDcAmhs6ukOWag6eDV7jEQ7cD9vdWMYup3eA+utii3Bmr7ICUDnXkAqIpM Jeth3NT4pbfU8q3ijgXS0PkcJmJSEPcba4Hv8pjE0dwv9igfz9jHjCdL68YT+WBB eo79LUXa8z9srtdsFoCOpmBGAYZn2oqOnB7uf3K052ixNmnOya2FMZZhBqxlQMnp EB1AtJvUllQsou5iUdWG8vqpTyHhGHkzUSa1YINowIMwmHKvXHWJ2qCZhyg7qB/X 9KpvC4KcLY0PGVjCmHepNeQe9kK/YuvfkQg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1699310992; x=1699397392; bh=ab1LlP0W5/MYxaor1iEeBgp3sTwNSX2mQbw zK8xUptE=; b=P1F1dzFoe3Eoyy1ezwNND34bJ7/4f4Cx8cTFjQLnuy0Rd4Vq6uU TQQfBcol3uKuKVdhb+KjmAPb6kVMXb4j7ZMzxYHjgxDvn22U4sJLefCG3GdCfKT/ cvCzYuMrfKamUwKOVk7EUJhXTvXbnxqi1zTX2gQLwoWIsR68LpxWqv779jrG7kmf cPCp7vIzpprT6JKlURusaRRpbO7Z1tQrJ04L81JSu92Y/faOgL0nNPnbrHZPB8GN g+BlAm3Xxqose3YN9MivUMMq0hXMG+JwJAp6znvgV2pYKVi/yNMTN49gxC5Nbnse 09iQUpru05ojv5ewQ/Krs2f+QHKCvtMbIEw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudduhedgtdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepiefgteevheevveffheeltdeukeeiieekueefgedugfefgefhudelgfefveel vdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 6 Nov 2023 17:49:50 -0500 (EST) Content-Language: en-US In-Reply-To: <86r0l3crbq.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273906 Archived-At: On 06/11/2023 09:16, Juri Linkov wrote: >>> I proposed a new option project-switch-use-global-map. >> >> I didn't know how the reconcile the existence of both >> project-switch-use-entire-map and project-switch-use-global-map. Saying in >> both docstrings that one takes priority over the other (and possibly >> repeating that in the doc for project-switch-commands) would be awkward. > > Then another variant would be to allow a new value 'global' > in the existing 'project-switch-use-entire-map'. Ah indeed. That could also look sensible. >>> But when project-switch-commands should be customized instead of new option, >>> then I'd prefer to use function names like `project-prefix-or-any-command' >>> instead of symbols `short-or-any' and `short-keys'. >>> >>>> Unifying all three alternatives in one option seems like the logical choice. >>> To avoid obsoleting `project-switch-use-entire-map', `short-keys' >>> could be removed. Then `short-or-any' could be replaced by >>> `project-prefix-or-any-command'. This will introduce minimal changes. >> >> All right, that sounds like a mix between v4 and v5. >> >> I've pushed 41e801fea1c to master, please take a look. > > Thanks, I tested and it works great. > >> In the future, perhaps we'd want to obsolete the option >> project-switch-use-entire-map anyway, replacing it with a separate command >> to be used in the same way as the newly-added one. But for now the change >> is maximally backward-compatible. > > Indeed, this is the safest change for now. More changes either will > bring trouble to users requiring to migrate from the obsolete variable, > or will make code more complicated. I guess it's time to close this bug? Thank you all for participation, and thanks for testing.