unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Stephen Berman <stephen.berman@gmx.net>
Cc: 27202@debbugs.gnu.org
Subject: bug#27202: 26.0.50; Eldoc mode is broken
Date: Sat, 3 Jun 2017 02:05:49 +0300	[thread overview]
Message-ID: <6bd74cdf-6448-bbc3-a047-a9b5f6e2a0e6@yandex.ru> (raw)
In-Reply-To: <87poemnh1h.fsf@rosalinde>

On 6/3/17 1:47 AM, Stephen Berman wrote:

>> Boostrapping latest master didn't fix it here.
> 
> I manually reverted this part of 2349f1df1b:

So basically all of it.

> -(define-minor-mode global-eldoc-mode
> -  "Toggle Global Eldoc mode on or off.
> -With a prefix argument ARG, enable Global Eldoc mode if ARG is
> -positive, and disable it otherwise.  If called from Lisp, enable
> -the mode if ARG is omitted or nil, and toggle it if ARG is ‘toggle’.
> -
> -If Global Eldoc mode is on, `eldoc-mode' will be enabled in all
> -buffers where it's applicable.  These are buffers that have modes
> -that have enabled eldoc support.  See `eldoc-documentation-function'."
> +(define-globalized-minor-mode global-eldoc-mode eldoc-mode turn-on-eldoc-mode
>     :group 'eldoc
> -  :global t
>     :initialize 'custom-initialize-delay
> -  :init-value t
> -  (setq eldoc-last-message nil)
> -  (if global-eldoc-mode
> -      (progn
> -	(add-hook 'post-command-hook #'eldoc-schedule-timer)
> -	(add-hook 'pre-command-hook #'eldoc-pre-command-refresh-echo-area))
> -    (remove-hook 'post-command-hook #'eldoc-schedule-timer)
> -    (remove-hook 'pre-command-hook #'eldoc-pre-command-refresh-echo-area)))
> +  :init-value t)
> 
> then rebuilt Emacs (just make, not bootstrap), and now Eldoc in the
> modeline works here again.

Do you have an explanation why one version of the code works, and 
another doesn't?





  reply	other threads:[~2017-06-02 23:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-02 19:53 bug#27202: 26.0.50; Eldoc mode is broken Stephen Berman
2017-06-02 21:18 ` Dmitry Gutov
2017-06-02 22:16   ` Stephen Berman
2017-06-02 22:47     ` Stephen Berman
2017-06-02 23:05       ` Dmitry Gutov [this message]
2017-06-02 23:21         ` Stephen Berman
2017-06-02 23:08     ` Dmitry Gutov
2017-06-02 23:20       ` Stephen Berman
2017-06-02 23:53         ` Dmitry Gutov
2017-06-03  8:59           ` Stephen Berman
2017-06-05 22:05             ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6bd74cdf-6448-bbc3-a047-a9b5f6e2a0e6@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=27202@debbugs.gnu.org \
    --cc=stephen.berman@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).