From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#15666: 24.3.50; regression: `defadvice' of a special form Date: Sun, 20 Oct 2013 16:15:25 -0700 (PDT) Message-ID: <6bc447c6-2d04-47d5-9e55-c8e6362fd4c7@default> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1382311044 5006 80.91.229.3 (20 Oct 2013 23:17:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 20 Oct 2013 23:17:24 +0000 (UTC) To: 15666@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 21 01:17:26 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VY2FR-0001Yc-S5 for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Oct 2013 01:17:26 +0200 Original-Received: from localhost ([::1]:37701 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VY2FR-0002Ru-3o for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 Oct 2013 19:17:25 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38586) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VY2FF-0002Rh-0y for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2013 19:17:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VY2F4-0001Zz-Vg for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2013 19:17:12 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45574) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VY2F4-0001Zv-Rz for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2013 19:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VY2F4-0007KE-ES for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2013 19:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Oct 2013 23:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 15666 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.138231096328072 (code B ref -1); Sun, 20 Oct 2013 23:17:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 20 Oct 2013 23:16:03 +0000 Original-Received: from localhost ([127.0.0.1]:59593 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VY2E6-0007Ie-Id for submit@debbugs.gnu.org; Sun, 20 Oct 2013 19:16:02 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:36589) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VY2E3-0007I3-99 for submit@debbugs.gnu.org; Sun, 20 Oct 2013 19:16:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VY2Dn-0001Rd-PQ for submit@debbugs.gnu.org; Sun, 20 Oct 2013 19:15:53 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:59320) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VY2Dn-0001RZ-Lr for submit@debbugs.gnu.org; Sun, 20 Oct 2013 19:15:43 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38280) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VY2De-00024s-TO for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2013 19:15:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VY2DW-00018V-3W for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2013 19:15:34 -0400 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:35248) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VY2DV-00016N-QC for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2013 19:15:26 -0400 Original-Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r9KNFNHI010870 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 20 Oct 2013 23:15:24 GMT Original-Received: from userz7021.oracle.com (userz7021.oracle.com [156.151.31.85]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r9KNFNbZ015183 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sun, 20 Oct 2013 23:15:23 GMT Original-Received: from abhmt108.oracle.com (abhmt108.oracle.com [141.146.116.60]) by userz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r9KNFMIW015175 for ; Sun, 20 Oct 2013 23:15:23 GMT X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:79433 Archived-At: (elisp) `Defining Advice' says that you can use `defadvice' to advise a special form. It is quite clear about this: "Here, FUNCTION is the name of the function (or macro or special form) to be advised. From now on, we will write just "function" when describing the entity being advised, but this always includes macros ^^^^^^^^^^^^^^^^^^^^ and special forms." ^^^^^^^^^^^^^ And indeed it does...in Emacs 20. But this was apparently broken, starting with Emacs 22 (I don't have 21 to test there). In Emacs 20, this works fine: (defadvice defconst (after foo last activate) (put (ad-get-arg 0) 'foo-prop t)) In Emacs 22 you get this: (error "Invalid lambda variable [docstring]"). In Emacs 24 you get this: (error "Advice impossible: defconst is a special form") Please reverse the regression, allowing use of `defadvice' with special forms, as the doc claims and as was in fact the case prior to Emacs 22. In GNU Emacs 24.3.50.1 (i686-pc-mingw32) of 2013-10-19 on LEG570 Bzr revision: 114715 rgm@gnu.org-20131019023520-s8mwtib7xcx9e05w Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --enable-checking 'CFLAGS=3D-O0 -g3' CPPFLAGS=3D-DGLYPH_DEBUG= =3D1'