On 2025-01-02 00:10, Eli Zaretskii wrote:
>> Date: Wed, 01 Jan 2025 23:10:14 -0800
>> From: Jared Finder <jared@finder.org>
>> Cc: shipmints@gmail.com, rms@gnu.org, gerd.moellmann@gmail.com,
>>  fgunbin@fastmail.fm, 74833@debbugs.gnu.org
>> 
>> Patch attached.
> 
> Thanks.  This LGTM, but please modify this comment:
> 
>> +(defun xterm--query-name-and-version ()
>> +  "Get the terminal name and version string (XTVERSION)."
>> +  ;; The default timeout time causes a noticeable startup delay on
>> +  ;; terminals that ignore the query.
>> +  (let ((xterm-query-timeout 0.1))
> 
> to the effect that we use non-default value of 0.1 because the default
> (larger) value causes a noticeable startup delay.  It took me a few
> seconds to understand the intent; initially I thought that you were
> describing what happens when 0.1 is used.
> 
>> I also noticed outdated text in the docstring for xterm-mouse-mode and
>> attached a second patch to delete that text.
>> [...]
>> -Turn it on to use Emacs mouse commands, and off to use xterm mouse 
>> commands.
>> -This works in terminal emulators compatible with xterm.  It only
>> -works for simple uses of the mouse.  Basically, only non-modified
>> -single clicks are supported.  When turned on, the normal xterm
>> -mouse functionality for such clicks is still available by holding
>> -down the SHIFT key while pressing the mouse button."
>> +Turn it on to use Emacs mouse commands, and off to use xterm mouse
>> +commands.  This works in terminal emulators compatible with xterm.  
>> When
>> +turned on, the normal xterm mouse functionality for such clicks is 
>> still
>> +available by holding down the SHIFT key while pressing the mouse 
>> button."
> 
> This is also okay, but please add to the doc strings a reference to
> sterm--init where we verify that the terminal is compatible with
> xterm-mouse-mode.

Comments addressed.  I've collapsed both patches down to one (it was 
easier for me).

   -- MJF