From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#23769: 25.0.95; Mode Line breakage in vc-git Date: Thu, 16 Jun 2016 02:25:43 +0300 Message-ID: <6b6f147e-3b42-ccf5-92fd-0890d6942d4b@yandex.ru> References: <87a8ioyq9o.fsf@russet.org.uk> <87wplr1z4z.fsf@russet.org.uk> <91e61a46-b3bb-c4d9-cb30-bbfa90135d69@yandex.ru> <877fdqkwki.fsf@russet.org.uk> <9856a1e4-be41-d781-bfbd-22bac360d18b@yandex.ru> <871t3y85oz.fsf@russet.org.uk> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1466033247 30998 80.91.229.3 (15 Jun 2016 23:27:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 15 Jun 2016 23:27:27 +0000 (UTC) Cc: 23769@debbugs.gnu.org To: Phillip Lord Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 16 01:27:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bDKDK-0001qJ-KH for geb-bug-gnu-emacs@m.gmane.org; Thu, 16 Jun 2016 01:27:14 +0200 Original-Received: from localhost ([::1]:45593 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDKDJ-0003CF-QZ for geb-bug-gnu-emacs@m.gmane.org; Wed, 15 Jun 2016 19:27:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37416) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDKDC-0003B7-TC for bug-gnu-emacs@gnu.org; Wed, 15 Jun 2016 19:27:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDKD7-0006d0-Rr for bug-gnu-emacs@gnu.org; Wed, 15 Jun 2016 19:27:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58601) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDKD7-0006cw-Oy for bug-gnu-emacs@gnu.org; Wed, 15 Jun 2016 19:27:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bDKD7-0004ya-L5 for bug-gnu-emacs@gnu.org; Wed, 15 Jun 2016 19:27:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Jun 2016 23:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23769 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23769-submit@debbugs.gnu.org id=B23769.146603316119042 (code B ref 23769); Wed, 15 Jun 2016 23:27:01 +0000 Original-Received: (at 23769) by debbugs.gnu.org; 15 Jun 2016 23:26:01 +0000 Original-Received: from localhost ([127.0.0.1]:42704 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDKC5-0004ww-FT for submit@debbugs.gnu.org; Wed, 15 Jun 2016 19:26:01 -0400 Original-Received: from mail-wm0-f51.google.com ([74.125.82.51]:36233) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDKBz-0004wa-2g for 23769@debbugs.gnu.org; Wed, 15 Jun 2016 19:25:56 -0400 Original-Received: by mail-wm0-f51.google.com with SMTP id f126so29499817wma.1 for <23769@debbugs.gnu.org>; Wed, 15 Jun 2016 16:25:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=pCv7AGPJM3I/vCcLkqVWeLVkx50+YMUzabbMnB+Z9F0=; b=JxNYJo+lgwE7MrU7ffY1TYP7MO45xD8HfSAbjvGqMOYSGepvg88RYGMMujrgLjLjt7 SDtBf9xLE0HknnV4YoHUGKNWWKjCBkNQf4htBSwHNPZfYKkj2pfO4m/QT4VPf7F72Gb5 4tI53iZdyeS/j+aBB354Tx2gP8TByzUcyE4k0OpqYxHKPg12Jb/oOpDD6R+Aq37EWq9b LejM1I7lPnal/oRBPoBdOUZ2O1E/E8B+VSUJ1u5MM1n0YnWmmA5lairlc55pe9hvinA8 kuSgJaBzSrEvWpr+fpapw25QQVY/xlr+AkvGKNI7LpWu1oJPM1tZdN4c9cGwKl3euYmm 7qSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=pCv7AGPJM3I/vCcLkqVWeLVkx50+YMUzabbMnB+Z9F0=; b=lrucBtMWPKWYKkeRiGL5KWsaXxzde/s6Xh1Xu9DQYvA5ITyYDPVZE/0dN0wSGWHvGs EtT3nLS0fPbR8W4Qafer6lqeEizeYgDz5HTzmmxGIjfXS0Xneh0wkgw+y1L9WbqAa7oA njVtH+J843249efBU2yCkPNZBhnXVhpLnSaZ3VsFj89Cwl8qtJVT/e2MAh0sU4+sJ24f z53/TD9dgLJx64tzw5OsWvWM43l6khUe+OBzj/FZZFiU6tydK3zDCa+PGc2G2L3AzCWn b9v0RB0oHkEnRgOWIFyybMKGNh+FVKBNJ48s5QbjqKr11DflDqBtbMGdN6qXiRm5f2O0 IQgQ== X-Gm-Message-State: ALyK8tLsC2TxGBylPmm/z79xJwsUFUkwM9y5DrQFxPgXprYikMqm3HQ5ThRNf/bD/6nWMA== X-Received: by 10.194.114.163 with SMTP id jh3mr352596wjb.173.1466033145543; Wed, 15 Jun 2016 16:25:45 -0700 (PDT) Original-Received: from [192.168.1.2] ([185.105.173.135]) by smtp.googlemail.com with ESMTPSA id o2sm14117426wjp.26.2016.06.15.16.25.44 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 15 Jun 2016 16:25:44 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 In-Reply-To: <871t3y85oz.fsf@russet.org.uk> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:119607 Archived-At: On 06/16/2016 01:09 AM, Phillip Lord wrote: > Try it on a pre-commit hook. CWD is set to the root, and GIT_DIR is set > to .git. Other people have found this: > > http://longair.net/blog/2011/04/09/missing-git-hooks-documentation/ OK, so hooks set it themselves. > AFAICT, it's not actually documented by git. Or it is but the > documentation is incomprehensible (hey, it's git, it could happen!). Yup. > That situation does indeed happen. For example, I normally checkout > emacs into worktrees where you get this when commiting on emacs-25 > branch which is a worktree off master. Does git-worktree use GIT_DIR in some way? > There is a simpler option. I am trying to solve the root cause of the > problem but, as you say, that might be fraught. Since the problem only > seems to cause an error with vc-git-mode-line-string, we could just > discard the error from vc-git-working-revision in this case. That sounds like a last-resort option. > Failing that, now I know what the problem is, at least I have a > workaround (unset GIT_DIR in the pre-commit hook). We could also unset GIT_DIR locally inside vc-git--call. At least when it's set to a known value such as '.git'.