From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Phil Sainty Newsgroups: gmane.emacs.bugs Subject: bug#27397: [PATCH] New commands for bulk tracing of elisp functions Date: Sun, 18 Jun 2017 13:06:14 +1200 Message-ID: <6b195c26-066c-870f-3432-0b24c6f619ec@orcon.net.nz> References: <1348823a-7623-8146-8cc0-8c0eff13e458@orcon.net.nz> <94d27dbb-46d3-1d6f-4849-251a0929d413@orcon.net.nz> <70000e90-328c-c084-3e3c-bbde96b16110@orcon.net.nz> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1497748033 11668 195.159.176.226 (18 Jun 2017 01:07:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 18 Jun 2017 01:07:13 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 To: Dmitry Gutov , 27397@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 18 03:07:09 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dMOgG-0002iN-UQ for geb-bug-gnu-emacs@m.gmane.org; Sun, 18 Jun 2017 03:07:09 +0200 Original-Received: from localhost ([::1]:36710 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dMOgI-0004EG-UO for geb-bug-gnu-emacs@m.gmane.org; Sat, 17 Jun 2017 21:07:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35425) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dMOgD-0004Dz-R1 for bug-gnu-emacs@gnu.org; Sat, 17 Jun 2017 21:07:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dMOgA-0003ui-LY for bug-gnu-emacs@gnu.org; Sat, 17 Jun 2017 21:07:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51180) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dMOgA-0003uY-I9 for bug-gnu-emacs@gnu.org; Sat, 17 Jun 2017 21:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dMOgA-00055E-87 for bug-gnu-emacs@gnu.org; Sat, 17 Jun 2017 21:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Phil Sainty Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Jun 2017 01:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27397 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 27397-submit@debbugs.gnu.org id=B27397.149774798519498 (code B ref 27397); Sun, 18 Jun 2017 01:07:02 +0000 Original-Received: (at 27397) by debbugs.gnu.org; 18 Jun 2017 01:06:25 +0000 Original-Received: from localhost ([127.0.0.1]:53857 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dMOfZ-00054O-4w for submit@debbugs.gnu.org; Sat, 17 Jun 2017 21:06:25 -0400 Original-Received: from smtp-3.orcon.net.nz ([60.234.4.44]:45801) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dMOfW-00054B-Ly for 27397@debbugs.gnu.org; Sat, 17 Jun 2017 21:06:23 -0400 Original-Received: from [150.107.172.87] (port=17473 helo=[192.168.20.102]) by smtp-3.orcon.net.nz with esmtpa (Exim 4.86_2) (envelope-from ) id 1dMOfP-0001n2-8n; Sun, 18 Jun 2017 13:06:15 +1200 In-Reply-To: Content-Language: en-GB X-GeoIP: NZ X-Spam_score: -1.0 X-Spam_score_int: -9 X-Spam_bar: - X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:133718 Archived-At: On 18/06/17 10:59, Dmitry Gutov wrote: > Why the rename, though? Those are not arguments for the function we're > going to trace. trace--read-args sounds as appropriate, if not more. That was because the behaviour of `trace--read-args' had been quite specific to the `trace-function*' commands -- its primary purpose was to prompt for a single function -- and I thought the name should reflect that. I agree with you, though -- the new name wasn't ideal either. I've now refactored this like so: * `trace--read-args' has been split into `trace--read-function` and `trace--read-extra-args'. * `trace--read-function` reads only a function. * `The interactive specs for the trace-function*' commands are now similar to those of the new bulk trace commands, in explicitly calling `trace--read-extra-args': (interactive (cons (trace--read-function "Trace function: ") (and current-prefix-arg (trace--read-extra-args)))) I think this name change makes better sense, and the code is now more consistent between commands. -Phil