From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#63469: 29.0.90; project.el doesn't add menu-bar entries Date: Thu, 25 May 2023 04:14:41 +0300 Message-ID: <6a5c2251-52a8-e389-f2ab-08da775fab82@gutov.dev> References: <83o7mkz2ap.fsf@gnu.org> <83sfbvxkj3.fsf@gnu.org> <3d97111e-794d-eeef-73b0-ee3f6f5f15d5@gutov.dev> <83jzx6w2bg.fsf@gnu.org> <6a3eed52-3248-74f9-bcaf-bf12660ae0ed@gutov.dev> <83h6savsz4.fsf@gnu.org> <83mt21vfgl.fsf@gnu.org> <86mt211vk3.fsf@mail.linkov.net> <0ce4532f-03aa-6afe-bd8f-8ef1df6615de@gutov.dev> <86ilco7qbs.fsf@mail.linkov.net> <83r0rctxbc.fsf@gnu.org> <867ct4b4ds.fsf@mail.linkov.net> <835y8otbub.fsf@gnu.org> <86o7mccl5z.fsf@mail.linkov.net> <63854a1a-8178-d039-288c-34b1e67e5b06@gutov.dev> <86ttw3blc6.fsf@mail.linkov.net> <86sfbm6hp5.fsf@mail.linkov.net> <86jzwyw8j5.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24623"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Cc: sbaugh@janestreet.com, Eli Zaretskii , 63469@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 25 03:15:31 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q1zZh-0006CM-L5 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 May 2023 03:15:30 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q1zZI-0002AO-9y; Wed, 24 May 2023 21:15:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q1zZG-00029o-EB for bug-gnu-emacs@gnu.org; Wed, 24 May 2023 21:15:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q1zZG-0003gO-60 for bug-gnu-emacs@gnu.org; Wed, 24 May 2023 21:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q1zZG-0002ms-06 for bug-gnu-emacs@gnu.org; Wed, 24 May 2023 21:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 May 2023 01:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63469 X-GNU-PR-Package: emacs Original-Received: via spool by 63469-submit@debbugs.gnu.org id=B63469.168497729310681 (code B ref 63469); Thu, 25 May 2023 01:15:01 +0000 Original-Received: (at 63469) by debbugs.gnu.org; 25 May 2023 01:14:53 +0000 Original-Received: from localhost ([127.0.0.1]:45503 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q1zZ7-0002mD-0O for submit@debbugs.gnu.org; Wed, 24 May 2023 21:14:53 -0400 Original-Received: from out5-smtp.messagingengine.com ([66.111.4.29]:57719) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q1zZ3-0002ly-8T for 63469@debbugs.gnu.org; Wed, 24 May 2023 21:14:51 -0400 Original-Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 0D48F5C0039; Wed, 24 May 2023 21:14:44 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Wed, 24 May 2023 21:14:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1684977284; x=1685063684; bh=KKoKrLsRaNHgylyFSuRQpYq/yzAvQE3xnt7 7QajfYsg=; b=BR34vTxSA8I410t1FEiGAm29i+cl2zhuxeicq9jm1JEL1pl6+4f BYyTZ876OFfWJK5ClgCHYCQDLp3KaBggIHX8R4uFU77RLe4ft094kUoxTpoCMmr7 9qdFrZybLkyK9lZkkalACEB7PPV2lFbr5COwSiVKt3iai6sfFZErIX956KOMjDQS 054iSik61hF5CItAxAWe+j5dCkXMhxKdYQeD18GRBs5xrjJOmuixBFt4CXqWtOJv Bh61BYFEYdObI5YvlVR9FHHRkXxW+OUGfECvXpDLiHxABB4W5qsIHwQtpPxIEWsj IKEyw4QUjXcSv4a36MXIi61pLHEof6MnzeA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1684977284; x=1685063684; bh=KKoKrLsRaNHgylyFSuRQpYq/yzAvQE3xnt7 7QajfYsg=; b=ApTyQ4l7hEIqiICMdnxvQRB/GNd7PNmpCmQS0GDfmbfdWxgiIR4 Z9hGP11VQ9h3mA0bT0uZvfwYHPqdQlSIIuo9nqcCvaXVP6FZAzvTNX430oR20hy1 bHflDMbbAZtPlLSwQpL1N+99NDhoJTYX8dA/pCj5p+U0U+PnBCZtKSsC7GyK18VL z2epiDQU2iZU7tE4INdqDf3LY9Fat8cfkZwBF+hXAhuFScP3+ZXInwjEWXpvTupN HQok5Rrxa+s8aQsI6270JgmtA4tUUmasfMsLiKd9Ea63bI0JHiViLrBOxTlKj4Xk KfdtBf7+QjtjAfr1C2jTwV0VldnmFfSXTfQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeejiedggeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepiefgteevheevveffheeltdeukeeiieekueefgedugfefgefhudelgfefveel vdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 24 May 2023 21:14:42 -0400 (EDT) Content-Language: en-US In-Reply-To: <86jzwyw8j5.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262326 Archived-At: On 24/05/2023 09:29, Juri Linkov wrote: >>>> Maybe in .dir-locals.el. Actually this works: >>>> >>>> ((nil . ((project-vc-name . "emacs-29")))) >>>> >>>> Not sure why non-VC projects can't be named the same way. >>> And indeed this is a real problem: in file buffers there is >>> one project name that comes from project-vc-name, and in >>> non-file buffers another project name deduced from dirs. >> >> Are you saying that non-file buffers don't obey the value of >> project-vc-name set in parent dir's dir-locals.el? > > Exactly. I see no way to set the same project name both for > non-file and file buffers. Please try the patch below. It might have non-negligible effect on performance though. Please try and report back. diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index 7c51778d5d4..1494665d565 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -816,8 +816,8 @@ project-buffers (push buf bufs))) (nreverse bufs))) -(cl-defmethod project-name ((_project (head vc))) - (or project-vc-name +(cl-defmethod project-name ((project (head vc))) + (or (project--value-in-dir 'project-vc-name (project-root project)) (cl-call-next-method))) >>> This distinction became visible while testing project-mode >>> on the mode-line. >>> >>>> Also noticed that project-vc-name is not marked as safe, >>>> so always asks a confirmation. >>> This problem exists only until project.el is loaded. >>> So maybe the 'safe' cookie should be in ###autoload. >> >> Possibly. Would that mean that all :safe attribute assignments should be >> moved outside of defcustom forms, though? >> >> There is a whole bunch of them in project.el alone, most of them are >> expected to be settable from .dir-locals.el (that's the only point of this >> attribute). > > I tried out other defcustoms, and indeed all they require confirmation: > project-vc-ignores, project-vc-merge-submodules, > project-vc-include-untracked, project-vc-name, > project-vc-extra-root-markers, project-kill-buffers-display-buffer-list. > > The standard solution is just to use e.g.: > > ;;;###autoload(put 'compilation-directory 'safe-local-variable 'stringp) Huh, so the attribute :safe only makes proper sense for preloaded packages and autoloaded defcustom forms (which are discouraged anyway). Do you want to write a patch for all those vars in project.el? It will probably make sense to push it to emacs-29.