From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.bugs Subject: bug#63708: 29.0.60; rust-ts-mode not properly handling apostrophe Date: Mon, 29 May 2023 13:20:58 +0000 Message-ID: <6KowwZUmaJ_qJFx3ZNXCIxvjbM0ii9GDN6UnqJvuzTtmpoJeZ9hQkH8CWJaDInCSQMszlpw-C0r9DwyISsxq4wG_i1ugunSVUrYtbvMRx8Y=@rjt.dev> References: <8T8C4l5XryyVmB2cBTnmhGMnoELwHA2y1u1ZeMlg1WaQKzrPeOoe6L5hOQq3JPdsnG9r-puSlQfNZ091qBCGpVco-mC6ruhsQs0SvaPjkjQ=@proton.me> <_LWjNGLzmmtpm2gEwOaBZlTVCwvU9yxUyJzIl3yo3ol48dKWbMabBOpLzZ2UhWJ2_yPjVT-j2Jb-oUP8nLaju6ztGjFTNq-2PZqgTjv5gSM=@proton.me> <83r0qzgwtb.fsf@gnu.org> <2f72DkG-al7xrS0OaLtReoi4_HyZXNN0xIyCD8l3NdzTHgOUyyJtrANHSrAKuqzhyR4G9IYymP86mY5ss-GufnoUPc9MVOXCQNXnA2VGyjA=@rjt.dev> <83leh7gu1g.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_Zud2RQiGYla4jjj9VAO21ULM11oo3wJa6hT4mzA4RcM" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19173"; mail-complaints-to="usenet@ciao.gmane.io" Cc: yordanm@proton.me, casouri@gmail.com, 63708@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 29 16:10:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q3dZm-0004oC-Vx for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 29 May 2023 16:10:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q3cp3-00048m-4d; Mon, 29 May 2023 09:22:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q3cp0-00048I-Rw for bug-gnu-emacs@gnu.org; Mon, 29 May 2023 09:22:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q3cp0-0007eg-8Y for bug-gnu-emacs@gnu.org; Mon, 29 May 2023 09:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q3coz-00075T-O0 for bug-gnu-emacs@gnu.org; Mon, 29 May 2023 09:22:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 May 2023 13:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63708 X-GNU-PR-Package: emacs Original-Received: via spool by 63708-submit@debbugs.gnu.org id=B63708.168536648627195 (code B ref 63708); Mon, 29 May 2023 13:22:01 +0000 Original-Received: (at 63708) by debbugs.gnu.org; 29 May 2023 13:21:26 +0000 Original-Received: from localhost ([127.0.0.1]:57348 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3coP-00074Y-Gb for submit@debbugs.gnu.org; Mon, 29 May 2023 09:21:25 -0400 Original-Received: from mail-4018.proton.ch ([185.70.40.18]:57925) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3coM-00074J-BD for 63708@debbugs.gnu.org; Mon, 29 May 2023 09:21:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail3; t=1685366475; x=1685625675; bh=V0c1kSq3yuau9hjr6Do5ztWfLXBbSeEGpLpa1P7Xuss=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=MJB4IqO9S2DRi2vMFNmlTAY6vcj5R49ezwVvN2QtAroyloUxXrYc/f1/k/oUKqn4U Zn9PfI1md/rC7HLEEidRcBBr/RLTPsbfHcm5UDIsiAfCtaDv8YE2oJYrtur9OMdwkW u1o2l8cNs0S9izYVxiQbb1RmYRu6R2pL7brsN56qz+V7Plz6BXIHYqveVQEkPQrPpO wT0pGitPi8Jjhmof4wm5tQXp/vKASw1vX1Ap6UnFoxzK2SA8zFMj8bC1n5MS1d/j0l ECLYVC5hlLpYGvjPdgHRJtSday5yJZebwflRR/sIdB1Yz/7L652sio0iKnfXmu//+x LRvpFLvNr8ulA== In-Reply-To: <83leh7gu1g.fsf@gnu.org> Feedback-ID: 44397038:user:proton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262579 Archived-At: This is a multi-part message in MIME format. --b1_Zud2RQiGYla4jjj9VAO21ULM11oo3wJa6hT4mzA4RcM Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Monday, May 29th, 2023 at 09:12, Eli Zaretskii wrote: > > Date: Mon, 29 May 2023 12:18:38 +0000 >=20 > > From: Randy Taylor dev@rjt.dev > > Cc: yordanm@proton.me, 63708@debbugs.gnu.org, casouri@gmail.com > >=20 > > On Monday, May 29th, 2023 at 08:12, Eli Zaretskii eliz@gnu.org wrote: > >=20 > > > > Date: Mon, 29 May 2023 01:29:31 +0000 > > >=20 > > > > From: Randy Taylor dev@rjt.dev > > > > Cc: Eli Zaretskii eliz@gnu.org, 63708@debbugs.gnu.org, casouri@gmai= l.com > > > >=20 > > > > I won't be committing them (don't have the ability) but Eli likely = will. > > > >=20 > > > > If you'd like to go through them all and check, that would be great= . However, for non-trivial contributions (i.e. more than 15 lines of code c= hanges across all your contributions I believe) you will need to assign cop= yright to the FSF, otherwise the changes can't be accepted. Eli can send yo= u the form to fill out if you're interested. > > >=20 > > > It is unfortunate that the patch was posted before asking about such > > > non-trivial submissions, because we are now stuck due to lack of > > > copyright assignment, and the release branch must either wait for the > > > assignment or live with the bug. > > >=20 > > > =D0=99=D0=BE=D1=80=D0=B4=D0=B0=D0=BD, can you think of a way of rewri= ting the go-ts-mode patch so > > > that it uses fewer than 15 lines? > >=20 > > The go-ts-mode patch can be rewritten in a single line by just updating= the syntax table directly like I suggested. Then we should be OK. >=20 >=20 > Thanks, then please post such a patch. Attached. >=20 > What about rust-ts-mode? I will reply to that thread directly. --b1_Zud2RQiGYla4jjj9VAO21ULM11oo3wJa6hT4mzA4RcM Content-Type: text/x-patch; name=0001-go-ts-mode-Treat-apostrophes-as-strings-Bug-63708.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-go-ts-mode-Treat-apostrophes-as-strings-Bug-63708.patch RnJvbSA4OTk0Yzg0Mjk0NmRhNGU4MjM0ZDhiODcwNjg4MjdkMWM2MTg1MzQyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSYW5keSBUYXlsb3IgPGRldkByanQuZGV2PgpEYXRlOiBNb24s IDI5IE1heSAyMDIzIDA5OjE2OjEwIC0wNDAwClN1YmplY3Q6IFtQQVRDSF0gZ28tdHMtbW9kZTog VHJlYXQgYXBvc3Ryb3BoZXMgYXMgc3RyaW5ncyAoQnVnIzYzNzA4KQoKKiBsaXNwL3Byb2dtb2Rl cy9nby10cy1tb2RlLmVsIChnby10cy1tb2RlLS1zeW50YXgtdGFibGUpOiBUcmVhdAphcG9zdHJv cGhlcyBhcyBzdHJpbmdzLgotLS0KIGxpc3AvcHJvZ21vZGVzL2dvLXRzLW1vZGUuZWwgfCAxICsK IDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKQoKZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21v ZGVzL2dvLXRzLW1vZGUuZWwgYi9saXNwL3Byb2dtb2Rlcy9nby10cy1tb2RlLmVsCmluZGV4IDQy MzNiMTE1ZjE5Li42OThjNjQyNGVhMiAxMDA2NDQKLS0tIGEvbGlzcC9wcm9nbW9kZXMvZ28tdHMt bW9kZS5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy9nby10cy1tb2RlLmVsCkBAIC01OCw2ICs1OCw3 IEBAIGdvLXRzLW1vZGUtLXN5bnRheC10YWJsZQogICAgIChtb2RpZnktc3ludGF4LWVudHJ5ID88 ICAgIi4iICAgICAgdGFibGUpCiAgICAgKG1vZGlmeS1zeW50YXgtZW50cnkgPz4gICAiLiIgICAg ICB0YWJsZSkKICAgICAobW9kaWZ5LXN5bnRheC1lbnRyeSA/XFwgICJcXCIgICAgIHRhYmxlKQor ICAgIChtb2RpZnktc3ludGF4LWVudHJ5ID9cJyAgIlwiIiAgICAgdGFibGUpCiAgICAgKG1vZGlm eS1zeW50YXgtZW50cnkgPy8gICAiLiAxMjRiIiB0YWJsZSkKICAgICAobW9kaWZ5LXN5bnRheC1l bnRyeSA/KiAgICIuIDIzIiAgIHRhYmxlKQogICAgIChtb2RpZnktc3ludGF4LWVudHJ5ID9cbiAg Ij4gYiIgICAgdGFibGUpCi0tIAoyLjQwLjEKCg== --b1_Zud2RQiGYla4jjj9VAO21ULM11oo3wJa6hT4mzA4RcM--