From: Eli Zaretskii <eliz@gnu.org>
To: 30626@debbugs.gnu.org, michael_heerdegen@web.de
Subject: bug#30626: 26.0.91; Crash when traversing a `stream-of-directory-files'
Date: Tue, 27 Feb 2018 13:21:30 +0200 [thread overview]
Message-ID: <6FCF6ACA-4F29-4B6B-BE9D-D7130C6E9495@gnu.org> (raw)
In-Reply-To: <87inaiss6l.fsf@web.de>
On February 27, 2018 11:22:26 AM GMT+02:00, Michael Heerdegen <michael_heerdegen@web.de> wrote:
>
> Hello,
>
> Traversing a `stream-of-directory-files' over a huge directory
> hierarchy
> crashes my Emacs.
>
> Here is a recipe: I have a file
> "/home/micha/Treasure/today/stream-crash.el" with these contents:
>
> #+begin_src emacs-lisp
> ;; -*- lexical-binding: t -*-
>
> (require 'stream)
>
> (seq-doseq (_file (stream-of-directory-files
> "/home/micha" t nil t nil
> (lambda (file) (and (file-readable-p file) (file-regular-p file)))))
> nil)
> #+end_src
>
> Then I
>
> micha> emacs -Q -L /home/micha/software/elpa/packages/stream\
> -l /home/micha/Treasure/today/stream-crash.el
>
> and I get a segfault after ~ 1 minute.
>
> This kind of crash only seems to occur when the traversed directory is
> sufficiently large.
I guess it's a stack overflow: that function recurses into subdirectories.
To avoid such problems, the function should be rewritten to work by BFS, not DFS.
next prev parent reply other threads:[~2018-02-27 11:21 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 9:22 bug#30626: 26.0.91; Crash when traversing a `stream-of-directory-files' Michael Heerdegen
2018-02-27 11:21 ` Eli Zaretskii [this message]
2018-02-27 11:39 ` Michael Heerdegen
2018-02-27 12:08 ` Michael Heerdegen
2018-02-27 18:08 ` Eli Zaretskii
2018-02-28 1:29 ` Noam Postavsky
2018-02-28 10:58 ` Michael Heerdegen
2018-02-28 16:00 ` Eli Zaretskii
2018-02-28 16:20 ` Michael Heerdegen
2018-02-28 17:22 ` Eli Zaretskii
2018-02-28 18:25 ` Michael Heerdegen
2018-03-01 11:25 ` Michael Heerdegen
2018-03-01 15:00 ` Eli Zaretskii
2018-03-02 14:11 ` Noam Postavsky
2018-03-02 15:06 ` Michael Heerdegen
2018-03-02 15:43 ` Eli Zaretskii
2018-03-02 20:16 ` Nicolas Petton
2018-03-02 20:58 ` Nicolas Petton
2018-03-03 7:56 ` Michael Heerdegen
2018-03-03 7:54 ` Michael Heerdegen
2018-03-03 8:47 ` Nicolas Petton
2018-03-02 21:48 ` John Mastro
2018-03-03 23:00 ` Noam Postavsky
2018-03-04 15:56 ` Noam Postavsky
2018-03-04 17:02 ` Eli Zaretskii
2018-03-11 18:52 ` Noam Postavsky
2018-03-11 20:31 ` Eli Zaretskii
2018-03-11 21:51 ` Noam Postavsky
2018-03-12 3:28 ` Eli Zaretskii
2018-03-13 1:59 ` Noam Postavsky
2018-03-13 16:06 ` Eli Zaretskii
2018-03-14 0:09 ` Noam Postavsky
2018-03-15 16:34 ` Eli Zaretskii
2018-03-17 15:53 ` Noam Postavsky
2018-03-17 16:10 ` Eli Zaretskii
2018-03-17 16:27 ` Eli Zaretskii
2018-03-17 17:28 ` Noam Postavsky
2018-03-19 20:05 ` Eli Zaretskii
2019-04-25 3:20 ` Noam Postavsky
2019-04-25 5:19 ` Michael Heerdegen
2019-05-10 13:20 ` Michael Heerdegen
2019-05-25 20:29 ` Noam Postavsky
2019-05-26 0:32 ` Michael Heerdegen
2019-05-26 0:40 ` Noam Postavsky
2019-05-26 1:15 ` Michael Heerdegen
2019-06-04 0:26 ` Noam Postavsky
2018-02-28 11:05 ` Michael Heerdegen
2018-02-28 13:20 ` Nicolas Petton
2018-03-01 10:44 ` Daniel Colascione
2018-03-01 15:51 ` Noam Postavsky
2018-03-01 16:54 ` Michael Heerdegen
2018-03-01 17:15 ` Noam Postavsky
2018-03-02 7:08 ` Michael Heerdegen
2018-03-02 13:01 ` Noam Postavsky
2018-03-02 13:13 ` Michael Heerdegen
2018-03-02 13:04 ` Michael Heerdegen
2018-02-27 18:00 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6FCF6ACA-4F29-4B6B-BE9D-D7130C6E9495@gnu.org \
--to=eliz@gnu.org \
--cc=30626@debbugs.gnu.org \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).