From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#45818: 28.0.50; Test solar-sunrise-sunset fails Date: Wed, 13 Jan 2021 13:12:48 +0100 Message-ID: <6F0AA926-37CF-4E5D-B2A6-8BECE7E5465E@acm.org> References: <871reqp1ax.fsf@tcd.ie> <28AECF36-B916-427E-A0EC-633AED7CB9BF@acm.org> <87ft35j4xl.fsf@tcd.ie> <59D8F21E-DA21-4F8E-AB91-550B3C154985@acm.org> <87eeiphkou.fsf@tcd.ie> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.17\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5578"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Kangas , 45818@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 13 13:44:27 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kzfVi-0001Jl-MU for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 13 Jan 2021 13:44:26 +0100 Original-Received: from localhost ([::1]:39592 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kzfVh-0006zr-Ng for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 13 Jan 2021 07:44:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55280) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzfTO-00061c-KW for bug-gnu-emacs@gnu.org; Wed, 13 Jan 2021 07:42:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51295) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kzfTO-0000Wn-9I for bug-gnu-emacs@gnu.org; Wed, 13 Jan 2021 07:42:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kzfTO-00082Q-5e for bug-gnu-emacs@gnu.org; Wed, 13 Jan 2021 07:42:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Jan 2021 12:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45818 X-GNU-PR-Package: emacs Original-Received: via spool by 45818-submit@debbugs.gnu.org id=B45818.161054169930865 (code B ref 45818); Wed, 13 Jan 2021 12:42:02 +0000 Original-Received: (at 45818) by debbugs.gnu.org; 13 Jan 2021 12:41:39 +0000 Original-Received: from localhost ([127.0.0.1]:34608 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzfT0-00081l-Va for submit@debbugs.gnu.org; Wed, 13 Jan 2021 07:41:39 -0500 Original-Received: from mail1470c50.megamailservers.eu ([91.136.14.70]:38730 helo=mail102c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzfSx-00081V-Jz for 45818@debbugs.gnu.org; Wed, 13 Jan 2021 07:41:36 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1610539972; bh=ZeKNjYv51LC3AZJyl+oSRrOcKttFbKq/bwlLN9SYsdw=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=aaMew23bgORUzCjIO5iezdn6SCTb0L/nUI87ScvoxVwzh4uHy5qDSIqj6HNe0YO3n mqgCXiU1N0we1aiELTKd5m7fBNIvvKB3VW1c3fOR3W9pawxMcT5pw8vlHF6h/MihWT glMOwSI3kgBvs10ptjiD7PWqMGIiOqBXB7ybPhvA= Feedback-ID: mattiase@acm.or Original-Received: from stanniol.lan (c-064ae655.032-75-73746f71.bbcust.telenor.se [85.230.74.6]) (authenticated bits=0) by mail102c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 10DCCnW2027747; Wed, 13 Jan 2021 12:12:50 +0000 In-Reply-To: <87eeiphkou.fsf@tcd.ie> X-Mailer: Apple Mail (2.3445.104.17) X-CTCH-RefID: str=0001.0A742F1F.5FFEE3C4.0025, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=d6CLNirE c=1 sm=1 tr=0 a=Ni+dBsiEfW2GqKMPYZim9A==:117 a=Ni+dBsiEfW2GqKMPYZim9A==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=thWGRzfbAAAA:8 a=izbNSLyvrweggoMxd1gA:9 a=CjuIK1q_8ugA:10 a=Xo0djKA56MUA:10 a=tIp4BSgjzBjTsUfidmXJ:22 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:197890 Archived-At: 12 jan. 2021 kl. 23.09 skrev Basil L. Contovounesios : > Agreed. If this is the sort of stuff that gets you (or Stefan, CCed) > out of bed in the morning, then you might also be interested in = looking > at lunar-test-phase-list. I tried applying the same > calendar-daylight-savings-starts trick in with-lunar-test, but that = just > brought down the difference in actual vs expected times from 2hrs to > 1hr. Let's give lunar-tests.el a go then. Stefan, what is the ground truth = here? Where does the data come from? (And what does "** Eclipse **" mean? That the Moon intersects the = Earth-Sun orbital plane without causing an actual eclipse? I can't be = the only one confused by this.) If https://stellafane.org/observing/moon_phase.html can be trusted, the = times of day in the test are off by about one hour. The discrepancies = are almost exactly one hour for new moons but a few minutes off for full = moons. Thus it looks like the test numbers were produced from a test run = in summer, which is consistent with the file creation date. > My guess as to why this happens is because calendar-dst-find-data (or > similar) calls current-time-zone without an explicit time zone = argument, > meaning tests can't truly specify a time zone other than the system's = in > general. Could be -- if so, the code would benefit from an override for test = purposes. > Is this new wishlist bug report material, or are we happy to leave > lunar-test-phase-list marked as unstable and forget about this? Marking a test as unstable is tantamount to commenting it out. There = needs to be an open bug or the problem is quickly forgotten.