From: "Mattias Engdegård" <mattiase@acm.org>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: Stefan Kangas <stefan@marxist.se>, 45818@debbugs.gnu.org
Subject: bug#45818: 28.0.50; Test solar-sunrise-sunset fails
Date: Wed, 13 Jan 2021 13:12:48 +0100 [thread overview]
Message-ID: <6F0AA926-37CF-4E5D-B2A6-8BECE7E5465E@acm.org> (raw)
In-Reply-To: <87eeiphkou.fsf@tcd.ie>
12 jan. 2021 kl. 23.09 skrev Basil L. Contovounesios <contovob@tcd.ie>:
> Agreed. If this is the sort of stuff that gets you (or Stefan, CCed)
> out of bed in the morning, then you might also be interested in looking
> at lunar-test-phase-list. I tried applying the same
> calendar-daylight-savings-starts trick in with-lunar-test, but that just
> brought down the difference in actual vs expected times from 2hrs to
> 1hr.
Let's give lunar-tests.el a go then. Stefan, what is the ground truth here? Where does the data come from?
(And what does "** Eclipse **" mean? That the Moon intersects the Earth-Sun orbital plane without causing an actual eclipse? I can't be the only one confused by this.)
If https://stellafane.org/observing/moon_phase.html can be trusted, the times of day in the test are off by about one hour. The discrepancies are almost exactly one hour for new moons but a few minutes off for full moons. Thus it looks like the test numbers were produced from a test run in summer, which is consistent with the file creation date.
> My guess as to why this happens is because calendar-dst-find-data (or
> similar) calls current-time-zone without an explicit time zone argument,
> meaning tests can't truly specify a time zone other than the system's in
> general.
Could be -- if so, the code would benefit from an override for test purposes.
> Is this new wishlist bug report material, or are we happy to leave
> lunar-test-phase-list marked as unstable and forget about this?
Marking a test as unstable is tantamount to commenting it out. There needs to be an open bug or the problem is quickly forgotten.
next prev parent reply other threads:[~2021-01-13 12:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 16:28 bug#45818: 28.0.50; Test solar-sunrise-sunset fails Basil L. Contovounesios
2021-01-12 18:50 ` Mattias Engdegård
2021-01-12 20:06 ` Basil L. Contovounesios
2021-01-12 21:02 ` Mattias Engdegård
2021-01-12 22:09 ` Basil L. Contovounesios
2021-01-13 12:12 ` Mattias Engdegård [this message]
2021-01-13 13:04 ` Stefan Kangas
2021-01-13 13:29 ` Mattias Engdegård
2021-01-13 19:03 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6F0AA926-37CF-4E5D-B2A6-8BECE7E5465E@acm.org \
--to=mattiase@acm.org \
--cc=45818@debbugs.gnu.org \
--cc=contovob@tcd.ie \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).