From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: John Cummings Newsgroups: gmane.emacs.bugs Subject: bug#50630: [PATCH] Add tests for insert-directory Date: Sat, 25 Sep 2021 18:01:26 +0000 Message-ID: <6BkKnxC8vJfxCuBEeMYpDIIMMNM9KoCWH_apnHQQkb3ejH9sD59wOd29-KnV1UGcIJs6DZS0D9wiAKFowJ1kD48m0LNUYaVLVSyEsQ1nGbs=@rootabega.net> References: <83ilyorei3.fsf@gnu.org> <83bl4gr9gr.fsf@gnu.org> <83pmswpnwh.fsf@gnu.org> <5lfMDzHA2waL6rqBXIu9VVdZiGHqsP3B1wJq3MvU71eZwrdqyi4iXUwuEuldT-SNilGq3jrS88bYp4zKIAo-xD2K8teQdBKQszDYhm52bMc=@rootabega.net> <83mto0pn2e.fsf@gnu.org> Reply-To: John Cummings Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24681"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 50630@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 25 20:02:23 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mUC0E-0006D3-UZ for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Sep 2021 20:02:23 +0200 Original-Received: from localhost ([::1]:51406 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mUC0C-0008EC-Tz for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Sep 2021 14:02:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40318) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUBzv-00084t-5W for bug-gnu-emacs@gnu.org; Sat, 25 Sep 2021 14:02:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51338) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mUBzu-0005iH-TC for bug-gnu-emacs@gnu.org; Sat, 25 Sep 2021 14:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mUBzu-000833-R7 for bug-gnu-emacs@gnu.org; Sat, 25 Sep 2021 14:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: John Cummings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Sep 2021 18:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50630 X-GNU-PR-Package: emacs Original-Received: via spool by 50630-submit@debbugs.gnu.org id=B50630.163259289630851 (code B ref 50630); Sat, 25 Sep 2021 18:02:02 +0000 Original-Received: (at 50630) by debbugs.gnu.org; 25 Sep 2021 18:01:36 +0000 Original-Received: from localhost ([127.0.0.1]:34642 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUBzU-00081X-H9 for submit@debbugs.gnu.org; Sat, 25 Sep 2021 14:01:36 -0400 Original-Received: from mail2.protonmail.ch ([185.70.40.22]:25899) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUBzS-00081H-6d for 50630@debbugs.gnu.org; Sat, 25 Sep 2021 14:01:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rootabega.net; s=protonmail; t=1632592886; bh=vuOcpQLNC1RCZ1s4FOvaGg6ovPNK9QwSBTwg5Hcl254=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=AHfA7uzcdK8WqlPfw4eC1M41b4Da1rI7itISretQVUA6w5XRLPmencnFRGQkxmV/6 6usFwBgn5rAFKie9Jnh6RcO1c2t5E9ubejFjeAn7o9qBitlxJwWe6g9zsDlOHeFgRc 9BKfSn/d5mTwvDyouju56bZDsaT7Q7OKlTyRAbDjEy5xMjdFsWds5fDZkB6eiNDxEZ YdnFlKloSr68CPXDNDho6ya73M0KKvZxYZ9uPiOQOiCmTRsUmkJUpGrQvF8NQKHrYj aKbaH8xaZBZQes5ZfFsGwI8a9ERPUxGsIzL+bbeyy1HqUP1gow5qT9dmF/YvIKJSCR PwuFyQOxokXgQ== In-Reply-To: <83mto0pn2e.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:215488 Archived-At: > With your recipe, indeed the free space is not always correct. But > why is that use case interesting? insert-directory is not a normally > a user-visible function. If being a user-visible function is necessary to consider it interesting, then I reported this as a bug in the verbose `list-directory' output, which is documented in the manual. But I don't think it needs to be normally user-visible to be interesting. Would programmers be welcome to use insert-directory in their code? It woul= d also be good to fix this so that any future Emacs functionality that used insert-directory would have the correct output. The help for that function says: insert-directory is a compiled Lisp function in =E2=80=98/media/ubuntu/turkey/freshemacs/emacs/lisp/files.el=E2=80=99. (insert-directory FILE SWITCHES &optional WILDCARD FULL-DIRECTORY-P) Insert directory listing for FILE, formatted according to SWITCHES. I truncated that, but it doesn't say anything about depending on the current default-directory. If the function performs a listing for FILE, it shouldn't be possible for it to insert free space that is not correct for FILE. If it's OK for insert-directory to rely on the current default-directory, then the FILE argument itself seems unnecessary.