From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Reitter Newsgroups: gmane.emacs.bugs Subject: bug#3303: delete-frame raises old (invisible) frame Date: Sun, 17 May 2009 15:12:39 -0400 Message-ID: <6A510E91-6262-44CF-AA62-315DECB52EF6@gmail.com> References: <2C87549A-2553-4477-BF77-6258A1CC32BE@gmail.com> Reply-To: David Reitter , 3303@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (Apple Message framework v935.3) Content-Type: multipart/signed; boundary=Apple-Mail-16-139870763; micalg=sha1; protocol="application/pkcs7-signature" X-Trace: ger.gmane.org 1242588810 28298 80.91.229.12 (17 May 2009 19:33:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 17 May 2009 19:33:30 +0000 (UTC) Cc: 3303@emacsbugs.donarmstrong.com, Adrian Robert To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 17 21:33:22 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1M5m6p-000733-U3 for geb-bug-gnu-emacs@m.gmane.org; Sun, 17 May 2009 21:33:20 +0200 Original-Received: from localhost ([127.0.0.1]:53977 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M5m6p-00017W-AX for geb-bug-gnu-emacs@m.gmane.org; Sun, 17 May 2009 15:33:19 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M5m5h-0000Ta-1P for bug-gnu-emacs@gnu.org; Sun, 17 May 2009 15:32:09 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M5m5a-0000Oy-Gy for bug-gnu-emacs@gnu.org; Sun, 17 May 2009 15:32:08 -0400 Original-Received: from [199.232.76.173] (port=53612 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M5m5Z-0000OP-Fn for bug-gnu-emacs@gnu.org; Sun, 17 May 2009 15:32:01 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:46723) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M5m5Y-0002G0-QQ for bug-gnu-emacs@gnu.org; Sun, 17 May 2009 15:32:01 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n4HJVuUO011865; Sun, 17 May 2009 12:31:58 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n4HJK8wD007871; Sun, 17 May 2009 12:20:08 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: David Reitter Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sun, 17 May 2009 19:20:08 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 3303 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 3303-submit@emacsbugs.donarmstrong.com id=B3303.12425875756209 (code B ref 3303); Sun, 17 May 2009 19:20:08 +0000 Original-Received: (at 3303) by emacsbugs.donarmstrong.com; 17 May 2009 19:12:55 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from mail-bw0-f157.google.com (mail-bw0-f157.google.com [209.85.218.157]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n4HJCoSh006199 for <3303@emacsbugs.donarmstrong.com>; Sun, 17 May 2009 12:12:51 -0700 Original-Received: by bwz1 with SMTP id 1so3758709bwz.1 for <3303@emacsbugs.donarmstrong.com>; Sun, 17 May 2009 12:12:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:cc:message-id:from:to :in-reply-to:content-type:mime-version:subject:date:references :x-mailer; bh=4ZHWkuNG0Xll+5ivGASIxriPk/2boEE+58H2pqKbJC8=; b=oPHvSjAOB72CkhnsWrI/AW70jYRW8JAi8zBwQNv+eLqu5g3z+c5U/V3ljIlsUn2zIA StpGrEerTcgdWhrajmRSpRx4lqPtvdElMI5JP+S01bKwpBhlf6IJsO6dQD2llAisXZDm VAFqjas/+Pe/EKuW4gD6RWHZfkfUTTL53eXMk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=cc:message-id:from:to:in-reply-to:content-type:mime-version:subject :date:references:x-mailer; b=O7J/0ts5/hqJIRjdzw5vmAK6cndOlvqWIpAYv03CGM3mb1vCsvw/Oeu390FKaCb5Ey her2oCgNjyJF8e0z65o7dfDhqCdJlqmCKAQU7PJkAHdtyJAKd1WIDjFsZWKEhiPDli/Q Jh1CXGXtJ0aZESpW9uuqHTPMtJq9frqW+6X/4= Original-Received: by 10.102.247.10 with SMTP id u10mr3621374muh.76.1242587564224; Sun, 17 May 2009 12:12:44 -0700 (PDT) Original-Received: from ?192.168.1.42? (pool-71-162-19-47.pitbpa.east.verizon.net [71.162.19.47]) by mx.google.com with ESMTPS id 25sm1187774mul.59.2009.05.17.12.12.42 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 17 May 2009 12:12:43 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.935.3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Sun, 17 May 2009 15:32:08 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:27933 Archived-At: --Apple-Mail-16-139870763 Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit On May 17, 2009, at 3:06 PM, Stefan Monnier wrote: > > Still, the > > #ifdef NS_IMPL_COCOA > /* term gets no other notification of this */ > if (for_deletion) > Fraise_frame(Qnil); > #endif > > in frame.c looks plain wrong and should probably just be deleted: > frame-selection is never intended to raise (or lower) any frame. > If this `raise' is really necessary, then it needs a much more > extensive > comment justifying its presence. > Adrian, could you remove this code, or justify clearly why it's here? I think it is there because we need to raise another (visible) frame when a frame is deleted. This is standard behavior (and sensible). However, this should not occur if the other frame is hidden, i.e. if there is no visible and uniconified frame. Im currently experimenting with something like this: #ifdef NS_IMPL_COCOA /* term gets no other notification of this */ if (for_deletion && FRAME_VISIBLE_P (XFRAME (selected_frame)) && FRAME_LIVE_P (XFRAME (selected_frame)) && ! FRAME_ICONIFIED_P (XFRAME (selected_frame))) Fraise_frame(Qnil); #endif - D --Apple-Mail-16-139870763 Content-Disposition: attachment; filename=smime.p7s Content-Type: application/pkcs7-signature; name=smime.p7s Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIFxDCCAn0w ggHmoAMCAQICED6shx13jEDrq0eL8FRq5ykwDQYJKoZIhvcNAQEFBQAwYjELMAkGA1UEBhMCWkEx JTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQ ZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBMB4XDTA4MTIwOTAyMDgwMVoXDTA5MTIwOTAyMDgw MVowYjEQMA4GA1UEBBMHUmVpdHRlcjEOMAwGA1UEKhMFRGF2aWQxFjAUBgNVBAMTDURhdmlkIFJl aXR0ZXIxJjAkBgkqhkiG9w0BCQEWF2RhdmlkLnJlaXR0ZXJAZ21haWwuY29tMIGfMA0GCSqGSIb3 DQEBAQUAA4GNADCBiQKBgQDOdo6kAwlkBxUb8dj4saMbYg4SVng8CUePFn3cjjWrakBTbUVa4Z0n wlUxr7AitEeKhBy5nGhu96+jKUPrCwYNRCZ0l2ovvuGq4z1m1nZ5/c8WvFlVhieuxXMUfmb/O7D3 IojoX6iS8n5MNNU2IWNNT/AD3vOl6DKgOtOw4J9y+QIDAQABozQwMjAiBgNVHREEGzAZgRdkYXZp ZC5yZWl0dGVyQGdtYWlsLmNvbTAMBgNVHRMBAf8EAjAAMA0GCSqGSIb3DQEBBQUAA4GBAIjI8yEW wkiEfA9PMgpjnD6KyCXT0iZjHhW2PkR53yZZLUoTboHnKgsFwYp/gzzIL8J5cvZaRUyMUzXDufPP dRmxxCs2jXXLDD/8bvdvOuMzqgYoFA73fAfsC8S6qUL1PayZ90J8CZHNhDwqWqOA56T+DdKUegJT sqoHKh6OnypTMIIDPzCCAqigAwIBAgIBDTANBgkqhkiG9w0BAQUFADCB0TELMAkGA1UEBhMCWkEx FTATBgNVBAgTDFdlc3Rlcm4gQ2FwZTESMBAGA1UEBxMJQ2FwZSBUb3duMRowGAYDVQQKExFUaGF3 dGUgQ29uc3VsdGluZzEoMCYGA1UECxMfQ2VydGlmaWNhdGlvbiBTZXJ2aWNlcyBEaXZpc2lvbjEk MCIGA1UEAxMbVGhhd3RlIFBlcnNvbmFsIEZyZWVtYWlsIENBMSswKQYJKoZIhvcNAQkBFhxwZXJz b25hbC1mcmVlbWFpbEB0aGF3dGUuY29tMB4XDTAzMDcxNzAwMDAwMFoXDTEzMDcxNjIzNTk1OVow YjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAq BgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBMIGfMA0GCSqGSIb3DQEB AQUAA4GNADCBiQKBgQDEpjxVc1X7TrnKmVoeaMB1BHCd3+n/ox7svc31W/Iadr1/DDph8r9RzgHU 5VAKMNcCY1osiRVwjt3J8CuFWqo/cVbLrzwLB+fxH5E2JCoTzyvV84J3PQO+K/67GD4Hv0CAAmTX p6a7n2XRxSpUhQ9IBH+nttE8YQRAHmQZcmC3+wIDAQABo4GUMIGRMBIGA1UdEwEB/wQIMAYBAf8C AQAwQwYDVR0fBDwwOjA4oDagNIYyaHR0cDovL2NybC50aGF3dGUuY29tL1RoYXd0ZVBlcnNvbmFs RnJlZW1haWxDQS5jcmwwCwYDVR0PBAQDAgEGMCkGA1UdEQQiMCCkHjAcMRowGAYDVQQDExFQcml2 YXRlTGFiZWwyLTEzODANBgkqhkiG9w0BAQUFAAOBgQBIjNFQg+oLLswNo2asZw9/r6y+whehQ5aU nX9MIbj4Nh+qLZ82L8D0HFAgk3A8/a3hYWLD2ToZfoSxmRsAxRoLgnSeJVCUYsfbJ3FXJY3dqZw5 jowgT2Vfldr394fWxghOrvbqNOUQGls1TXfjViF4gtwhGTXeJLHTHUb/XV9lTzGCAo8wggKLAgEB MHYwYjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4x LDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBAhA+rIcdd4xA66tH i/BUaucpMAkGBSsOAwIaBQCgggFvMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcN AQkFMQ8XDTA5MDUxNzE5MTIzOVowIwYJKoZIhvcNAQkEMRYEFBbN9Y2OUiYlW8itJ9+BCFI/DdB6 MIGFBgkrBgEEAYI3EAQxeDB2MGIxCzAJBgNVBAYTAlpBMSUwIwYDVQQKExxUaGF3dGUgQ29uc3Vs dGluZyAoUHR5KSBMdGQuMSwwKgYDVQQDEyNUaGF3dGUgUGVyc29uYWwgRnJlZW1haWwgSXNzdWlu ZyBDQQIQPqyHHXeMQOurR4vwVGrnKTCBhwYLKoZIhvcNAQkQAgsxeKB2MGIxCzAJBgNVBAYTAlpB MSUwIwYDVQQKExxUaGF3dGUgQ29uc3VsdGluZyAoUHR5KSBMdGQuMSwwKgYDVQQDEyNUaGF3dGUg UGVyc29uYWwgRnJlZW1haWwgSXNzdWluZyBDQQIQPqyHHXeMQOurR4vwVGrnKTANBgkqhkiG9w0B AQEFAASBgB2HoUEjdTurneBmZpDd5SRtNGJkPiRpboGlOq6hicOwzZjpNPfYgJNzMyUNYOXcFCje 6M6rYZHh7Spo8un0VLfOFXehWOlJi7m8FTTC0SDT0HwVOQF7/6Rk/FTOQDjipTMiwXR9Nke+97Bq FRESe3a9hS/m1uHWfQsEPmspuAM6AAAAAAAA --Apple-Mail-16-139870763--