From: "Shigeru Fukaya" <shigeru.fukaya@gmail.com>
To: "Chong Yidong" <cyd@stupidchicken.com>
Cc: 1334@emacsbugs.donarmstrong.com
Subject: bug#1334: 23.0.60; bug of bytecomp arithmetic operations
Date: Fri, 21 Nov 2008 18:11:04 +0900 [thread overview]
Message-ID: <69D13081CB3E4E4CA568C298914EE5AF@LX1> (raw)
In-Reply-To: <87hc61a5nn.fsf@cyd.mit.edu>
Hi, Chong,
> Shouldn't this be (nth 2 form) on the last line?
Of course, you are right.
I found I had tested with my older version.
In `byte-regression-test', I should have remove the following line.
(load "byte-opt-minimal")
After above correction, log output contains three errors.
(let ((a 3) (b 2) (c 1.0)) (- 0 a)) --> -3, NG
--> 0
(let ((a 3) (b 2) (c 1.0)) (- 0 c)) --> -1.0, NG
--> 0
(let ((a 3) (b 2) (c 1.0)) (- 0 a)) --> -3, NG
--> 0
Thank you,
- Shigeru
----- Original Message -----
From: "Chong Yidong" <cyd@stupidchicken.com>
To: "Shigeru Fukaya" <shigeru.fukaya@gmail.com>
Cc: <1334@emacsbugs.donarmstrong.com>
Sent: Friday, November 21, 2008 4:40 PM
Subject: Re: 23.0.60; bug of bytecomp arithmetic operations
> Thanks. I'm looking through your changes.
>
> ! ;; (- 0 x) --> (- x)
> ! ((and (eq (nth 1 form) 0) (= (length form) 3))
> ! (setq form (list '- (nth 1 form))))
>
> Shouldn't this be (nth 2 form) on the last line?
next prev parent reply other threads:[~2008-11-21 9:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-14 23:10 bug#1334: 23.0.60; bug of bytecomp arithmetic operations Chong Yidong
2008-11-15 4:04 ` Shigeru Fukaya
2008-11-15 4:18 ` Chong Yidong
2008-11-19 12:27 ` Shigeru Fukaya
2008-11-21 7:40 ` Chong Yidong
2008-11-21 9:11 ` Shigeru Fukaya [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-11-14 18:11 Chong Yidong
2008-11-12 14:58 Shigeru Fukaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69D13081CB3E4E4CA568C298914EE5AF@LX1 \
--to=shigeru.fukaya@gmail.com \
--cc=1334@emacsbugs.donarmstrong.com \
--cc=cyd@stupidchicken.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).