From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mike Kupfer Newsgroups: gmane.emacs.bugs Subject: bug#60423: 29.0.60; goto-address and shr/textsec don't play nicely together Date: Tue, 08 Oct 2024 17:09:06 -0700 Message-ID: <69964.1728432546@alto.camomileplus.org> References: <175894.1672372745@alto> <831qoh6j0i.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23465"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60423@debbugs.gnu.org, Eli Zaretskii To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 09 02:10:11 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1syKHL-0005xt-AR for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 09 Oct 2024 02:10:11 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1syKH6-0001lv-Bp; Tue, 08 Oct 2024 20:09:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1syKH3-0001gs-NE for bug-gnu-emacs@gnu.org; Tue, 08 Oct 2024 20:09:53 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1syKH3-0003RU-Bm for bug-gnu-emacs@gnu.org; Tue, 08 Oct 2024 20:09:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:MIME-Version:References:In-reply-to:From:To:Subject; bh=faOlDdmfM0qGwFDIPqbS7XRB6ZQBzYTngoLGaBtHE68=; b=P4iIf1cmizciwg228yW3Atmr7IfRJgjTVIGub+iJcLIsShhW11Y4uVEPaOC/0lXjSbNejGqVbb6Lbv8Fm6EZ4u4szKWnkVoX/Lovkns89rerY1n4N0aHm1j6gJQ5P/YHuztTeB6xTl037FTYQxc3p9kPuuNrgO8ELF0+FCSuYpHAX7aAWg9TRKYTYAPxe3y1qYjF8t+jjeXjG1qmvS12E2kRTSHgaKPabr5VRd+MG4oXvsCTWhLw/J5ByVtUGnikg2bkiqVhw5j/oERsUwstWiTRXI/hcCkWwr1uCm/v910shvZdDWDAWN7RmxkelGlpYs+vM8x78NKerf0UZ6kLYQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1syKHC-0007nZ-Cy for bug-gnu-emacs@gnu.org; Tue, 08 Oct 2024 20:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mike Kupfer Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Oct 2024 00:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60423 X-GNU-PR-Package: emacs Original-Received: via spool by 60423-submit@debbugs.gnu.org id=B60423.172843256729923 (code B ref 60423); Wed, 09 Oct 2024 00:10:02 +0000 Original-Received: (at 60423) by debbugs.gnu.org; 9 Oct 2024 00:09:27 +0000 Original-Received: from localhost ([127.0.0.1]:54910 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syKGc-0007mZ-Pf for submit@debbugs.gnu.org; Tue, 08 Oct 2024 20:09:27 -0400 Original-Received: from shell1.rawbw.com ([198.144.192.42]:21398 ident=root) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syKGZ-0007mM-T8 for 60423@debbugs.gnu.org; Tue, 08 Oct 2024 20:09:25 -0400 Original-Received: from alto.camomileplus.org (135-180-174-211.dsl.dynamic.sonic.net [135.180.174.211] (may be forged)) (authenticated bits=0) by shell1.rawbw.com (8.15.1/8.15.1) with ESMTPSA id 4990966k045808 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 8 Oct 2024 17:09:11 -0700 (PDT) (envelope-from kupfer@rawbw.com) X-Authentication-Warning: shell1.rawbw.com: Host 135-180-174-211.dsl.dynamic.sonic.net [135.180.174.211] (may be forged) claimed to be alto.camomileplus.org In-reply-to: Comments: In-reply-to Stefan Kangas message dated "Tue, 05 Sep 2023 16:31:18 -0700." X-Mailer: MH-E 8.6+git; nmh 1.8-RC2; Emacs 30.0.91 Content-ID: <69963.1728432546.1@alto.camomileplus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293177 Archived-At: Stefan Kangas wrote: > Mike, did you make any progress here? Thanks in advance. I finally have some progress to report. The root cause of the fontification conflict between goto-address and shr/textsec is that the textsec code uses text properties, goto-address uses overlays, and overlays override text properties. So one possible approach to fix this would be for the textsec code to use overlays, and give the textsec overlay a higher priority than the goto-address overlay. I see a couple potential drawbacks with that approach: 1. shr originally used overlays; it was changed to use text properties because of performance concerns (see https://lists.gnu.org/r/emacs-diffs/2013-06/msg00215.html). Of course, that was over 10 years ago, and processors are faster now. And maybe shr could use overlays for the textsec stuff and text properties everywhere else? 2. AFAICT, there's no system for coordinating overlay priorities across different packages or subsystems. I think that makes the priority mechanism brittle, and for that reason I'm reluctant to use it. So I lean towards having goto-address leave text alone (don't set an overlay) if it finds text properties set for the text. If you have any recommendations or other comments, please let me know. thanks, mike