From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?Lindstr=C3=B6m?= Newsgroups: gmane.emacs.bugs Subject: bug#71499: [PATCH] Make whitespace.el cleanup add missing final newline Date: Sat, 29 Jun 2024 13:59:03 +0200 Message-ID: <690f2378-fa81-48bf-a780-3ee9ad59e579@app.fastmail.com> References: <9453e7ef-dc31-4074-bba7-55a192313ccd@app.fastmail.com> <86tthy1u37.fsf@gnu.org> <86cyom1os2.fsf@gnu.org> <86jzitz1l0.fsf@gnu.org> <864j9e7s5n.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=fcc8120cc54144519a26de39c7f7fcda Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15672"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Cyrus-JMAP/3.11.0-alpha0-538-g1508afaa2-fm-20240616.001-g1508afaa To: "Eli Zaretskii" , 71499@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 29 14:00:31 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sNWko-0003p4-AP for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 29 Jun 2024 14:00:30 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sNWkR-0006LS-7S; Sat, 29 Jun 2024 08:00:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNWkM-0006Kz-P6 for bug-gnu-emacs@gnu.org; Sat, 29 Jun 2024 08:00:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sNWkM-0004zV-Dy for bug-gnu-emacs@gnu.org; Sat, 29 Jun 2024 08:00:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sNWkM-0005ja-1V for bug-gnu-emacs@gnu.org; Sat, 29 Jun 2024 08:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?Lindstr=C3=B6m?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Jun 2024 12:00:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71499 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71499-submit@debbugs.gnu.org id=B71499.171966237121969 (code B ref 71499); Sat, 29 Jun 2024 12:00:01 +0000 Original-Received: (at 71499) by debbugs.gnu.org; 29 Jun 2024 11:59:31 +0000 Original-Received: from localhost ([127.0.0.1]:37259 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNWjr-0005iH-7a for submit@debbugs.gnu.org; Sat, 29 Jun 2024 07:59:31 -0400 Original-Received: from fhigh8-smtp.messagingengine.com ([103.168.172.159]:53237) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNWjp-0005i0-HX for 71499@debbugs.gnu.org; Sat, 29 Jun 2024 07:59:30 -0400 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailfhigh.nyi.internal (Postfix) with ESMTP id AD8D11140304; Sat, 29 Jun 2024 07:59:24 -0400 (EDT) Original-Received: from imap43 ([10.202.2.93]) by compute3.internal (MEProxy); Sat, 29 Jun 2024 07:59:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pobox.com; h=cc :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1719662364; x=1719748764; bh=n8yKcHBhnq fZHz0J/wJ1CaSKRuHy7pnsK/Qmjqp1qV8=; b=PiML67lOFdmZffhXoTC+h/fa4N zBpIDPcIaPA9hfT+dYWiR8OI5TPyBdOZLEW8DSuko82huVkJQCdehXSducXdePK+ M7+PUK8QQDs0ZYT6msDhmrm8sixQXR100cixlbNF3H4UJirpUFRLJzAD+RiHTrtk HMGKSCgpCtwertayIFAspREy7gd7zcZZiCMGeMld7FGkEYCgR2/jsXgyIS5euOn2 J4m48PveVnUMZhzKszygGRgLnRi/0Y2aqzXdqY7kzsJwsYFrlB2nhD0OH2UxZ8Pt 3DezCYWDuONfS0S4ywFpuobgZUgnCx2KvBe9xO3ZErLgO0FEY404do9cZ6iA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1719662364; x=1719748764; bh=n8yKcHBhnqfZHz0J/wJ1CaSKRuHy 7pnsK/Qmjqp1qV8=; b=SwXc+cRg/Tn+VVKASnkW5OmvFrcv5JI9z8MxHty2N1h9 3q0dmjP7LavkftTOJi0t6oer4ctfTeLJtX4YYT71bqV8B4MWO52gwU7YlwOr2TtK 1jQPl8vdS/YIjxlbxu1MbCsTPISWqAaDjkV8+h8QNXy5cvT3JZcvtOtT9Zjj7XYv dQytTJbVsWKf0Lfi4RKLX5eOTtj4iPSNdWQp3pSTYXqBaMBQRPvMpnbS4hodyHbw 5HEnd/xWME0uHSSsRro3r2GiGPg83+6K6Xj3alWAK/r4tXGNmQbJLShfNmIUJwiK nXdXpBnOsaIw4BhbYrjcjulCuV8Cya1x4Hz8mNHDtA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrtdelgdegkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvufgtsehmtderreerreejnecuhfhrohhmpeeujhpnrhhn ucfnihhnughsthhrnphmuceosghkhhhlsegvlhgvkhhtrhhusggrughurhdrshgvqeenuc ggtffrrghtthgvrhhnpedtheefteduuefgfeegudfflefggefgudeiffehiefggfektdfg ieefffdthefgteenucffohhmrghinhepvghlrdhithenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegskhhhlhesvghlvghkthhruhgsrgguuhhr rdhsvg X-ME-Proxy: Feedback-ID: i05c146bc:Fastmail Original-Received: by mailuser.nyi.internal (Postfix, from userid 501) id 429832D4007D; Sat, 29 Jun 2024 07:59:24 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface In-Reply-To: <864j9e7s5n.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288109 Archived-At: --fcc8120cc54144519a26de39c7f7fcda Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello, updated patch attached, which ads a note to NEWS, and has a changed impl= ementation of the insertion of missing newline inspired by the one from = files.el. It's still slightly different to account for it also being pos= sible to use on a region. This time there's also an added test. / Bj=C3=B6rn On Thu, Jun 27, 2024, at 09:37, Eli Zaretskii wrote: >> Cc: 71499@debbugs.gnu.org, stefankangas@gmail.com, bkhl@elektrubadur.= se >> Date: Thu, 13 Jun 2024 11:30:51 +0300 >> From: Eli Zaretskii >>=20 >> Meanwhile, Bj=C3=B6rn, I have a few comments to the patch: >>=20 >> . it needs a NEWS entry announcing the new feature >> . is there any reason your code to handle the missing newline is not >> identical to what the implementation of require-final-newline >> does? > > Ping! Bj=C3=B6rn, can you please post an updated patch with the above= nits > taken care of? We can install this now on the master branch. --fcc8120cc54144519a26de39c7f7fcda Content-Disposition: attachment; filename*0="0001-Make-whitespace.el-cleanup-add-missing-final-newline.pat"; filename*1="ch" Content-Type: text/x-patch; name="=?UTF-8?Q?0001-Make-whitespace.el-cleanup-add-missing-final-newline.patc?= =?UTF-8?Q?h?=" Content-Transfer-Encoding: BASE64 RnJvbSBhNmNhNzk4NGRmM2VlYzgwZThhMzZkZWQ3M2QwNjgwNzNkOWE1YTBiIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Qmo9QzM9QjZybj0yMExpbmRzdHI9 QzM9QjZtPz0gPGJraGxAZWxla3RydWJhZHVyLnNlPgpEYXRlOiBUdWUsIDExIEp1biAyMDI0 IDE5OjQ5OjU1ICswMjAwClN1YmplY3Q6IFtQQVRDSF0gTWFrZSB3aGl0ZXNwYWNlLmVsIGNs ZWFudXAgYWRkIG1pc3NpbmcgZmluYWwgbmV3bGluZQoKKiBsaXNwL3doaXRlc3BhY2UuZWwg KHdoaXRlc3BhY2UtY2xlYW51cC1yZWdpb24pOiBpZiBjbGVhbmluZyB1cCBhdCBlbmQKb2Yg ZmlsZSwgYWRkIG1pc3NpbmcgbmV3bGluZSBpZiBpbmRpY2F0ZWQgYnkgd2hpdGVzcGFjZS1z dHlsZS4KLS0tCiBldGMvTkVXUyAgICAgICAgICAgICAgICAgICAgICB8ICA2ICsrKysrKwog bGlzcC93aGl0ZXNwYWNlLmVsICAgICAgICAgICAgfCAxNiArKysrKysrKysrKysrKystCiB0 ZXN0L2xpc3Avd2hpdGVzcGFjZS10ZXN0cy5lbCB8IDE1ICsrKysrKysrKysrKysrLQogMyBm aWxlcyBjaGFuZ2VkLCAzNSBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAt LWdpdCBhL2V0Yy9ORVdTIGIvZXRjL05FV1MKaW5kZXggYWYzMmE5M2Q5YzQuLjlmNjFhNGFh NGNlIDEwMDY0NAotLS0gYS9ldGMvTkVXUworKysgYi9ldGMvTkVXUwpAQCAtMzYsNiArMzYs MTIgQEAgYXBwbGllcywgYW5kIHBsZWFzZSBhbHNvIHVwZGF0ZSBkb2NzdHJpbmdzIGFzIG5l ZWRlZC4KIAwKICogQ2hhbmdlcyBpbiBTcGVjaWFsaXplZCBNb2RlcyBhbmQgUGFja2FnZXMg aW4gRW1hY3MgMzEuMQogCistLS0KKyoqIFdoaXRlc3BhY2UKKyd3aGl0ZXNwYWNlLWNsZWFu dXAnIG5vdyBhZGRzIG1pc3NpbmcgbmV3bGluZSBhdCBlbmQgb2YgZmlsZSBJZgorJ3doaXRl c3BhY2Utc3R5bGUnIGluY2x1ZGVzICdtaXNzaW5nLW5ld2xpbmUtYXQtZW9mICh3aGljaCBp cyB0aGUKK2RlZmF1bHQpLCB0aGUgJ3doaXRlc3BhY2UtY2xlYW51cCcgZnVuY3Rpb24gd2ls bCBmaXggdGhpcyB3aGVuIHJ1bi4KKwogDAogKiBOZXcgTW9kZXMgYW5kIFBhY2thZ2VzIGlu IEVtYWNzIDMxLjEKIApkaWZmIC0tZ2l0IGEvbGlzcC93aGl0ZXNwYWNlLmVsIGIvbGlzcC93 aGl0ZXNwYWNlLmVsCmluZGV4IGJjMjNhODc5NGViLi4yOGQxMzFiMDU0YyAxMDA2NDQKLS0t IGEvbGlzcC93aGl0ZXNwYWNlLmVsCisrKyBiL2xpc3Avd2hpdGVzcGFjZS5lbApAQCAtMTQ2 NSw2ICsxNDY1LDExIEBAIGRlZnVuIHdoaXRlc3BhY2UtY2xlYW51cC1yZWdpb24KICAgIElm IGB3aGl0ZXNwYWNlLXN0eWxlJyBpbmNsdWRlcyB0aGUgdmFsdWUKICAgIGBzcGFjZS1hZnRl ci10YWI6OnNwYWNlJywgcmVwbGFjZSBUQUJzIGJ5IFNQQUNFcy4KIAorNS4gbWlzc2luZyBu ZXdsaW5lIGF0IGVuZCBvZiBmaWxlLgorICAgSWYgYHdoaXRlc3BhY2Utc3R5bGUnIGluY2x1 ZGVzIHRoZSB2YWx1ZSBgbWlzc2luZy1uZXdsaW5lLWF0LWVvZicsCisgICBhbmQgdGhlIGNs ZWFudXAgcmVnaW9uIGluY2x1ZGVzIHRoZSBlbmQgb2YgZmlsZSwgYWRkIGEgZmluYWwgbmV3 bGluZQorICAgaWYgaXQgaXMgbm90IHRoZXJlIGFscmVhZHkuCisKIFNlZSBgd2hpdGVzcGFj ZS1zdHlsZScsIGBpbmRlbnQtdGFicy1tb2RlJyBhbmQgYHRhYi13aWR0aCcgZm9yCiBkb2N1 bWVudGF0aW9uLiIKICAgKGludGVyYWN0aXZlICJAciIpCkBAIC0xNTQ1LDcgKzE1NTAsMTYg QEAgZGVmdW4gd2hpdGVzcGFjZS1jbGVhbnVwLXJlZ2lvbgogICAgICAgICAgKChtZW1xICdz cGFjZS1iZWZvcmUtdGFiOjpzcGFjZSB3aGl0ZXNwYWNlLXN0eWxlKQogICAgICAgICAgICh3 aGl0ZXNwYWNlLXJlcGxhY2UtYWN0aW9uCiAgICAgICAgICAgICd1bnRhYmlmeSByc3RhcnQg cmVuZAotICAgICAgICAgICB3aGl0ZXNwYWNlLXNwYWNlLWJlZm9yZS10YWItcmVnZXhwIDIp KSkpCisgICAgICAgICAgIHdoaXRlc3BhY2Utc3BhY2UtYmVmb3JlLXRhYi1yZWdleHAgMikp KQorICAgICAgICA7OyBQUk9CTEVNIDU6IG1pc3NpbmcgbmV3bGluZSBhdCBlbmQgb2YgZmls ZQorICAgICAgICAoYW5kIChtZW1xICdtaXNzaW5nLW5ld2xpbmUtYXQtZW9mIHdoaXRlc3Bh Y2Utc3R5bGUpCisgICAgICAgICAgICAgKD4gKHBvaW50LW1heCkgKHBvaW50LW1pbikpCisg ICAgICAgICAgICAgKD0gKHBvaW50LW1heCkgKHdpdGhvdXQtcmVzdHJpY3Rpb24gKHBvaW50 LW1heCkpKQorICAgICAgICAgICAgICgvPSAoY2hhci1iZWZvcmUgKHBvaW50LW1heCkpID9c bikKKyAgICAgICAgICAgICAobm90IChhbmQgKGVxIHNlbGVjdGl2ZS1kaXNwbGF5IHQpCisg ICAgICAgICAgICAgICAgICAgICAgICg9IChjaGFyLWJlZm9yZSAocG9pbnQtbWF4KSkgP1xy KSkpCisgICAgICAgICAgICAgKGdvdG8tY2hhciAocG9pbnQtbWF4KSkKKyAgICAgICAgICAg ICAoaWdub3JlLWVycm9ycyAoaW5zZXJ0ICJcbiIpKSkpCiAgICAgICAoc2V0LW1hcmtlciBy ZW5kIG5pbCkpKSkJCTsgcG9pbnQgbWFya2VyIHRvIG5vd2hlcmUKIAogCmRpZmYgLS1naXQg YS90ZXN0L2xpc3Avd2hpdGVzcGFjZS10ZXN0cy5lbCBiL3Rlc3QvbGlzcC93aGl0ZXNwYWNl LXRlc3RzLmVsCmluZGV4IDczYzdlNzQyZWM1Li5iZDM1YjNhYzlmMyAxMDA2NDQKLS0tIGEv dGVzdC9saXNwL3doaXRlc3BhY2UtdGVzdHMuZWwKKysrIGIvdGVzdC9saXNwL3doaXRlc3Bh Y2UtdGVzdHMuZWwKQEAgLTgsNyArOCw2IEBACiA7OyBpdCB1bmRlciB0aGUgdGVybXMgb2Yg dGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGFzIHB1Ymxpc2hlZCBieQogOzsgdGhl IEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbiwgZWl0aGVyIHZlcnNpb24gMyBvZiB0aGUgTGlj ZW5zZSwgb3IKIDs7IChhdCB5b3VyIG9wdGlvbikgYW55IGxhdGVyIHZlcnNpb24uCi0KIDs7 IEdOVSBFbWFjcyBpcyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUg dXNlZnVsLAogOzsgYnV0IFdJVEhPVVQgQU5ZIFdBUlJBTlRZOyB3aXRob3V0IGV2ZW4gdGhl IGltcGxpZWQgd2FycmFudHkgb2YKIDs7IE1FUkNIQU5UQUJJTElUWSBvciBGSVRORVNTIEZP UiBBIFBBUlRJQ1VMQVIgUFVSUE9TRS4gIFNlZSB0aGUKQEAgLTk0LDYgKzkzLDIwIEBAIGRl ZnVuIHdoaXRlc3BhY2UtdGVzdHMtLWNsZWFudXAtc3RyaW5nCiAgICAgKHNob3VsZCAoZXF1 YWwgKHdoaXRlc3BhY2UtdGVzdHMtLWNsZWFudXAtc3RyaW5nICJhICBcblx0IFxuXG4iKQog ICAgICAgICAgICAgICAgICAgICJhICBcbiIpKSkpCiAKKyhlcnQtZGVmdGVzdCB3aGl0ZXNw YWNlLWNsZWFudXAtbWlzc2luZy1uZXdsaW5lLWF0LWVvZiAoKQorICAobGV0ICgod2hpdGVz cGFjZS1zdHlsZSAnKGVtcHR5IG1pc3NpbmctbmV3bGluZS1hdC1lb2YpKSkKKyAgICAoc2hv dWxkIChlcXVhbCAod2hpdGVzcGFjZS10ZXN0cy0tY2xlYW51cC1zdHJpbmcgIiIpCisgICAg ICAgICAgICAgICAgICAgIiIpKQorICAgIChzaG91bGQgKGVxdWFsICh3aGl0ZXNwYWNlLXRl c3RzLS1jbGVhbnVwLXN0cmluZyAiYSIpCisgICAgICAgICAgICAgICAgICAgImFcbiIpKQor ICAgIChzaG91bGQgKGVxdWFsICh3aGl0ZXNwYWNlLXRlc3RzLS1jbGVhbnVwLXN0cmluZyAi YVxuXHQiKQorICAgICAgICAgICAgICAgICAgICJhXG4iKSkKKyAgICAoc2hvdWxkIChlcXVh bCAod2hpdGVzcGFjZS10ZXN0cy0tY2xlYW51cC1zdHJpbmcgImFcblx0ICIpCisgICAgICAg ICAgICAgICAgICAgImFcbiIpKQorICAgIChzaG91bGQgKGVxdWFsICh3aGl0ZXNwYWNlLXRl c3RzLS1jbGVhbnVwLXN0cmluZyAiYVxuXHQgIikKKyAgICAgICAgICAgICAgICAgICAiYVxu IikpCisgICAgKHNob3VsZCAoZXF1YWwgKHdoaXRlc3BhY2UtdGVzdHMtLWNsZWFudXAtc3Ry aW5nICJcblx0IikKKyAgICAgICAgICAgICAgICAgICAiIikpKSkKIAogOzsgV2UgY2Fubm90 IGNhbGwgd2hpdGVzcGFjZS1tb2RlIGJlY2F1c2UgaXQgd2lsbCBkbyBub3RoaW5nIGluIGJh dGNoCiA7OyBtb2RlLiAgU28gd2UgY2FsbCBpdHMgaW5uYXJkcyBpbnN0ZWFkLgotLSAKMi40 NS4yCgo= --fcc8120cc54144519a26de39c7f7fcda--