unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Mike Kupfer <kupfer@rawbw.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: luangruo@yahoo.com, tumashu@163.com, stephen.berman@gmx.net,
	58771@debbugs.gnu.org, visuweshm@gmail.com
Subject: bug#58771: 29.0.50; context submenu can not click when run emacs lucid build.
Date: Thu, 12 Jan 2023 21:23:52 -0800	[thread overview]
Message-ID: <69068.1673587432@alto> (raw)
In-Reply-To: Your message of "Thu, 12 Jan 2023 10:56:21 +0200." <83k01sku6i.fsf@gnu.org>

Eli Zaretskii wrote:

> > Cc: Feng Shu <tumashu@163.com>, Stephen Berman <stephen.berman@gmx.net>,
> >  58771@debbugs.gnu.org, Visuwesh <visuweshm@gmail.com>
> > From: Mike Kupfer <kupfer@rawbw.com>
> > Date: Wed, 11 Jan 2023 12:44:40 -0800
> > 
> > Po Lu wrote:
> > 
> > > I have a hunch.  If you touch globals.h in src, does it result in files
> > > under the lwlib directory being rebuilt?
> > 
> > Good call.  Nothing in lwlib gets rebuilt:
> 
> Which files in lwlib should be rebuilt?  And what do you see in
> lwlib/deps/ for those files?

We're particularly interested in seeing that lwlib/xlwmenu.o get rebuilt
when globals.h changes.  pop_up_menu() will not call XtGrabKeyboard() or
XtSetKeyboardFocus() if globals.f_lucid__menu_grab_keyboard is false.
And that seems to be what's behind all these intermittent problems with
Lucid popup menus.

lwlib/deps/xlwmenu.d looks okay to me, as it has:

xlwmenu.o: xlwmenu.c ../src/config.h ../src/conf_post.h ../src/lisp.h \
 ../lib/alloca.h ../lib/string.h ../lib/inttypes.h ../lib/attribute.h \
 ../lib/intprops.h ../lib/intprops-internal.h ../lib/verify.h \
 ../src/globals.h ../src/comp.h ../src/dynlib.h ../src/thread.h \
 ../src/regex-emacs.h ../src/lisp.h ../src/sysselect.h \
 ../lib/sys/select.h ../src/systhread.h ../lib/stdio.h xlwmenuP.h \

> Could it be that the root cause for this is that ALLOBJS is not
> defined in lwlib/Makefile.in?

I think you've identified the problem.  I tried hacking lwlib/Makefile
as follows:

--- Makefile~	2022-12-29 17:42:05.288751298 -0800
+++ Makefile	2023-01-12 21:08:24.717146041 -0800
@@ -57,6 +57,8 @@
 
 OBJS = lwlib.o $(TOOLKIT_OBJS) lwlib-utils.o
 
+ALLOBJS = $(OBJS)
+
 -include ${top_builddir}/src/verbose.mk
 
 AUTO_DEPEND = yes

Now, when I touch src/globals.h and run "make", xlwmenu.o does get
rebuilt.

...
make[2]: Entering directory '/home/kupfer/src/emacs-git/src'
make -C ../lwlib/ liblw.a
make[3]: Entering directory '/home/kupfer/src/emacs-git/lwlib'
  CC       lwlib.o
  CC       lwlib-Xlw.o
  CC       xlwmenu.o
  CC       lwlib-Xaw.o
  CC       lwlib-utils.o
  GEN      liblw.a
make[3]: Leaving directory '/home/kupfer/src/emacs-git/lwlib'
...

mike





  reply	other threads:[~2023-01-13  5:23 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-25  5:28 bug#58771: 29.0.50; context submenu can not click when run emacs lucid build Feng Shu
2022-10-25  7:43 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-25  8:35   ` Feng Shu
2022-10-25 10:30     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-25 13:58       ` Stephen Berman
2022-10-26  0:42         ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-26  8:00           ` Stephen Berman
2022-10-26  8:18             ` Visuwesh
2022-10-26  9:40               ` Stephen Berman
2023-01-11  6:57               ` Mike Kupfer
2023-01-11  9:47                 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-11 20:44                   ` Mike Kupfer
2023-01-12  1:22                     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-12  2:16                       ` Mike Kupfer
2023-01-12  3:44                         ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-12  8:05                           ` Eli Zaretskii
2023-01-12 10:34                             ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-13  2:43                               ` Mike Kupfer
2023-01-13  7:19                                 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-13  7:32                                   ` Eli Zaretskii
2023-01-14  2:28                                     ` Paul Eggert
2023-01-14  7:25                                       ` Eli Zaretskii
2023-01-14  7:48                                         ` Paul Eggert
2023-01-13  7:35                                   ` Jean Louis
2023-01-12  8:56                     ` Eli Zaretskii
2023-01-13  5:23                       ` Mike Kupfer [this message]
2022-10-26  8:20             ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-26  9:40               ` Stephen Berman
2022-10-26  9:55                 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-26  2:14   ` Feng Shu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=69068.1673587432@alto \
    --to=kupfer@rawbw.com \
    --cc=58771@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=luangruo@yahoo.com \
    --cc=stephen.berman@gmx.net \
    --cc=tumashu@163.com \
    --cc=visuweshm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).