From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#64275: 30.0.50; [PATCH] Improve sigil font-lock match for elixir-ts-mode Date: Sun, 30 Jul 2023 05:06:37 +0300 Message-ID: <68d19873-5c5f-894a-080f-b2e1bacc449a@gutov.dev> References: <87zg4od38w.fsf@gmail.com> <87ttuvorbw.fsf@epfl.ch> <87y1k7j4ov.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9095"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: 64275@debbugs.gnu.org To: Wilhelm Kirschbaum , Basil Contovounesios Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 30 04:37:47 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qPwJX-000281-At for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 Jul 2023 04:37:47 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qPvpo-0001PD-Vd; Sat, 29 Jul 2023 22:07:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qPvpm-0001Op-Gt for bug-gnu-emacs@gnu.org; Sat, 29 Jul 2023 22:07:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qPvpm-0005Op-9V for bug-gnu-emacs@gnu.org; Sat, 29 Jul 2023 22:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qPvpl-00022A-RK for bug-gnu-emacs@gnu.org; Sat, 29 Jul 2023 22:07:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Jul 2023 02:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64275 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64275-submit@debbugs.gnu.org id=B64275.16906828087796 (code B ref 64275); Sun, 30 Jul 2023 02:07:01 +0000 Original-Received: (at 64275) by debbugs.gnu.org; 30 Jul 2023 02:06:48 +0000 Original-Received: from localhost ([127.0.0.1]:49116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qPvpX-00021g-Pf for submit@debbugs.gnu.org; Sat, 29 Jul 2023 22:06:48 -0400 Original-Received: from out2-smtp.messagingengine.com ([66.111.4.26]:42341) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qPvpV-00021J-1K for 64275@debbugs.gnu.org; Sat, 29 Jul 2023 22:06:45 -0400 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 940F25C008C; Sat, 29 Jul 2023 22:06:39 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sat, 29 Jul 2023 22:06:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1690682799; x=1690769199; bh=isqnNNidy2AjoSBARl5sla5Fp5KsDbaskm1 wcCE1LAY=; b=IRKnJPWaugdPRQLLw4jbsB1D7B4evPipkq0qsdPhbCPCmNkh6Aj MnRtJSmWJvQaEXWeqELurvomr0DEqXqbF4A6be0CO/8mh3GXrhjHZ4O/jPc6bZL/ RK5OAf5eN129F+NOM9g7qT65k0Nnkxp6BWgxFhm4h+SQF9BNhzbETYhaHu5aRNb9 iy89iAQUpa4PrSSHKhWFGTBcBUxa+eeWQsamM8h8LOCrcOnvssaD/ImX4rETxt0c kdGmgp19MXgdyVobI+E22m45eUfcQvG0OUBtHTVxOxpo70VuqNba+F6tjj/3pZYn wciUst1AukX2iJrRW9hHhOVLARuekamG4tA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1690682799; x=1690769199; bh=isqnNNidy2AjoSBARl5sla5Fp5KsDbaskm1 wcCE1LAY=; b=WiH61AzhoRfM9GKnGu+JIaaLzjwuVWbNCrlz8E2WmtiPwDjyE6N kFOs6Iz+oMlVAKsIeVWJ9o7SM5G4ZvgB9zT2MdD0n1m6YCxIgVb1CKgLUc5ZxBi4 WWYLqzvdFCp374BE48syDSBCb2iMG9wYZsxp19nSGjyKhrRk+T6arhZWNZDtuxb8 JRhTy8PCrTFjhufMe6IBNXDxoUmiM33coPrz/jYshvtcETRrAgE19KIi5prNdonI wAXA1Krq2a2/4Nsw0n3I/EzcOglnvf5Vcwp53AxM5sS2SPbZRzjgSp2JKwT2wkIt dyYpT7QMfhM7b5BdjRH+0ws9yAP1WpEptJA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrieelgdehgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpeeigfetveehveevffehledtueekieeikeeufeegudfgfeeghfdulefgfeevledv veenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh hithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 29 Jul 2023 22:06:38 -0400 (EDT) Content-Language: en-US In-Reply-To: <87y1k7j4ov.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266348 Archived-At: On 25/06/2023 12:00, Wilhelm Kirschbaum wrote: > "~" @font-lock-string-face > (sigil_name) @elixir-ts-font-sigil-name-face > (:match "^[rR]$" @elixir-ts-font-sigil-name-face)) > @font-lock-regexp-face > - (sigil > - "~" @font-lock-string-face > - (sigil_name) @elixir-ts-font-sigil-name-face > - quoted_start: _ @font-lock-string-face > - quoted_end: _ @font-lock-string-face > - (:match "^[HF]$" @elixir-ts-font-sigil-name-face))) > - > + (sigil) @font-lock-string-face) Hi Wilhelm! Should we continue to use elixir-ts-font-sigil-name-face, though? With the new patch, it will continue highlight the sigil name ("r") in regexps, but no in other sigil types (s/c/w). What's your opinion on that?