From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#54028: Window is not a valid window Date: Thu, 17 Feb 2022 11:06:13 +0100 Message-ID: <68b4d9be-5e50-a541-9031-787fa7ce3b7c@gmx.at> References: <865ypey7bz.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------K27HJ0fZTO1y014HX06fUoY7" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30001"; mail-complaints-to="usenet@ciao.gmane.io" To: Juri Linkov , 54028@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 17 11:18:37 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nKdrx-0007cW-CA for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Feb 2022 11:18:37 +0100 Original-Received: from localhost ([::1]:41236 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nKdrw-0005ul-Ef for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Feb 2022 05:18:36 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:44762) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nKdgl-0000VN-7m for bug-gnu-emacs@gnu.org; Thu, 17 Feb 2022 05:07:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56317) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nKdgk-0000sS-S1 for bug-gnu-emacs@gnu.org; Thu, 17 Feb 2022 05:07:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nKdgk-0002hw-Nq for bug-gnu-emacs@gnu.org; Thu, 17 Feb 2022 05:07:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Feb 2022 10:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54028 X-GNU-PR-Package: emacs Original-Received: via spool by 54028-submit@debbugs.gnu.org id=B54028.164509238210349 (code B ref 54028); Thu, 17 Feb 2022 10:07:02 +0000 Original-Received: (at 54028) by debbugs.gnu.org; 17 Feb 2022 10:06:22 +0000 Original-Received: from localhost ([127.0.0.1]:50213 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKdg6-0002gr-K2 for submit@debbugs.gnu.org; Thu, 17 Feb 2022 05:06:22 -0500 Original-Received: from mout.gmx.net ([212.227.17.22]:42033) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKdg4-0002gb-Ag for 54028@debbugs.gnu.org; Thu, 17 Feb 2022 05:06:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1645092374; bh=LIiTLPg0pf5X3f4ojU0sC6+ZnGu/G00NfBkpT6/Qe9E=; h=X-UI-Sender-Class:Date:Subject:To:References:From:In-Reply-To; b=hI57FaovBKfd60iOty0EZEcMSpMy/sHIGuFd22zrRsmPtGdTTnIecPUIUeDNj5MbJ iG5KI0lbjVMJMgLJGkyXhB81HpERaFDdcsHk5SRaYj17llQx89VJC9wF1TRUjHin6X lrBbSpPUnJ0DXzQEk+Nx7n9yghhs4au0Puk9BHoU= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.101] ([213.142.96.55]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mof57-1o5G6W3kXR-00p3Mh; Thu, 17 Feb 2022 11:06:14 +0100 Content-Language: en-US In-Reply-To: <865ypey7bz.fsf@mail.linkov.net> X-Provags-ID: V03:K1:pk9jOzmv0n5PO0aD9JjadgPT4AF+79neHUo0SUosZymUqn3h9e7 F+MaiT9KrkPrxFBX/30Mt5m3++uwgMM1YL/ZtXpfMsmR7/tNQxPnIN18kHyxOZ1X+6W0A6d AhR48sw+Or2wON/wvultWVP9AihKLG+Jqv9hKaHexZJbH8WuTFh5YTz76tuxGZAt+PkB/G2 uw33h+qNIU1TDZ76hVBZw== X-UI-Out-Filterresults: notjunk:1;V03:K0:AacqlBFzaKE=:wjQ0foZyaSk24HaKzCo2Uq ItGTqXrdabWzK3Ia/OcDge11WlU5uuWc5JvKFYPughPERgZTo9UsjL56+JVpHtQ/hkTbgel66 qWqRwWm60eOjTHXNp6LMHqSkkjdsgIjdU4dHAt4Ei4gPMtHOdh/uvnC3WEkIOLFLVV9eImBGM aU8Hi/T5aIIUyNIgvPuqbC3/x8/6/HfjMR8x960jTjhssC/rTzg84bPcjU85rKMdP2MsSmPlo fTt9RhXonLyx5KcO/NclxRywvJM8U3W6x6i/y8+r1NUmPax5Zj+PJeJgHvbwmNszP2WwUE/tj GFbHFvp1LdwdKmTwMoA9eOtiunIhDWcqUUgaxdJBAlJ1oTym+p54mEYCQ7LZj3bvfLTSzJM8D PKvkQswaYIhBiqMTTWHdcHglrbg58KUuUoOMYQjLFIGHPH0T108L/w9yV+k/TO6teN9IeSQ+G xsfuyBVc2veV9iSidHS7NBQE922KsP/mulp9UAtgr3mm15bXomHGdSw7mfWigip6JZ6Ge6BfQ Lflpr9SZc8TYIIiPBqmSzGjjLbmD49O/lA6US+W34LxAp0WhCGxnEHvjqOmmMWNG4dwPDpiH8 CfsRL8W1t1KfyWYK1ZcYw7Sz1Rzp4ucbf+V5fx3KdrLdnkb8oqJyqI6uNCNSiGDzfovkprypN eRu2cY4HkAGorCk9Ah1fDfELTMbh6BkqlFI/jAhXgNeTkpzGXjm5anlvz3QgBfVy6OtsFdYPN 9RCejlEkw8w105Jn/VRjez6c2Mr0D7iBj0yfmdwx2DlEllk7+fz4tjCpWlELeTWXQVvoJ1sE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227080 Archived-At: This is a multi-part message in MIME format. --------------K27HJ0fZTO1y014HX06fUoY7 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit > I don't know if the author of > https://www.reddit.com/r/emacs/comments/sthusa/window_xxx_is_not_a_valid_window_on_switching_tabs/ > will report the bug here, Please encourage the author again to report such bugs here. > but since it's easily reproducible, > here is the short test case, just evaluate this: > > (window-state-put > ... > nil 'safe) > > It fails with: > > Debugger entered--Lisp error: (error "# is not a valid window") > error("%s is not a valid window" #) > window-normalize-window(#) > window-deletable-p(#) > window-state-put I think the attached fixes it, please check. I have no idea whether the state is restored as intended, though. Thanks, martin --------------K27HJ0fZTO1y014HX06fUoY7 Content-Type: text/x-patch; charset=UTF-8; name="window-state-put.diff" Content-Disposition: attachment; filename="window-state-put.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3Avd2luZG93LmVsIGIvbGlzcC93aW5kb3cuZWwKaW5kZXggNTgy NjAwZTFjNi4uMzhiNTg3MTJiNCAxMDA2NDQKLS0tIGEvbGlzcC93aW5kb3cuZWwKKysrIGIv bGlzcC93aW5kb3cuZWwKQEAgLTYzOTQsNyArNjM5NCw4IEBAIHdpbmRvdy1zdGF0ZS1wdXQK IAkod2luZG93LS1zdGF0ZS1wdXQtMiBpZ25vcmUgcGl4ZWx3aXNlKSkKICAgICAgICh3aGls ZSB3aW5kb3ctc3RhdGUtcHV0LXN0YWxlLXdpbmRvd3MKIAkobGV0ICgod2luZG93IChwb3Ag d2luZG93LXN0YXRlLXB1dC1zdGFsZS13aW5kb3dzKSkpCi0JICAod2hlbiAoZXEgKHdpbmRv dy1kZWxldGFibGUtcCB3aW5kb3cpIHQpCisJICAod2hlbiAoYW5kICh3aW5kb3ctdmFsaWQt cCB3aW5kb3cpCisgICAgICAgICAgICAgICAgICAgICAoZXEgKHdpbmRvdy1kZWxldGFibGUt cCB3aW5kb3cpIHQpKQogCSAgICAoZGVsZXRlLXdpbmRvdyB3aW5kb3cpKSkpCiAgICAgICAo d2luZG93LS1jaGVjayBmcmFtZSkpKSkKIAo= --------------K27HJ0fZTO1y014HX06fUoY7--