From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#74361: [PATCH] New option xref-navigation-display-window-action Date: Thu, 28 Nov 2024 10:27:11 +0100 Message-ID: <688d5119-0900-46a4-86c7-32a9b06cc349@gmx.at> References: <87msi1ueb0.fsf@mail.linkov.net> <4256f446-e11b-450c-b455-131cb75acab0@gutov.dev> <871pzbj8mq.fsf@mail.linkov.net> <87sernhxoa.fsf@mail.linkov.net> <1d08c589-2d0e-4f10-8c2e-e21c206ac118@gmx.at> <78a96965-31c1-4688-b808-2de09d1832c4@gmx.at> <878qt9pz4w.fsf@mail.linkov.net> <05452bef-dd2e-4e93-abdd-6eb391027197@gmx.at> <87y118cyyk.fsf@mail.linkov.net> <871pyzp6br.fsf@mail.linkov.net> <25443bb1-788a-4f06-9350-5d2c666f6795@gmx.at> <32b8cc56-afa1-40f6-933f-6de0df2b9f63@gutov.dev> Reply-To: martin rudalics Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28255"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: 74361@debbugs.gnu.org To: Dmitry Gutov , Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 28 10:28:30 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tGap3-0007BJ-SV for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Nov 2024 10:28:30 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tGaof-0001UU-5g; Thu, 28 Nov 2024 04:28:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tGaod-0001Tz-77 for bug-gnu-emacs@gnu.org; Thu, 28 Nov 2024 04:28:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tGaoc-00041N-Uk for bug-gnu-emacs@gnu.org; Thu, 28 Nov 2024 04:28:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=959UeqEAEzWSQfktBk5D1VR9YTzGusSDBbTpNlObr80=; b=A7qgxQ3iFedgWUicy/ZWoKjA/q7A5il2g5AW1OJhHcOpUc1n5Ag39R/ZEcAd8HtKmQYBOEyFdNZjoA6ipgouAPBmEIfkxkDAos7PuEukGp+/78FdnIGYpFJf/J+xcw0qGEsnMKz/adNYDuleH2o15lpU6rUIIWHbFp6hwzaDpYR8mWjpXNi4frRV3+q5a9z/hzpMrcu0mVQivNM6T9ZXtbezKL9bgkAI5v3hei2uSv2J1v0I3kEEaBwoavtgtCiM0uT5qN34VwUig6vEA6duQ1iuSgI8afHBM4UZ9zqm+q1dN2k7idWjHjbZZu+wkP72Hh47AlFlUG9r+NalgDOQFA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tGaoc-00064v-Ct for bug-gnu-emacs@gnu.org; Thu, 28 Nov 2024 04:28:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Nov 2024 09:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74361 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74361-submit@debbugs.gnu.org id=B74361.173278604523296 (code B ref 74361); Thu, 28 Nov 2024 09:28:02 +0000 Original-Received: (at 74361) by debbugs.gnu.org; 28 Nov 2024 09:27:25 +0000 Original-Received: from localhost ([127.0.0.1]:36661 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGao0-00063g-SQ for submit@debbugs.gnu.org; Thu, 28 Nov 2024 04:27:25 -0500 Original-Received: from mout.gmx.net ([212.227.15.18]:42255) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGany-00063S-7F for 74361@debbugs.gnu.org; Thu, 28 Nov 2024 04:27:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.at; s=s31663417; t=1732786033; x=1733390833; i=rudalics@gmx.at; bh=959UeqEAEzWSQfktBk5D1VR9YTzGusSDBbTpNlObr80=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=H+PAhFO9uffDCOmzt200+S2gJ3Dlvrc8MjX51W7ArXiLMzExLbvu3rA1vtLHbGYR FeOGIZmdznBWh5BOw9ZDtLPM+FJ7cvg+WLvmLmJ6dF9lynyWlIGSKyoH0kelO8lDE Z1MRuv5xC/ClWuBj9dGpG6MDORJehzFDPakJh5lZpmZ3ZySjiv8Ccxzr93lam3V8B o+I+WXh1MhVlZ4OnvI6WSC1apXJiLpr1fVWPL9PjGdnAr1xtsfptUIo5eEDZKhYZB YZVNn30sYI/ak/Sw1L1oKTEiQdvzJggP9dJympr15BSInHKxhJV+/u/k6IoBlbDA4 zJH4xRT9ljAhkgsKtw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from [192.168.31.113] ([212.95.5.21]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MTRMs-1t6jPw3udo-00JuRA; Thu, 28 Nov 2024 10:27:13 +0100 Content-Language: en-US In-Reply-To: X-Provags-ID: V03:K1:+RMUSKKy18eHZ9ReEbQ58puKWsXf05LyxBQztemkkgoQzhgy74F rcEX5/JD7iVTLqLS5b7BdR0VwsbDOBifEFZQv4cBfaho9f3C1mfH7vm0BafhAoyKRejU9Kb HvFk++JutVcY5geNpnRDEYGgPg3Q3abtc/1yZHC/0jKVmeQNmSHkolysR0NWKFz5iSfMR2J AfcCN1JPAcGQRo9JRLH9A== UI-OutboundReport: notjunk:1;M01:P0:7W9yZri4AjI=;lvc5wdDbV8ZEk5i+HwNNUTbBPo1 KWiEgBYyrwdckyPknxQiRVEYFDyBo2iiFT2hhrFP0/Z3ijbcgO4n2zgnWZwZYg7FM3pZFXZM7 l2b9R235ONYHaWGfPuwJPg4WFsr7S+u4WkMUantFNgwKvbbfyiv6MI7V7dwIg3nZ+iYXoel/Z 5j4qzV9hIj5IE1bwtsguvrfhtDJp1su4k35DIwt3jqQ1ceXPCcoPOUY2b+gVo5yRz3HH/ZkcD HkO9mMJmVrObtaBpjUWSfTGSApgEPX9HOasNDT3czSmy7bLXvNzBWmVTBfoib0erHKuPygixe 7IeRoFi6FpTNOVmjcOGKrDVM0I5u+bcE5dk5cwMuD2k2M1s7lkO8DjS8CrsU+VGgncQTuyoiy XQf7U3g0P1DYhwB0tbJdPzGousFstigZQ51jllUVQFyENqBpG2ypqPZIw8fQ47jjIP0R56BTh E+uKs8NTRGl4ujfvqwmGYylMfa2WIS6QyajSDp+8ft+2Kj15cKQ9AvzQChrWOgdM7FvqglN0T vKx58qSqbJN8bxAdquoZjLC5EE6YFjdXxjn5N8rSWhkzCGNWYUuO7CAF6+61UQXmiY9HJWrLx YoZps64ViW5EYrqzW6FLglLENiqZjdCvOtq2KO5dvm4QQZs/9RoRVebuZPaYtIBtB+mRPNLJj aeGBoj3SmuyR7dlpCb/fP+OibvqPVeplc0feRAwIjD0Rc5RnsKmT2N5dLiCxpZ5o3DSc9pzSq HQBDrPEmAxuc9warIucnbHlHIMpe9xx3+zh6sJvp1Ql1b7IQhU40jX/qYTtd8GDfITVfl0DV X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296047 Archived-At: > It does seem like it will switch to the "mru" kind of placement > though: as soon as "some" other window is used for xref-jump once, all > the following similar calls will follow it. "mru" is a user option, the default is "lru". Once "mru" was chosen for a specific category, it will be chosen again until the user changes it. But it is true that the default "lru", once overridden by a category, will be overridden again - for 'xref-jump' iff the same window is not suitable. Still ... > Might be an improvement, but definitely an incompatible change. ... this is true. >> Is there any other 'display-buffer' call in xref.el that would set up a >> category and prefer any other but the selected window? > > By default, you mean? If default stands for using the ACTION argument of 'display-buffer', then "yes". > We want to select the new window in relation the "original" window > (with a file-visiting buffer), while avoiding touching the "results > list" window as well. E.g. when the original command was > xref-find-definitions-other-window. Let's see what Juri thinks of an (unsuitable . window-or-list-of-windows) alist entry. > It's probably not an ideal solution, but one settled on over several tries. It is a pain for the caller. > Either seems reasonable to me, just as long as the choices can be > anticipated in advance by the user. Agreed. martin