From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#4033: 23.1; list-colors-display is misleading Date: Tue, 4 Aug 2009 19:25:26 -0700 Message-ID: <6875A66084B7406B8409F2C495A75D26@us.oracle.com> References: <4B9B03BEE43E44B79206302B26E01B3A@us.oracle.com> <87ws5j9rcv.fsf@mail.jurta.org> Reply-To: Drew Adams , 4033@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1249440439 32418 80.91.229.12 (5 Aug 2009 02:47:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 5 Aug 2009 02:47:19 +0000 (UTC) Cc: 4033@emacsbugs.donarmstrong.com To: "'Juri Linkov'" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Aug 05 04:47:12 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MYWX1-0005z6-Na for geb-bug-gnu-emacs@m.gmane.org; Wed, 05 Aug 2009 04:47:12 +0200 Original-Received: from localhost ([127.0.0.1]:49343 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MYWX1-000309-8P for geb-bug-gnu-emacs@m.gmane.org; Tue, 04 Aug 2009 22:47:11 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MYWWn-0002w1-1K for bug-gnu-emacs@gnu.org; Tue, 04 Aug 2009 22:46:57 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MYWWh-0002vX-Ae for bug-gnu-emacs@gnu.org; Tue, 04 Aug 2009 22:46:55 -0400 Original-Received: from [199.232.76.173] (port=47323 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MYWWh-0002vS-4u for bug-gnu-emacs@gnu.org; Tue, 04 Aug 2009 22:46:51 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:50293) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MYWWg-0002og-J3 for bug-gnu-emacs@gnu.org; Tue, 04 Aug 2009 22:46:50 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n752klW7017437; Tue, 4 Aug 2009 19:46:47 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n752U52o016007; Tue, 4 Aug 2009 19:30:05 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: "Drew Adams" Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Wed, 05 Aug 2009 02:30:05 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 4033 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 4033-submit@emacsbugs.donarmstrong.com id=B4033.124943914315897 (code B ref 4033); Wed, 05 Aug 2009 02:30:05 +0000 Original-Received: (at 4033) by emacsbugs.donarmstrong.com; 5 Aug 2009 02:25:43 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from rgminet12.oracle.com (rcsinet12.oracle.com [148.87.113.124]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n752PcmY015887 for <4033@emacsbugs.donarmstrong.com>; Tue, 4 Aug 2009 19:25:39 -0700 Original-Received: from rgminet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by rgminet12.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n752PSS1008394 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 5 Aug 2009 02:25:29 GMT Original-Received: from abhmt008.oracle.com (abhmt008.oracle.com [141.146.116.17]) by rgminet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n752PU6c005878; Wed, 5 Aug 2009 02:25:30 GMT Original-Received: from dradamslap1 (/141.144.224.78) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 04 Aug 2009 19:25:28 -0700 X-Mailer: Microsoft Office Outlook 11 Thread-Index: AcoVTuZdnXz2o85zRHy9QT9NRbdW0AAJBkWw In-Reply-To: <87ws5j9rcv.fsf@mail.jurta.org> X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Source-IP: abhmt008.oracle.com [141.146.116.17] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090207.4A78ED99.002E:SCFSTAT5015188,ss=1,fgs=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Tue, 04 Aug 2009 22:46:55 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:29887 Archived-At: > > I have had at least one user state that he thought that, since the > > form shown is #RRGGBB, his colors had only that granularity. IOW, > > even if one's system allows colors of the form #RRRRGGGGBBBB (more > > colors), the color names are translated to hex strings of the form > > #RRGGBB (fewer colors). > > Could you show a formula that calculates the color granularity? > > We could use it to print colors in the short format #RRGGBB > for the smaller color space and #RRRRGGGGBBBB otherwise. What about something like this: (defun rgb-color-format-for-display () (let ((ncolors (display-color-cells (selected-frame))) (exp 0)) (while (> (lsh ncolors (- exp)) 1) (setq exp (1+ exp))) (setq exp (/ exp 12)) (format "#%%0%dx%%0%dx%%0%dx" exp exp exp))) For 16777216 colors, that gives #%02x%02x%02x, which seems right. In `list-colors-print', we would then do this: (insert (apply 'format (rgb-color-format-for-display) (mapcar (lambda (c) (lsh c -8)) (color-values (car color))))) IOW, replace the hard-coded "#%02x%02x%02x" with (rgb-color-format-for-display). But I guess Jason and Eli are saying that that wouldn't work or wouldn't be appropriate. It's still not clear to me.