bug#19339: 25.0.50; Buffer-local value of face-remapping-alist leaks to other buffers

bug#19339: 25.0.50; Buffer-local value of face-remapping-alist leaks to other buffers

[Óscar Fuentes]

emacs -Q

Eval this in *scratch* :

(dolist (b (buffer-list))
  (when (or (string= (buffer-name b) " *Echo Area 0*")
	    (string= (buffer-name b) " *Echo Area 1*"))
    (with-current-buffer b
      (make-local-variable 'face-remapping-alist)))
      (add-to-list 'face-remapping-alist
		   '(default (:background "green"))))

The minibuffer window now has a green background, as expected. Now do
`C-x b' to switch to another buffer. Now the *scratch* buffer also has
the green background.

If, instead of `C-x b', you press `C-j', part of the buffer remains with
the original background and the rest is painted green. Also, a "nil"
string is inserted in *scratch* everytime you press `C-j'. And the
minibuffer window reverts to its original background.



In GNU Emacs 25.0.50.2 (x86_64-unknown-linux-gnu, X toolkit)
 of 2014-11-18 on qcore
Repository revision: 07556b0299b33b52cf352581bfdd6554819eea30
Windowing system distributor `The X.Org Foundation', version 11.0.11600000
System Description:	Ubuntu 14.10

Configured using:
 `configure --without-toolkit-scroll-bars --with-x-toolkit=lucid'

Configured features:
XAW3D XPM JPEG TIFF GIF PNG SOUND GSETTINGS NOTIFY LIBXML2 FREETYPE XFT
ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

bug#19339: 25.0.50; Buffer-local value of face-remapping-alist leaks to other buffers

[Stefan Monnier]

> (dolist (b (buffer-list))
>   (when (or (string= (buffer-name b) " *Echo Area 0*")
> 	    (string= (buffer-name b) " *Echo Area 1*"))
>     (with-current-buffer b
>       (make-local-variable 'face-remapping-alist)))
                                                   ^^

Too many parentheses,


        Stefan

bug#19339: 25.0.50; Buffer-local value of face-remapping-alist leaks to other buffers

[Óscar Fuentes]

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

> Too many parentheses,

Thanks. Here the revised version:

(dolist (b (buffer-list))
  (when (or (string= (buffer-name b) " *Echo Area 0*")
	    (string= (buffer-name b) " *Echo Area 1*"))
    (with-current-buffer b
      (make-local-variable 'face-remapping-alist)
      (add-to-list 'face-remapping-alist
		   '(default (:background "green"))))))

Still, the background of the minibuffer goes away as soon as you move the
cursor around and the funny "nil" strings are inserted on *scratch* when
you press `C-j'.

bug#19339: 25.0.50; Buffer-local value of face-remapping-alist leaks to other buffers

[Óscar Fuentes]

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

> Too many parentheses,

Thanks. Here the revised version:

(dolist (b (buffer-list))
  (when (or (string= (buffer-name b) " *Echo Area 0*")
	    (string= (buffer-name b) " *Echo Area 1*"))
    (with-current-buffer b
      (make-local-variable 'face-remapping-alist)
      (add-to-list 'face-remapping-alist
		   '(default (:background "green"))))))

Still, the background of the minibuffer goes away as soon as you move the
cursor around and the funny "nil" strings are inserted on *scratch* when
you press `C-j'.

bug#19339: 25.0.50; face-remapping-alist ignored in echo-area

[Stefan Monnier]

retitle 19339 face-remapping-alist ignored in echo-area
thanks

> Still, the background of the minibuffer goes away as soon as you move the
> cursor around

Hmm... it comes back when a message is output, tho.  And I can't quite
characterize when the green background disappears and when it doesn't.

Maybe the C code that "clears" the each area fails to take
face-remapping-alist into account, or something like that.

> and the funny "nil" strings are inserted on *scratch* when
> you press `C-j'.

Oh, that's the documented behavior of C-j in lisp-interaction-mode
(think of it as a kind of ielm-mode, which outputs the return value of
the code you just executed via C-j).


        Stefan

bug#19339: 25.0.50; face-remapping-alist ignored in echo-area

[Óscar Fuentes]

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

>> and the funny "nil" strings are inserted on *scratch* when
>> you press `C-j'.
>
> Oh, that's the documented behavior of C-j in lisp-interaction-mode
> (think of it as a kind of ielm-mode, which outputs the return value of
> the code you just executed via C-j).

Bfff... I'm only using Emacs since 13 years ago, please be patient with
this n00b.

So the only issue is the disappearance of the remapped background. I see
that you changed the bug title. Thanks.

bug#19339: face-remapping-alist ignored in echo-area

[Lars Ingebrigtsen]

Óscar Fuentes <ofv@wanadoo.es> writes:

> (dolist (b (buffer-list))
>   (when (or (string= (buffer-name b) " *Echo Area 0*")
> 	    (string= (buffer-name b) " *Echo Area 1*"))
>     (with-current-buffer b
>       (make-local-variable 'face-remapping-alist)
>       (add-to-list 'face-remapping-alist
> 		   '(default (:background "green"))))))
>
> Still, the background of the minibuffer goes away as soon as you move the
> cursor

When the echo area becomes empty, then the background goes away; yes.
Probably because Emacs doesn't apply any faces there when there's no
characters there?

Or...  something else?  Does anybody know?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#19339: face-remapping-alist ignored in echo-area

[martin rudalics]

 > Or...  something else?  Does anybody know?

Because a minibuffer is shown instead?

martin

bug#19339: face-remapping-alist ignored in echo-area

[Lars Ingebrigtsen]

martin rudalics <rudalics@gmx.at> writes:

>> Or...  something else?  Does anybody know?
>
> Because a minibuffer is shown instead?

Right...  but this doesn't work, either:

(dolist (b (buffer-list))
  (when (string-match " *Echo Area\\|Minibuf" (buffer-name b))
    (with-current-buffer b
      (make-local-variable 'face-remapping-alist)
      (add-to-list 'face-remapping-alist
		   '(default (:background "green"))))))

But I guess you have to do something with the minibuffer hook to get
that to work, or something?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#19339: face-remapping-alist ignored in echo-area

[martin rudalics]

 > Right...  but this doesn't work, either:
 >
 > (dolist (b (buffer-list))
 >    (when (string-match " *Echo Area\\|Minibuf" (buffer-name b))
 >      (with-current-buffer b
 >        (make-local-variable 'face-remapping-alist)
 >        (add-to-list 'face-remapping-alist
 > 		   '(default (:background "green"))))))

IIRC you once found a recipe how to make it work for specific windows
only.

 > But I guess you have to do something with the minibuffer hook to get
 > that to work, or something?

'minibuffer-setup-hook' probably.  Here I'm using a separate window slot
for keeping a window-specific remapping alist.

martin

bug#19339: face-remapping-alist ignored in echo-area

[Lars Ingebrigtsen]

martin rudalics <rudalics@gmx.at> writes:

> IIRC you once found a recipe how to make it work for specific windows
> only.

Probably...

In any case, I don't think there's actually anything to do here in this
bug report, then -- the face remapping works as advertised, so I'm
closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#19339: face-remapping-alist ignored in echo-area

[Michael Heerdegen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> But I guess you have to do something with the minibuffer hook to get
> that to work, or something?

AFAIR each selection of a minibuffer kills all local variables (see
set_minibuffer_mode), so changes to `face-remapping-alist' will not
persist.

Michael.