unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Yuan Fu <casouri@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Theodor Thornhill <theo@thornhill.no>, 59763@debbugs.gnu.org
Subject: bug#59763: 29.0.60; Filling for c-ts-mode
Date: Fri, 2 Dec 2022 16:54:43 -0800	[thread overview]
Message-ID: <684D8326-B59B-4A8D-9CD5-F0EB83CF5608@gmail.com> (raw)
In-Reply-To: <838rjpg8e1.fsf@gnu.org>



> On Dec 2, 2022, at 6:58 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> 
>> From: Yuan Fu <casouri@gmail.com>
>> Date: Thu, 1 Dec 2022 21:33:06 -0800
>> 
>> 
>> IMO For c-ts-mode to be usable we need to have at least a basic filling
>> function. Below is the function I have in my init.el, could someone have
>> a look and see if it’s good? Alternatively we could copy out the comment
>> and fill it in a temp buffer with c-mode, but I didn’t have the time to try
>> it out and see how well it works.
> 
> Thanks.
> 
> From quick testing, I see a problem:
> 
>  . Visit dispnew.c and go to the comment that starts on line 324.  Delete
>    the newline between the two lines of the comment, and invoke the
>    function.  Observe how the first non-blank character of the comment's
>    second line is aligned with the "/*" on the previous line, not with the
>    text after "/*" as I'd expect.

I see. I’ll need to look at how cc-mode fill comments.

> 
> Btw, this command should be bound to M-q in ts-c-mode.

Will do, once our fill function works well. BTW, Theo, if you have any idea, don’t hesitate to go ahead :-) No obligations, of course.

Yuan




  reply	other threads:[~2022-12-03  0:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-02  5:33 bug#59763: 29.0.60; Filling for c-ts-mode Yuan Fu
2022-12-02 14:58 ` Eli Zaretskii
2022-12-03  0:54   ` Yuan Fu [this message]
2022-12-05 11:47     ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-24  8:36 ` Yuan Fu
2022-12-24  8:42   ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-25  1:30 ` Yuan Fu
2022-12-25  7:33   ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-26 21:31 ` Yuan Fu
2022-12-26 22:03   ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-26 22:51     ` Yuan Fu
2022-12-26 23:00       ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-07 23:11 ` Yuan Fu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=684D8326-B59B-4A8D-9CD5-F0EB83CF5608@gmail.com \
    --to=casouri@gmail.com \
    --cc=59763@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=theo@thornhill.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).