From: Gary Oberbrunner <garyo@genarts.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Andrew Hyatt <ahyatt@gmail.com>, 3418 <3418@debbugs.gnu.org>
Subject: bug#3418: Issue with compile.el and compilation-parse-errors-filename-function
Date: Tue, 26 Jan 2016 11:19:41 -0500 (EST) [thread overview]
Message-ID: <681830756.582148.1453825181223.JavaMail.zimbra@genarts.com> (raw)
In-Reply-To: <83fuxk1fxp.fsf@gnu.org>
Hi, Eli.
If a user (such as myself) has an implementation of this function in his .emacs today, like so:
(defun process-error-filename (filename)
;;; do stuff with filename
filename)
(setq compilation-parse-errors-filename-function 'process-error-filename)
and we add a new argument that gets passed to that function, it'll throw an error. *Users* will have to add
&optional spec-dir
to their implementations of it to avoid the error.
(And btw, I've already done that in mine, so I'm future-proof. :-))
-- Gary
----- Original Message -----
> From: "Eli Zaretskii" <eliz@gnu.org>
> To: "Gary Oberbrunner" <garyo@genarts.com>
> Cc: "Andrew Hyatt" <ahyatt@gmail.com>, "3418" <3418@debbugs.gnu.org>
> Sent: Tuesday, January 26, 2016 11:08:50 AM
> Subject: Re: bug#3418: Issue with compile.el and compilation-parse-errors-filename-function
>> Date: Tue, 26 Jan 2016 10:15:27 -0500 (EST)
>> From: Gary Oberbrunner <garyo@genarts.com>
>> Cc: Andrew Hyatt <ahyatt@gmail.com>, 3418@debbugs.gnu.org
>>
>> Wow, a blast from the past!
>
> Better late than never, right?
>
>> I am totally happy with soln 1. For all I know, since I added that hook I might
>> be the only one using it. :-) But I'm also usually a stickler for backward
>> compatibility, so that's why I brought it up.
>
> But if we make the additional argument optional, the backward
> compatibility is preserved, right? Or did I miss something?
--
Gary Oberbrunner
next prev parent reply other threads:[~2016-01-26 16:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-29 14:46 bug#3418: Issue with compile.el and compilation-parse-errors-filename-function Gary Oberbrunner
2016-01-26 5:21 ` Andrew Hyatt
2016-01-26 14:42 ` Eli Zaretskii
2016-01-26 15:15 ` Gary Oberbrunner
2016-01-26 16:08 ` Eli Zaretskii
2016-01-26 16:19 ` Gary Oberbrunner [this message]
2017-08-11 0:50 ` npostavs
2017-08-11 1:04 ` Gary Oberbrunner
2017-08-11 6:34 ` Eli Zaretskii
2017-08-12 15:42 ` npostavs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=681830756.582148.1453825181223.JavaMail.zimbra@genarts.com \
--to=garyo@genarts.com \
--cc=3418@debbugs.gnu.org \
--cc=ahyatt@gmail.com \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).