From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#36832: Supply option to suppress scrolling in compilation mode buffers. Date: Sun, 1 Sep 2019 23:50:20 +0200 Message-ID: <67885E39-7071-4360-90BB-344675251759@acm.org> References: <20190728203221.GD5072@ACM> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="153416"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Alan Mackenzie To: 36832@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 01 23:51:18 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i4Xkj-000dmp-Mc for geb-bug-gnu-emacs@m.gmane.org; Sun, 01 Sep 2019 23:51:18 +0200 Original-Received: from localhost ([::1]:60420 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i4Xki-0001Q5-7Z for geb-bug-gnu-emacs@m.gmane.org; Sun, 01 Sep 2019 17:51:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38196) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i4XkV-0001Pv-Hn for bug-gnu-emacs@gnu.org; Sun, 01 Sep 2019 17:51:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i4XkU-0004pt-Kw for bug-gnu-emacs@gnu.org; Sun, 01 Sep 2019 17:51:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48519) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i4XkU-0004pi-An for bug-gnu-emacs@gnu.org; Sun, 01 Sep 2019 17:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i4XkU-0000a9-6m for bug-gnu-emacs@gnu.org; Sun, 01 Sep 2019 17:51:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <20190728203221.GD5072@ACM> Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Sep 2019 21:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36832 X-GNU-PR-Package: emacs Original-Received: via spool by 36832-submit@debbugs.gnu.org id=B36832.15673746332199 (code B ref 36832); Sun, 01 Sep 2019 21:51:02 +0000 Original-Received: (at 36832) by debbugs.gnu.org; 1 Sep 2019 21:50:33 +0000 Original-Received: from localhost ([127.0.0.1]:57340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i4Xk1-0000ZP-0k for submit@debbugs.gnu.org; Sun, 01 Sep 2019 17:50:33 -0400 Original-Received: from mail1422c50.megamailservers.eu ([91.136.14.22]:33306 helo=mail102c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i4Xjx-0000Z5-Ol for 36832@debbugs.gnu.org; Sun, 01 Sep 2019 17:50:31 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1567374623; bh=dMp0mTdSmW4nxb6QW2/k6cZBZJLJhTTNcovuVRLizKw=; h=From:Subject:Date:Cc:To:From; b=LYZqePp9TXHV0+wcK6S7DDiGyJGPGMOlDPyS4wXr+NokB0dq6YP2CoPGS7LMW+yn2 lFXuKCn5qWougUWgMHbTvl6HyIHLZTzX8pbAznBrtg4eBsn9hQMhtDXvmh57AROEAF /OOKHW9GYrGWOMb1Be8esLs5a5uPmDVjMoGOyies= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.1.64] (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail102c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x81LoKEw002689; Sun, 1 Sep 2019 21:50:22 +0000 X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A0B020C.5D6C3D1F.000B, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=IrUwjo3g c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=H3-YRHbfkcoiOC_lQtoA:9 a=CjuIK1q_8ugA:10 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:166154 Archived-At: After 29d1c72d7c, next-error and previous-error no longer work as before = in compilation-mode. The fringe arrow is often not moved at all until the compilation window = is made active, and the cursor in that buffer isn't moved at all; = scrolling never occurs. This is with a plain NS build on macOS 10.14, = compilation-context-lines being nil (the default). When compilation-context-lines is set to an integer, it seems to work = normally. In compilation-set-window, the expression (set-window-point w mk) was previously executed unconditionally if compilation-context-lines was = not an integer; now, it is only run if there is no left fringe. The = following change restores previous behaviour in that respect: @@ -2600,7 +2600,8 @@ compilation-set-window (goto-char mk) (beginning-of-line 1) (point))) - (set-window-point w mk)))) + (set-window-point w mk)) + (t (set-window-point w mk)))) but you probably want to reformulate the code to avoid duplication.