From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#51426: 29.0.50; [PATCH] Should 'comint-term-environment' be connection-aware? Date: Fri, 29 Oct 2021 09:39:15 -0700 Message-ID: <6753920a-655a-7aa2-b0fa-a1ac01b80eac@gmail.com> References: <69264ece-bb7f-4db1-f461-dacd33db2402@gmail.com> <87cznqev5g.fsf@gmx.de> <2c3dffbc-9af0-f318-15bc-cce91a106898@gmail.com> <8735olwp95.fsf@gmx.de> <94c1e53f-98cb-8891-77d9-81f3c401149e@gmail.com> <878rydxfgl.fsf@gmx.de> <5cbecece-e982-6362-9eac-1610f00f4929@gmail.com> <87k0hwgs1x.fsf@gmx.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------DB8EFF02DE99D8F39946C52E" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9883"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 51426@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 29 18:52:08 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mgV6t-0002Ow-OF for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 29 Oct 2021 18:52:07 +0200 Original-Received: from localhost ([::1]:41606 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mgV6r-0000y9-Pn for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 29 Oct 2021 12:52:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48734) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgUvC-0006my-JV for bug-gnu-emacs@gnu.org; Fri, 29 Oct 2021 12:40:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44187) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mgUvC-00045x-85 for bug-gnu-emacs@gnu.org; Fri, 29 Oct 2021 12:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mgUvC-00013a-45 for bug-gnu-emacs@gnu.org; Fri, 29 Oct 2021 12:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 29 Oct 2021 16:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51426 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51426-submit@debbugs.gnu.org id=B51426.16355255633998 (code B ref 51426); Fri, 29 Oct 2021 16:40:02 +0000 Original-Received: (at 51426) by debbugs.gnu.org; 29 Oct 2021 16:39:23 +0000 Original-Received: from localhost ([127.0.0.1]:55733 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgUuZ-00012P-4w for submit@debbugs.gnu.org; Fri, 29 Oct 2021 12:39:23 -0400 Original-Received: from mail-pj1-f46.google.com ([209.85.216.46]:35396) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgUuW-000129-PB for 51426@debbugs.gnu.org; Fri, 29 Oct 2021 12:39:21 -0400 Original-Received: by mail-pj1-f46.google.com with SMTP id n11-20020a17090a2bcb00b001a1e7a0a6a6so11055709pje.0 for <51426@debbugs.gnu.org>; Fri, 29 Oct 2021 09:39:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language; bh=Y0tzVH5/8S/VBRxGxPPtbS3QkCedaen/pg8dWQ6/H3g=; b=KuKy1vG3ofpqnJt4kJaSyP+l4sDNYZrXSKsWEb1j3LXOkVDOZHbzaBjF+kY3kgdgZ3 dLYqGtWam1TIpnDq2HaHDNxW9EIpdkOO4T8FqVvOQEec4sBXsIhD4gcFgjCiybTQGavj 8UxChRLZsl+XJIh/4NHD0PY9qcKkP/EGTqLGyJcq0svIrymAExvaweQwh5X+16bCeaC7 Vje6jIL7JVTuZLQxRNmHUFeYx0himFHBEenbYR2+LImF7KratA+YuTNc1/69Rs1UHDLL AAybNSJKVp9qoFLti8Glq9A/f3oGdg0ze9XaURR61kW8fsbR8uyPMVvvsy0ayTw/Ww45 ZqDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language; bh=Y0tzVH5/8S/VBRxGxPPtbS3QkCedaen/pg8dWQ6/H3g=; b=ZjBoY8vdDsE2JvAZ9FWzyoDsMWQP8KE128rELe1eZmKo/PxZjfKmB0ArIYptktbqdp B/yADMtERoezukyQxErL0sq6LcsOhkhKyvo+SeqdSR6yNUw3gysNxnwzXz374UEDRhDi p+NskZxrzbuUGLXXMdt37+dUydmKlxjbDIOr1qON0a/IdFxaYlwCREpRsabKTmZIKUqk IndXlHVVoZ5pL0tkTzEacidsEEcrLb/QIHSwoUKlII941YU7ABqiWyK50y7IQIShZcnf 4m2FS5h1QU47lacLOCm1ftn/uC5kYnmw6I94Fk+XdZZLF2MPROuC7bPvAK7qYLy8hM5N a59Q== X-Gm-Message-State: AOAM533MJmUTmAETKFgnQ7vZPxQ1qfoayErOCTghBRS1oF7Lz0lVHF15 Dj3si7TtnuqJUWWmv4fA2UL4eoLkObk= X-Google-Smtp-Source: ABdhPJxt1icV6W8MqWbxGG764ohOTfa3OQxXhsuIocIrE/fK6lVQPYNXUQ0XHARnwVE4NK/tFXQvdA== X-Received: by 2002:a17:902:bd94:b0:13f:f96c:aa22 with SMTP id q20-20020a170902bd9400b0013ff96caa22mr10877198pls.43.1635525554913; Fri, 29 Oct 2021 09:39:14 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id x40sm8361216pfh.188.2021.10.29.09.39.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Oct 2021 09:39:14 -0700 (PDT) In-Reply-To: <87k0hwgs1x.fsf@gmx.de> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218572 Archived-At: This is a multi-part message in MIME format. --------------DB8EFF02DE99D8F39946C52E Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 10/29/2021 1:21 AM, Michael Albinus wrote: > Jim Porter writes: > >> Sure, that seems like a good idea. I expanded the example in the >> section on "Per-Connection Local Variables" to show setting >> `system-uses-terminfo'. Hopefully this will point people in the right >> direction, and make it more apparent that >> `connection-local-set-profiles' lets you set multiple profiles for a >> connection, not just one. (That's documented in the Emacs Lisp manual, >> but I think it would be helpful to show it in the Emacs manual as >> well.) > > Thanks. However, you don't show the second setting, > comint-terminfo-terminal. Is it obvious to the reader that this shall be > changed as well? I didn't change it initially because I wasn't sure it's a value that people are likely to change connection-locally. `system-uses-terminfo' is definitely important to be able to set connection-locally: while many systems support terminfo, some don't (e.g. FreeBSD and MS Windows). `comint-terminfo-terminal' seemed less consequential. However, after doing a bit of archaeology, I think it might make sense to `comint-terminfo-terminal' connection-locally in the example, so I've attached an updated patch. `comint-terminfo-terminal' was only added in Emacs 26.1, and I believe the "dumb-emacs-ansi" terminfo file was added to Debian's ncurses after that, so it makes sense that someone would want to set this differently when connecting to a newer host vs an older host. (I think TERM=dumb-emacs-ansi is the best setting to use if your terminfo database has it, since it reflects comint's capabilities more accurately than TERM=dumb.) I didn't explain the above reasoning in the manual though, since it won't be so relevant as time goes on. Once people see that you can do this, it should hopefully be reasonably obvious why. If we need more explanation beyond this, it probably makes sense to expand the docstring for `comint-terminfo-terminal'. --------------DB8EFF02DE99D8F39946C52E Content-Type: text/plain; charset=UTF-8; name="0001-Expand-the-documentation-for-connection-local-variab.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Expand-the-documentation-for-connection-local-variab.pa"; filename*1="tch" RnJvbSBiZTIzYWViZmQ5YzJlMzQ5ZWY3M2Y0NTE2NTIwZDA3NDVlNDRlMTFlIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFRodSwgMjggT2N0IDIwMjEgMjI6MTQ6MDcgLTA3MDAKU3ViamVjdDogW1BB VENIXSBFeHBhbmQgdGhlIGRvY3VtZW50YXRpb24gZm9yIGNvbm5lY3Rpb24gbG9jYWwgdmFy aWFibGVzCgoqIGRvYy9lbWFjcy9jdXN0b20udGV4aSAoUGVyLUNvbm5lY3Rpb24gTG9jYWwg VmFyaWFibGVzKTogRXhwYW5kIHRoZQpleGFtcGxlIHRvIGluY2x1ZGUgc2V0dGluZyAnc3lz dGVtLXVzZXMtdGVybWluZm8nLgotLS0KIGRvYy9lbWFjcy9jdXN0b20udGV4aSB8IDIxICsr KysrKysrKysrKysrLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKyks IDcgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZG9jL2VtYWNzL2N1c3RvbS50ZXhpIGIv ZG9jL2VtYWNzL2N1c3RvbS50ZXhpCmluZGV4IGViMzBhNmFjYzUuLmJjNzBhZTYxYzkgMTAw NjQ0Ci0tLSBhL2RvYy9lbWFjcy9jdXN0b20udGV4aQorKysgYi9kb2MvZW1hY3MvY3VzdG9t LnRleGkKQEAgLTE0NzQsOSArMTQ3NCwxMCBAQCBDb25uZWN0aW9uIFZhcmlhYmxlcwogCiAg IE1vc3Qgb2YgdGhlIHZhcmlhYmxlcyByZWZsZWN0IHRoZSBzaXR1YXRpb24gb24gdGhlIGxv Y2FsIG1hY2hpbmUuCiBPZnRlbiwgdGhleSBtdXN0IHVzZSBhIGRpZmZlcmVudCB2YWx1ZSB3 aGVuIHlvdSBvcGVyYXRlIGluIGJ1ZmZlcnMKLXdpdGggYSByZW1vdGUgZGVmYXVsdCBkaXJl Y3RvcnkuICBUaGluayBhYm91dCB0aGUgc2hlbGwgdG8gYmUgYXBwbGllZAotd2hlbiBjYWxs aW5nIEBjb2Rle3NoZWxsfSAtLSBpdCBtaWdodCBiZSBAZmlsZXsvYmluL2Jhc2h9IG9uIHlv dXIKLWxvY2FsIG1hY2hpbmUsIGFuZCBAZmlsZXsvYmluL2tzaH0gb24gYSByZW1vdGUgbWFj aGluZS4KK3dpdGggYSByZW1vdGUgZGVmYXVsdCBkaXJlY3RvcnkuICBUaGluayBhYm91dCB0 aGUgYmVoYXZpb3Igd2hlbgorY2FsbGluZyBAY29kZXtzaGVsbH0gLS0gb24geW91ciBsb2Nh bCBtYWNoaW5lLCB5b3UgbWlnaHQgdXNlCitAZmlsZXsvYmluL2Jhc2h9IGFuZCByZWx5IG9u IHRlcm1jYXAsIGJ1dCBvbiBhIHJlbW90ZSBtYWNoaW5lLCBpdCBtYXkKK2JlIEBmaWxley9i aW4va3NofSBhbmQgdGVybWluZm8uCiAKICAgVGhpcyBjYW4gYmUgYWNjb21wbGlzaGVkIHdp dGggQGRmbntjb25uZWN0aW9uLWxvY2FsIHZhcmlhYmxlc30uCiBEaXJlY3RvcnkgYW5kIGZp bGUgbG9jYWwgdmFyaWFibGVzIG92ZXJyaWRlIGNvbm5lY3Rpb24tbG9jYWwKQEAgLTE0OTIs NiArMTQ5MywxMCBAQCBDb25uZWN0aW9uIFZhcmlhYmxlcwogY3JpdGVyaWEsIGlkZW50aWZ5 aW5nIGEgcmVtb3RlIG1hY2hpbmU6CiAKIEBleGFtcGxlCisoY29ubmVjdGlvbi1sb2NhbC1z ZXQtcHJvZmlsZS12YXJpYWJsZXMgJ3JlbW90ZS10ZXJtaW5mbworICAgJygoc3lzdGVtLXVz ZXMtdGVybWluZm8gLiB0KQorICAgICAoY29taW50LXRlcm1pbmZvLXRlcm1pbmFsIC4gImR1 bWItZW1hY3MtYW5zaSIpKSkKKwogKGNvbm5lY3Rpb24tbG9jYWwtc2V0LXByb2ZpbGUtdmFy aWFibGVzICdyZW1vdGUta3NoCiAgICAnKChzaGVsbC1maWxlLW5hbWUgLiAiL2Jpbi9rc2gi KQogICAgICAoc2hlbGwtY29tbWFuZC1zd2l0Y2ggLiAiLWMiKSkpCkBAIC0xNTAxLDEzICsx NTA2LDE1IEBAIENvbm5lY3Rpb24gVmFyaWFibGVzCiAgICAgIChzaGVsbC1jb21tYW5kLXN3 aXRjaCAuICItYyIpKSkKIAogKGNvbm5lY3Rpb24tbG9jYWwtc2V0LXByb2ZpbGVzCi0gICAn KDphcHBsaWNhdGlvbiB0cmFtcCA6bWFjaGluZSAicmVtb3RlbWFjaGluZSIpICdyZW1vdGUt a3NoKQorICAgJyg6YXBwbGljYXRpb24gdHJhbXAgOm1hY2hpbmUgInJlbW90ZW1hY2hpbmUi KQorICAgJ3JlbW90ZS10ZXJtaW5mbyAncmVtb3RlLWtzaCkKIEBlbmQgZXhhbXBsZQogCi0g IFRoaXMgY29kZSBkZWNsYXJlcyB0d28gZGlmZmVyZW50IHByb2ZpbGVzLCBAY29kZXtyZW1v dGUta3NofSBhbmQKLUBjb2Rle3JlbW90ZS1iYXNofS4gVGhlIHByb2ZpbGUgQGNvZGV7cmVt b3RlLWtzaH0gaXMgYXBwbGllZCB0byBhbGwKKyAgVGhpcyBjb2RlIGRlY2xhcmVzIHRocmVl IGRpZmZlcmVudCBwcm9maWxlcywgQGNvZGV7cmVtb3RlLXRlcm1pbmZvfSwKK0Bjb2Rle3Jl bW90ZS1rc2h9LCBhbmQgQGNvZGV7cmVtb3RlLWJhc2h9LiBUaGUgcHJvZmlsZXMKK0Bjb2Rl e3JlbW90ZS10ZXJtaW5mb30gYW5kIEBjb2Rle3JlbW90ZS1rc2h9IGFyZSBhcHBsaWVkIHRv IGFsbAogYnVmZmVycyB3aGljaCBoYXZlIGEgcmVtb3RlIGRlZmF1bHQgZGlyZWN0b3J5IG1h dGNoaW5nIHRoZSByZWdleHAKLUBjb2RleyJyZW1vdGVtYWNoaW5lfSBhcyBob3N0IG5hbWUu ICBTdWNoIGEgY3JpdGVyaWEgY2FuIGFsc28KK0Bjb2RleyJyZW1vdGVtYWNoaW5lIn0gYXMg aG9zdCBuYW1lLiAgU3VjaCBhIGNyaXRlcmlhIGNhbiBhbHNvCiBkaXNjcmltaW5hdGUgZm9y IHRoZSBwcm9wZXJ0aWVzIEBjb2Rlezpwcm90b2NvbH0gKHRoaXMgaXMgdGhlIFRyYW1wCiBt ZXRob2QpIG9yIEBjb2Rlezp1c2VyfSAoYSByZW1vdGUgdXNlciBuYW1lKS4gIFRoZSBAY29k ZXtuaWx9IGNyaXRlcmlhCiBtYXRjaGVzIGFsbCBidWZmZXJzIHdpdGggYSByZW1vdGUgZGVm YXVsdCBkaXJlY3RvcnkuCi0tIAoyLjI1LjEKCg== --------------DB8EFF02DE99D8F39946C52E--