From: Dmitry Gutov <dmitry@gutov.dev>
To: Juri Linkov <juri@linkov.net>
Cc: 65578-done@debbugs.gnu.org, "João Távora" <joaotavora@gmail.com>
Subject: bug#65578: Eglot with mouse
Date: Thu, 31 Aug 2023 03:27:29 +0300 [thread overview]
Message-ID: <6752a462-ac85-65b5-e960-023215a3ca6a@gutov.dev> (raw)
In-Reply-To: <86h6og4k6m.fsf@mail.linkov.net>
Version: 30.1
On 30/08/2023 19:35, Juri Linkov wrote:
>>>> @@ -1637,7 +1637,9 @@ xref-find-definitions-at-mouse
>>>> - (xref-find-definitions identifier)
>>>> + (progn
>>>> + (mouse-set-point event)
>>>> + (xref-find-definitions identifier))
>>>> (user-error "No identifier here"))))
>>> The problem with this solution is that when it doesn't find
>>> the identifier then it leaves point at the wrong place.
>> I'm not sure is a big problem, but we could save the original position and
>> restore it in case of error too:
> Thanks. I tend to agree with João that your initial version would be
> sufficient to leave point at the position of right-clicking.
>
> Then the same change is also needed in xref-find-references-at-mouse
> with mouse-set-point before xref-find-references.
Very good, if you don't mind the side-effect too, I've pushed the fix
for both functions to master. And closing.
BTW, this context-menu-mode is looking pretty nifty. It'd be nice to
turn it on by default someday.
prev parent reply other threads:[~2023-08-31 0:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 7:13 bug#65578: Eglot with mouse Juri Linkov
2023-08-28 9:20 ` João Távora
2023-08-28 13:41 ` Dmitry Gutov
2023-08-28 16:42 ` Juri Linkov
2023-08-28 17:00 ` Dmitry Gutov
2023-08-28 17:11 ` João Távora
2023-08-30 16:35 ` Juri Linkov
2023-08-31 0:27 ` Dmitry Gutov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6752a462-ac85-65b5-e960-023215a3ca6a@gutov.dev \
--to=dmitry@gutov.dev \
--cc=65578-done@debbugs.gnu.org \
--cc=joaotavora@gmail.com \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).