From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#19548: VC changes under-documented, needlessly incompatible Date: Wed, 25 May 2016 04:06:24 +0300 Message-ID: <66c1af4c-dd30-97cc-299e-5257af4f90de@yandex.ru> References: <4cbd510d-80a3-276a-3d80-0a80c8e8143d@yandex.ru> <8360u465fw.fsf@gnu.org> <66a5e406-c325-628c-109f-46973d94512d@yandex.ru> <83lh2z4gi8.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1464138706 13301 80.91.229.3 (25 May 2016 01:11:46 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 25 May 2016 01:11:46 +0000 (UTC) Cc: 19548@debbugs.gnu.org, esr@thyrsus.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 25 03:11:34 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b5NMD-0000u8-0R for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 May 2016 03:11:33 +0200 Original-Received: from localhost ([::1]:56384 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5NMB-0000Eq-Qe for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 May 2016 21:11:31 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46901) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5NJz-0008Ij-8V for bug-gnu-emacs@gnu.org; Tue, 24 May 2016 21:11:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b5NHq-0005H4-W3 for bug-gnu-emacs@gnu.org; Tue, 24 May 2016 21:09:14 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52769) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5NHq-0005H0-Ob for bug-gnu-emacs@gnu.org; Tue, 24 May 2016 21:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1b5NHq-0002Er-HH for bug-gnu-emacs@gnu.org; Tue, 24 May 2016 21:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 May 2016 01:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19548 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19548-submit@debbugs.gnu.org id=B19548.14641383948570 (code B ref 19548); Wed, 25 May 2016 01:07:02 +0000 Original-Received: (at 19548) by debbugs.gnu.org; 25 May 2016 01:06:34 +0000 Original-Received: from localhost ([127.0.0.1]:36873 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b5NHO-0002EA-4x for submit@debbugs.gnu.org; Tue, 24 May 2016 21:06:34 -0400 Original-Received: from mail-wm0-f53.google.com ([74.125.82.53]:35239) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b5NHM-0002Dw-4a for 19548@debbugs.gnu.org; Tue, 24 May 2016 21:06:32 -0400 Original-Received: by mail-wm0-f53.google.com with SMTP id a136so100202953wme.0 for <19548@debbugs.gnu.org>; Tue, 24 May 2016 18:06:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=lx5G2P6hBu7id35mC5G9q1SqEhNAv/hYx77axkIj6GA=; b=GTSJ4W5PwvoICfK4ejT1Xfk5MY9Ba9KEfXvmiAOXJ4ahu1KlG4jQ9o1njuyL0zoiat +YpU9khCffshrqPgcj/nZ+7z10jwrq1VktUe3etg447x5X3hGsYT024VBNSLc7rLGcl8 xSrMr7zlxi/fP7IUCFXfO/iHBSBcco+7KjoSYrBT4QsOcoiBslEb4MlZ4zC39YP8LSp5 jaJ/vK94i46Skxpw+Q6EPzqTbULFZHJooVVloexozmklQy6vdtRKEcRr3kPDnJG7Lo89 n543SWeOxTmvfJqwgmKTrUhY4kCiJT6lMOhmE09NbuSaDquSAcMGfp955W0sIwcO243T 9rqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=lx5G2P6hBu7id35mC5G9q1SqEhNAv/hYx77axkIj6GA=; b=iiYn3fJqULg57xjU+tcYyJeN9n7JFZI4R2EaMtUm6evOsJU7vnNsuATeJCGDALz+Qo QnEa8BlVmH5Rk4QTl+JPfgBNNiIs6QVy4Zh0pFiXet0A9MflSj7Oup+94IQxLVtserD8 PZWXf/H57z0jsxekuGsB0jJqj9h9U19Bc0UXm95OfHFeL8piSB4IJBZFOw20Qj8C1c/d Lb+EehdUX2kwXFXqEMNJNkf0XOGpTuSdqH7+E0zkAPEIYXNDjKBmcDpNrxfrglV/ZGBo 1DFo6JZc0EH6Pb+ep3ezzWxt3LS6reasN8imFteVfLKwzQ0AVqS3ql6QFe3qPOcWh8PX ZV9w== X-Gm-Message-State: ALyK8tIV4h73XYbnEEUnQyZtK0cz4fJAkOu4KRmD4xqiE5NGtgiJP/JpamqTUcK0r125MQ== X-Received: by 10.28.6.205 with SMTP id 196mr431501wmg.96.1464138386263; Tue, 24 May 2016 18:06:26 -0700 (PDT) Original-Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id 63sm21972903wmz.5.2016.05.24.18.06.24 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 24 May 2016 18:06:25 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1 In-Reply-To: <83lh2z4gi8.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:118646 Archived-At: On 05/24/2016 06:34 PM, Eli Zaretskii wrote: > Yes, it looks good to me. Pushed, thanks. If someone would like to point out what else we're missing in this bug, that would be great. I've glanced through the "Changes from the pre-25.1 API" list, and one change we could make to improve backward compatibility there, is to catch wrong-number-of-arguments when calling the `diff' method, and retry with one fewer argument. Doesn't really seem worth the trouble, however. The list of changes is longer than that, and third-party backends will have to adapt anyway. Similarly, the change to dir-status-files could be smoothed over by continuing to pass some dummy fourth argument, but it's unclear when we'd be allowed to stop doing that. So maybe not doing that at all is just as valid an option. IIRC, nobody has really complained about their backend having stopped working. > You can try this one: > > http://www.delorie.com/djgpp/cvs.html Thanks. revert-buffer works *very* slowly with it using the default settings, but at least the results look correct.