bug#67674: 30.0.50; shr-heading's update broke racket-mode's documention read

bug#67674: 30.0.50; shr-heading's update broke racket-mode's documention read

[Mou Tong]

[-- Attachment #1: Type: text/plain, Size: 1149 bytes --]

Hi there, I noticed that after this commit

https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=d41a5e4b1bafbb974d2c886d3198d9bda7821591

There are some changes in the function `shr-heading`.

```diff
 (defun shr-heading (dom &rest types)
   (shr-ensure-paragraph)
-  (apply #'shr-fontize-dom dom types)
+  (let ((start (point))
+     (level (string-to-number
+         (string-remove-prefix "shr-h" (symbol-name (car types))))))
+   (apply #'shr-fontize-dom dom types)
+   (put-text-property start (pos-eol) 'outline-level level))
   (shr-ensure-paragraph))
```

In racket-mode, when looking for local docs, racket-mode will use the
following function to `shr-heading`:

    (shr-heading dom face)

Here `dom` is unrelated to this, problem occurs in `face`:

`racket-mode` passed `face` (as an example, which value is
`(variable-pitch (:height 1.6))`) to `shr-heading`, when `shr-heading`
parses it:

    (symbol-name (car '((variable-patch (:height 1.6)))))

error occurs:

    (wrong-type-argument symbolp (variable-patch (:height 1.6)))

Does this counts as an Emacs's bug, or racket-mode's problem? thx


[-- Attachment #2: Type: text/html, Size: 4341 bytes --]

bug#67674: 30.0.50; shr-heading's update broke racket-mode's documention

[Mou Tong]

[-- Attachment #1: Type: text/plain, Size: 133 bytes --]

Ah, never mind, please close this.

I have reported this to racket-mode, and it got fixed in racket-mode.

Sorry for the noise.

[-- Attachment #2: Type: text/html, Size: 698 bytes --]

bug#67674: 30.0.50; shr-heading's update broke racket-mode's documention

[Eli Zaretskii]

> Cc: "67674@debbugs.gnu.org" <67674@debbugs.gnu.org>
> From: Mou Tong <mou.tong@outlook.com>
> Date: Fri, 8 Dec 2023 01:09:49 +0000
> 
> Ah, never mind, please close this. 
> 
> I have reported this to racket-mode, and it got fixed in racket-mode.

Closed, thanks.