* bug#8853: 24.0.50; regression: doc string of `special-display-popup-frame'
@ 2011-06-13 17:11 Drew Adams
2011-06-14 9:15 ` martin rudalics
0 siblings, 1 reply; 7+ messages in thread
From: Drew Adams @ 2011-06-13 17:11 UTC (permalink / raw)
To: 8853
This regression was introduced in release 23.1. Prior to that release,
the doc string said, correctly,
"If ARGS is a list whose car is a symbol, use (car ARGS) as a function
to do the work. Pass it BUFFER as first arg, and (cdr ARGS) as the
rest of its args."
Now it says, incorrectly,
"If ARGS is a list whose car is a symbol, use (car ARGS) as a
function to do the work. Pass it BUFFER as first argument,
and (cdr ARGS) as second."
If ARGS is a list whose car is a symbol `f', then
`special-display-popup-frame' invokes `f', passing it as arguments,
BUFFER followed by all of the elements in (cdr ARGS). The arity of `f'
is the length of ARGS, not just 2. We do not pass `f' (cdr ARGS) as a
second argument.
In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
of 2011-06-13 on 3249CTO
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.5) --no-opt --cflags
-Ic:/build/include'
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#8853: 24.0.50; regression: doc string of `special-display-popup-frame'
2011-06-13 17:11 bug#8853: 24.0.50; regression: doc string of `special-display-popup-frame' Drew Adams
@ 2011-06-14 9:15 ` martin rudalics
2011-06-19 19:05 ` Chong Yidong
0 siblings, 1 reply; 7+ messages in thread
From: martin rudalics @ 2011-06-14 9:15 UTC (permalink / raw)
To: Drew Adams; +Cc: 8853
> This regression was introduced in release 23.1. Prior to that release,
> the doc string said, correctly,
> "If ARGS is a list whose car is a symbol, use (car ARGS) as a function
> to do the work. Pass it BUFFER as first arg, and (cdr ARGS) as the
> rest of its args."
>
> Now it says, incorrectly,
> "If ARGS is a list whose car is a symbol, use (car ARGS) as a
> function to do the work. Pass it BUFFER as first argument,
> and (cdr ARGS) as second."
>
> If ARGS is a list whose car is a symbol `f', then
> `special-display-popup-frame' invokes `f', passing it as arguments,
> BUFFER followed by all of the elements in (cdr ARGS). The arity of `f'
> is the length of ARGS, not just 2. We do not pass `f' (cdr ARGS) as a
> second argument.
Indeed. Could someone please restore the old doc-string in Emacs 23?
martin
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#8853: 24.0.50; regression: doc string of `special-display-popup-frame'
2011-06-14 9:15 ` martin rudalics
@ 2011-06-19 19:05 ` Chong Yidong
2011-06-29 16:58 ` Drew Adams
0 siblings, 1 reply; 7+ messages in thread
From: Chong Yidong @ 2011-06-19 19:05 UTC (permalink / raw)
To: martin rudalics; +Cc: 8853
martin rudalics <rudalics@gmx.at> writes:
>> This regression was introduced in release 23.1. Prior to that release,
>> the doc string said, correctly,
>> "If ARGS is a list whose car is a symbol, use (car ARGS) as a function
>> to do the work. Pass it BUFFER as first arg, and (cdr ARGS) as the
>> rest of its args."
>> Now it says, incorrectly,
>> "If ARGS is a list whose car is a symbol, use (car ARGS) as a
>> function to do the work. Pass it BUFFER as first argument,
>> and (cdr ARGS) as second."
>> If ARGS is a list whose car is a symbol `f', then
>> `special-display-popup-frame' invokes `f', passing it as arguments,
>> BUFFER followed by all of the elements in (cdr ARGS). The arity of `f'
>> is the length of ARGS, not just 2. We do not pass `f' (cdr ARGS) as a
>> second argument.
>
> Indeed. Could someone please restore the old doc-string in Emacs 23?
Fixed.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#8853: 24.0.50; regression: doc string of `special-display-popup-frame'
2011-06-19 19:05 ` Chong Yidong
@ 2011-06-29 16:58 ` Drew Adams
2011-06-29 23:16 ` Glenn Morris
2012-09-16 4:45 ` Chong Yidong
0 siblings, 2 replies; 7+ messages in thread
From: Drew Adams @ 2011-06-29 16:58 UTC (permalink / raw)
To: 'Chong Yidong', 'martin rudalics'; +Cc: 8853
> >> This regression was introduced in release 23.1. Prior to
> >> that release, the doc string said, correctly,
> >> "If ARGS is a list whose car is a symbol, use (car ARGS)
> >> as a function to do the work. Pass it BUFFER as first arg,
> >> and (cdr ARGS) as the rest of its args."
What's important here is "as the _rest_ of its args".
> >> Now it says, incorrectly, "If ARGS is a list whose car
> >> is a symbol, use (car ARGS) as a function to do the work.
> >> Pass it BUFFER as first argument, and (cdr ARGS) as second."
> >>
> >> If ARGS is a list whose car is a symbol `f', then
> >> `special-display-popup-frame' invokes `f', passing it as
> >> arguments, BUFFER followed by all of the elements in
> >> (cdr ARGS). The arity of `f' is the length of ARGS, not
> >> just 2. We do not pass `f' (cdr ARGS) as a second argument.
> >
> > Indeed. Could someone please restore the old doc-string in
> > Emacs 23?
>
> Fixed.
No, I do not see this fixed in the latest Windows build of Emacs 24:
In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
of 2011-06-27 on 3249CTO
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.5) --no-opt --cflags
-Ic:/build/include'
It still says: "Pass it BUFFER as first argument, and (cdr ARGS) as second."
The point of the bug fix should be to replace "as second" by "as the rest of its
args" or equivalent. Thx.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#8853: 24.0.50; regression: doc string of `special-display-popup-frame'
2011-06-29 16:58 ` Drew Adams
@ 2011-06-29 23:16 ` Glenn Morris
2012-08-10 16:47 ` Drew Adams
2012-09-16 4:45 ` Chong Yidong
1 sibling, 1 reply; 7+ messages in thread
From: Glenn Morris @ 2011-06-29 23:16 UTC (permalink / raw)
To: 8853-done
> > > Indeed. Could someone please restore the old doc-string in Emacs 23?
> >
> > Fixed.
>
> No, I do not see this fixed in the latest Windows build of Emacs 24:
As indicated, it was fixed in the emacs-23 branch. This and other
changes will be merged to trunk in due course. Please be less eager to
reopen bugs.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#8853: 24.0.50; regression: doc string of `special-display-popup-frame'
2011-06-29 16:58 ` Drew Adams
2011-06-29 23:16 ` Glenn Morris
@ 2012-09-16 4:45 ` Chong Yidong
1 sibling, 0 replies; 7+ messages in thread
From: Chong Yidong @ 2012-09-16 4:45 UTC (permalink / raw)
To: Drew Adams; +Cc: 8853
"Drew Adams" <drew.adams@oracle.com> writes:
>> > Indeed. Could someone please restore the old doc-string in
>> > Emacs 23?
>>
>> Fixed.
>
> No, I do not see this fixed in the latest Windows build of Emacs 24:
The doc-string in Emacs 23 was wrong too, so restoring it did not fix
things. Should be fixed now, sorry for the confusion.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-09-16 4:45 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-13 17:11 bug#8853: 24.0.50; regression: doc string of `special-display-popup-frame' Drew Adams
2011-06-14 9:15 ` martin rudalics
2011-06-19 19:05 ` Chong Yidong
2011-06-29 16:58 ` Drew Adams
2011-06-29 23:16 ` Glenn Morris
2012-08-10 16:47 ` Drew Adams
2012-09-16 4:45 ` Chong Yidong
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).