From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Hong Xu Newsgroups: gmane.emacs.bugs Subject: bug#37538: [PATCH] Add docstring for `tags-complete-tags-table-file'. Date: Tue, 8 Oct 2019 23:39:08 -0700 Message-ID: <663aaf32-97c4-0723-1a30-a644938bd21f@topbug.net> References: <36bef08c-45b5-9cce-5374-d4de4260d39a@topbug.net> <838sq8j0vl.fsf@gnu.org> <7e0290a2-e80b-f566-9c3b-894aaf4e5d9d@topbug.net> <87o8yt9oql.fsf@gnus.org> <83y2xwzfz0.fsf@gnu.org> <860671c8-787c-512c-8df6-ea1d9dfc2f5b@topbug.net> <874l0j1a3j.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="30791"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: 37538@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 09 19:20:20 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iIFdL-0007pv-8C for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Oct 2019 19:20:19 +0200 Original-Received: from localhost ([::1]:52964 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIFdI-0000uA-Se for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Oct 2019 13:20:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34914) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iI5dj-0004Zc-Ax for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 02:40:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iI5di-0001PS-8x for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 02:40:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43145) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iI5di-0001PM-4F for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 02:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iI5dh-0004Ex-Vw for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 02:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Hong Xu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Oct 2019 06:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37538 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 37538-submit@debbugs.gnu.org id=B37538.157060316616252 (code B ref 37538); Wed, 09 Oct 2019 06:40:01 +0000 Original-Received: (at 37538) by debbugs.gnu.org; 9 Oct 2019 06:39:26 +0000 Original-Received: from localhost ([127.0.0.1]:51966 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iI5d8-0004E4-1S for submit@debbugs.gnu.org; Wed, 09 Oct 2019 02:39:26 -0400 Original-Received: from sender4-of-o54.zoho.com ([136.143.188.54]:21474) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iI5d5-0004Du-7S for 37538@debbugs.gnu.org; Wed, 09 Oct 2019 02:39:24 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1570603151; cv=none; d=zoho.com; s=zohoarc; b=AqbY4wSl2thJrrcRTWUJ4evBODQ3bowciFr4fsUDjZEVuA8FvWHnvMtHAAy3oLEe0eXf5mywTgePvkQrH0yYloQrihS4nGiTbTVAHCFaFuNC9sSINtCz/H7PjyS1Y3AP4bUDMbRIem2ExnTjqzcmJDgVXWyhm8C3IR1CA8YxV0s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1570603151; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=kwQCRBGl53ap5HZM6zrE5MmKlIaDt0NJ/OsOiw9UraQ=; b=DDgqH5BqKDieURfXT94GHCLkRgbWdCqEnFB5MVpKP5NWEcQ7rwXSu+yWk0pNGWi98TERfq/8dFjZDpaGAlsSaIIJ646NV2rS3kF/0MVyzg0UYmijdK6e1WwNIwzb+zBEjfHOanhw6POF5gCawoRuJI4/LIxQgjZ13UZhrsxmgwk= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass header.i=topbug.net; spf=pass smtp.mailfrom=hong@topbug.net; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1570603151; s=zoho; d=topbug.net; i=hong@topbug.net; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding; l=1433; bh=kwQCRBGl53ap5HZM6zrE5MmKlIaDt0NJ/OsOiw9UraQ=; b=acHHUS9KfhOsEwLMtnS2+KN15xhGRBdrstKcKEjS9ygXkO+SDzLlkzKaUQbucKYM UGvhgIAfuqvB/fAyCR4D5YtT0eNSw88FQOX3g28K62n38iXr0CL44BVE2BMW12QyNIL vQjA+IieWTT0Qvu+LEkGGV91b5t3e0z5yOmMY7GQ= Original-Received: from [192.168.88.88] (69-215-149-151.lightspeed.sntcca.sbcglobal.net [69.215.149.151]) by mx.zohomail.com with SMTPS id 15706031495080.9027006159880102; Tue, 8 Oct 2019 23:39:09 -0700 (PDT) Openpgp: preference=signencrypt In-Reply-To: <874l0j1a3j.fsf@gnus.org> Content-Language: en-US X-ZohoMailClient: External X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:168726 Archived-At: On 10/8/19 9:21 AM, Lars Ingebrigtsen wrote: > > The problem is that `(elisp) Programmed Completion' (at least in Emacs > 27) doesn't mention a WHAT parameter at all, so it's unclear what this > refers to. > How about the following change? diff --git a/doc/lispref/minibuf.texi b/doc/lispref/minibuf.texi index a9d6e83cf854..73af67ab083f 100644 --- a/doc/lispref/minibuf.texi +++ b/doc/lispref/minibuf.texi @@ -1769,7 +1769,8 @@ Programmed Completion completion functions, which will then let your function do all the work. - The completion function should accept three arguments: + The completion function should accept three arguments in the +following order: @itemize @bullet @item diff --git a/lisp/progmodes/etags.el b/lisp/progmodes/etags.el index 6784894ba87e..d58e2cb2a187 100644 --- a/lisp/progmodes/etags.el +++ b/lisp/progmodes/etags.el @@ -1853,8 +1853,8 @@ tags-complete-tags-table-file "Complete STRING from file names in the current tags table. The meaning of the arguments are the same as the function form of COLLECTION as explained in Info node `(elisp) Programmed -Completion', except that if WHAT does not equal t, it is treated -as if it were nil." +Completion', except that if the third argument does not equal t, +it is treated as if it were nil." (save-excursion ;; If we need to ask for the tag table, allow that. (let ((enable-recursive-minibuffers t))