unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Yuan Fu <casouri@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 75362@debbugs.gnu.org, Randy Taylor <dev@rjt.dev>, jroi.martin@gmail.com
Subject: bug#75362: 29.4; go-ts-mode.el: wrong indentation inside var list
Date: Thu, 9 Jan 2025 19:11:14 -0800	[thread overview]
Message-ID: <661D61B6-CE81-4DA2-9BF3-6D638448798E@gmail.com> (raw)
In-Reply-To: <86cygw31ji.fsf@gnu.org>



> On Jan 8, 2025, at 11:10 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> 
>> Date: Wed, 08 Jan 2025 13:20:19 +0000
>> From: Randy Taylor <dev@rjt.dev>
>> Cc: Yuan Fu <casouri@gmail.com>, 75362@debbugs.gnu.org, jroi.martin@gmail.com
>> 
>> On Wednesday, January 8th, 2025 at 08:02, Eli Zaretskii <eliz@gnu.org> wrote:
>>> 
>>> 
>>>> Cc: 75362@debbugs.gnu.org, Roi Martin jroi.martin@gmail.com
>>> 
>>>> From: Yuan Fu casouri@gmail.com
>>>> Date: Tue, 7 Jan 2025 22:18:53 -0800
>>>> 
>>>>> The attached patch fixes it for me.<0001-Fix-go-ts-mode-var-spec-indentation-Bug-75362.patch>
>>>> 
>>>> Thanks Randy. Eli, should we apply this to emacs-30.
>>> 
>>> 
>>> Is this backward-compatible to older grammars? If yes, it's okay to
>>> install on emacs-30. If it is not compatible, I'd like to see how a
>>> compatible patch will look before I decide.
>> 
>> Yes, it's backward-compatible.
> 
> OK, then, Yuan, please feel free to install on emacs-30.

Installed.

As for cmake-ts-mode’s fix, it’s in 4def541bbfe67b1a492e8a3b6041a1d8f76d680b

Basically, tree-sitter-cmake gives up on parsing cmake generator expressions. According to the commit message:

> feat!: remove parsing generator expressions
> 
> Parsing generator expressions statically is impossible since whether an argument is interpreted as a generator expression or not depends on the function itself. Hence, the parsing for it is removed.
> 

Which makes sense to me. The fix is backward-compatible too, since we’re just removing fontification for angle brackets.

Yuan






      reply	other threads:[~2025-01-10  3:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-04 15:40 bug#75362: 29.4; go-ts-mode.el: wrong indentation inside var list Roi Martin
2025-01-05 22:05 ` Randy Taylor
2025-01-08  6:18   ` Yuan Fu
2025-01-08 13:02     ` Eli Zaretskii
2025-01-08 13:20       ` Randy Taylor
2025-01-09  7:10         ` Eli Zaretskii
2025-01-10  3:11           ` Yuan Fu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=661D61B6-CE81-4DA2-9BF3-6D638448798E@gmail.com \
    --to=casouri@gmail.com \
    --cc=75362@debbugs.gnu.org \
    --cc=dev@rjt.dev \
    --cc=eliz@gnu.org \
    --cc=jroi.martin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).