From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#34910: 27.0.50; Too much matching reentrancy Date: Tue, 19 Mar 2019 13:50:00 +0100 Message-ID: <66172e4bc6e70e23d7bf3175a5c83519a43c1a66.camel@acm.org> References: <834l7zuw4x.fsf@gnu.org> <443195D9-DFEB-4E67-AEFE-556C3D900113@acm.org> <8336njuqrd.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-rk0GvHPs1STaFh/OLIEn" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="106986"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) Cc: 34910@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Mar 19 14:18:30 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h6EdR-000Rlp-T0 for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Mar 2019 14:18:30 +0100 Original-Received: from localhost ([127.0.0.1]:57293 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h6EdQ-0006f1-Lw for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Mar 2019 09:18:28 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45389) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h6EU6-0007i5-SM for bug-gnu-emacs@gnu.org; Tue, 19 Mar 2019 09:08:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h6ECs-0000T0-GP for bug-gnu-emacs@gnu.org; Tue, 19 Mar 2019 08:51:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36142) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h6ECs-0000Sr-Ay for bug-gnu-emacs@gnu.org; Tue, 19 Mar 2019 08:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h6ECs-0001ib-8A for bug-gnu-emacs@gnu.org; Tue, 19 Mar 2019 08:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Mar 2019 12:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34910 X-GNU-PR-Package: emacs Original-Received: via spool by 34910-submit@debbugs.gnu.org id=B34910.15529998126540 (code B ref 34910); Tue, 19 Mar 2019 12:51:02 +0000 Original-Received: (at 34910) by debbugs.gnu.org; 19 Mar 2019 12:50:12 +0000 Original-Received: from localhost ([127.0.0.1]:49686 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h6EC3-0001hP-Ua for submit@debbugs.gnu.org; Tue, 19 Mar 2019 08:50:12 -0400 Original-Received: from mail229c50.megamailservers.eu ([91.136.10.239]:46516 helo=mail36c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h6EC0-0001hD-9K for 34910@debbugs.gnu.org; Tue, 19 Mar 2019 08:50:09 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1552999803; bh=sHrUxC5zcA+fL7pS9FvhFyLAyE3gOBJgv+f9+jCWbfU=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=T0OQCQukCxea5mKDYivvaqD/zYiZFiYeJlwxkajAauceGkq2kc0ykEM1mEMi+NebJ yaNxrQxxnFhnolxZSczOZMkJyvqqb2/zGIjEz5p8azlB+rf6RNVzSOyicmhdavpX9o 8YL4NzLWhH0HX5+q4ILhCN7j2VnTMCoueGf2E8R0= Feedback-ID: mattiase@acm.or Original-Received: from dhcppc1 (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail36c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x2JCo16S005249; Tue, 19 Mar 2019 12:50:02 +0000 In-Reply-To: <8336njuqrd.fsf@gnu.org> X-CTCH-RefID: str=0001.0A0B020A.5C90E57B.002C, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=XOQetzpE c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=UMsHLDlp7gEZZhEn_PgA:9 a=QEXdDO2ut3YA:10 a=N54-gffFAAAA:8 a=nXKKOT7fDA2BalIiqV4A:9 a=B2y7HmGcmWMA:10 a=6l0D2HzqY3Epnrm8mE3f:22 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156499 Archived-At: --=-rk0GvHPs1STaFh/OLIEn Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Here is another improvement: there should be no reason to keep the regexp busy during the overflow error processing, so release it first. By the way, is there any reason why only calls to re_search_2 are made with a busy-marked regexp buffer, not calls to re_search? Are the latter guaranteed not to be reentrant? --=-rk0GvHPs1STaFh/OLIEn Content-Disposition: attachment; filename="0001-Release-regexp-before-signalling-overflow-error.patch" Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="0001-Release-regexp-before-signalling-overflow-error.patch"; charset="UTF-8" RnJvbSAzYzc1NTViZjBmYzM4ZGI5NGQ4NzkyMzg2OWNiNDhkNTdiMTI2MDVhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/TWF0dGlhcz0yMEVuZ2RlZz1DMz1BNXJkPz0g PG1hdHRpYXNlQGFjbS5vcmc+CkRhdGU6IFR1ZSwgMTkgTWFyIDIwMTkgMTM6NDc6MTMgKzAxMDAK U3ViamVjdDogW1BBVENIXSBSZWxlYXNlIHJlZ2V4cCBiZWZvcmUgc2lnbmFsbGluZyBvdmVyZmxv dyBlcnJvcgoKc3JjL3NlYXJjaC5jIChsb29raW5nX2F0XzEsIHNlYXJjaF9idWZmZXJfcmUpOiBV bmZyZWV6ZSB0aGUgcmVnZXhwIGJ1ZmZlcgpiZWZvcmUgc2lnbmFsbGluZyBhIG1hdGNoZXIgb3Zl cmZsb3csIHNpbmNlIHRoZSBlcnJvciBwcm9jZXNzaW5nIG1heQpyZXF1aXJlIHF1aXRlIHNvbWUg cmVnZXhwIHVzZSBhcyB3ZWxsIChCdWcjMzQ5MTApLgotLS0KIHNyYy9zZWFyY2guYyB8IDcgKysr KysrLQogMSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlm ZiAtLWdpdCBhL3NyYy9zZWFyY2guYyBiL3NyYy9zZWFyY2guYwppbmRleCAyYzAwZTZlOTNmLi5i NjFmNjVhNzdjIDEwMDY0NAotLS0gYS9zcmMvc2VhcmNoLmMKKysrIGIvc3JjL3NlYXJjaC5jCkBA IC0zNDQsNyArMzQ0LDEwIEBAIGxvb2tpbmdfYXRfMSAoTGlzcF9PYmplY3Qgc3RyaW5nLCBib29s IHBvc2l4KQogCQkgIFpWX0JZVEUgLSBCRUdWX0JZVEUpOwogCiAgIGlmIChpID09IC0yKQotICAg IG1hdGNoZXJfb3ZlcmZsb3cgKCk7CisgICAgeworICAgICAgdW5iaW5kX3RvIChjb3VudCwgUW5p bCk7CisgICAgICBtYXRjaGVyX292ZXJmbG93ICgpOworICAgIH0KIAogICB2YWwgPSAoaSA+PSAw ID8gUXQgOiBRbmlsKTsKICAgaWYgKHByZXNlcnZlX21hdGNoX2RhdGEgJiYgaSA+PSAwKQpAQCAt MTIyMyw2ICsxMjI2LDcgQEAgc2VhcmNoX2J1ZmZlcl9yZSAoTGlzcF9PYmplY3Qgc3RyaW5nLCBw dHJkaWZmX3QgcG9zLCBwdHJkaWZmX3QgcG9zX2J5dGUsCiAgICAgICAgICAgICAgICAgICAgICAg ICAgcG9zX2J5dGUgLSBCRUdWX0JZVEUpOwogICAgICAgaWYgKHZhbCA9PSAtMikKICAgICAgICAg eworICAgICAgICAgIHVuYmluZF90byAoY291bnQsIFFuaWwpOwogICAgICAgICAgIG1hdGNoZXJf b3ZlcmZsb3cgKCk7CiAgICAgICAgIH0KICAgICAgIGlmICh2YWwgPj0gMCkKQEAgLTEyNjgsNiAr MTI3Miw3IEBAIHNlYXJjaF9idWZmZXJfcmUgKExpc3BfT2JqZWN0IHN0cmluZywgcHRyZGlmZl90 IHBvcywgcHRyZGlmZl90IHBvc19ieXRlLAogICAgICAgICAgICAgICAgICAgICAgICAgIGxpbV9i eXRlIC0gQkVHVl9CWVRFKTsKICAgICAgIGlmICh2YWwgPT0gLTIpCiAgICAgICAgIHsKKyAgICAg ICAgICB1bmJpbmRfdG8gKGNvdW50LCBRbmlsKTsKICAgICAgICAgICBtYXRjaGVyX292ZXJmbG93 ICgpOwogICAgICAgICB9CiAgICAgICBpZiAodmFsID49IDApCi0tIAoyLjIwLjEKCg== --=-rk0GvHPs1STaFh/OLIEn--