From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#72117: Command doesn't execute correctly in eshell Date: Thu, 18 Jul 2024 08:38:53 -0700 Message-ID: <659aac92-ea93-3726-288d-70e90a2135e5@gmail.com> References: <835b5821-f522-df6e-286d-5c34962684f7@gmail.com> <87frs759nm.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18176"; mail-complaints-to="usenet@ciao.gmane.io" Cc: the_wurfkreuz , 72117@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 18 17:41:31 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sUTG7-0004cA-Bz for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Jul 2024 17:41:31 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sUTFe-0008Qz-MK; Thu, 18 Jul 2024 11:41:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sUTFc-0008PF-6I for bug-gnu-emacs@gnu.org; Thu, 18 Jul 2024 11:41:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sUTFb-00057u-1a for bug-gnu-emacs@gnu.org; Thu, 18 Jul 2024 11:40:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sUTFe-00068s-J3 for bug-gnu-emacs@gnu.org; Thu, 18 Jul 2024 11:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Jul 2024 15:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72117 X-GNU-PR-Package: emacs Original-Received: via spool by 72117-submit@debbugs.gnu.org id=B72117.172131720623518 (code B ref 72117); Thu, 18 Jul 2024 15:41:02 +0000 Original-Received: (at 72117) by debbugs.gnu.org; 18 Jul 2024 15:40:06 +0000 Original-Received: from localhost ([127.0.0.1]:37924 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sUTEj-00067G-Qs for submit@debbugs.gnu.org; Thu, 18 Jul 2024 11:40:06 -0400 Original-Received: from mail-pl1-f172.google.com ([209.85.214.172]:44097) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sUTEh-00066e-4P for 72117@debbugs.gnu.org; Thu, 18 Jul 2024 11:40:04 -0400 Original-Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1fc47abc040so7779445ad.0 for <72117@debbugs.gnu.org>; Thu, 18 Jul 2024 08:39:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721317133; x=1721921933; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=7YTk8ftWdDxeKsHaAlUn+XnkLFPVL6CqnQeEB2L7tn0=; b=QC1qP6sNw5J6EpKi1pi0u3gM6NIvTO/mlWa6qJ9zDfVRXZtEJvU1Jirqk8Itw3Fz2a e9rhSXnDxx34jh2p7spl0HIfW7Zhjv5ePmE/DKhEMUOUhuTE4RxGmJAlL1W/RIx2rfAp MiT3bUWkZKudCtNeAgm5kClpPK7Oyg9sNniEharUpXsSiLuvbaZpH0Nx/V9lcW6y7dk3 IEsUSrXkmjVRYJLE7ISHhOCM8O66ujaxOYE7vsMp+FgIuMn0jHGj1a33ZMsU/xZeiGqU QuOn9eWNxcuLjqEWe2W52zhhrS4ui4OgXfC9EiP3sbtScJYlcoPbKcl/berQ2gxGT+s6 XCjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721317133; x=1721921933; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7YTk8ftWdDxeKsHaAlUn+XnkLFPVL6CqnQeEB2L7tn0=; b=mCO3V92FOius8i6soVkRNBsa6DFLw5ZPCio9/wjo/4p3zuA2qNfJFUNJuK+r9hWWzL +ilBZvZnyM6yqD8eMXzXM5D483NO9JGSyvcX7W/6tUOtYoxX1Wu+CoqtvSa2LTpzh3Vn 6e6P07OaQIqIlUbyEKrKQxHlhJxKNj067zhSRxqCxOAjT8o2UjKm0Z3P44o5ZaMIEd2J Gl20Qy7vTQAD1Z+tYX+kH7iA7nwAVF3j4bN2DS1KgDOyCB+NBCdByumNolPbu9hB96wb 9mb6dipr/4gy4Gi/55U84jwKw6pZ//zheBaYpyfkSJAOXxyfCWqsBKatQ2aLK7BPVZed hH0g== X-Forwarded-Encrypted: i=1; AJvYcCVrvIyaFurk4lM8OKGe5Ga4hEps0Td9/LLDk7/Q2WhtJiToC+CaP29CWDvfwH3Ae+HY399qIqbjoV6aZTrVRlJLBGEa8Nk= X-Gm-Message-State: AOJu0YzMypfGMaxJPz2IzCRfW7AmIAmVsWviroNfdhWniY1TjQRvrF5C wisIzcEyGsOrwhu4i/h2HrpYOLAPAbqvzrnvR4R5YIFdy8NXjC+Q X-Google-Smtp-Source: AGHT+IEwW2H/6jU2pV1pg3+0R8UODUoWFEgK5O4ut5Lw1roYBT/9TzylVYiyYpTSqUinaIUMRxO5PQ== X-Received: by 2002:a17:903:11c4:b0:1fb:2e9a:bef9 with SMTP id d9443c01a7336-1fc4e148a9amr45681155ad.16.1721317133221; Thu, 18 Jul 2024 08:38:53 -0700 (PDT) Original-Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-1fc0bc38db5sm94450895ad.224.2024.07.18.08.38.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Jul 2024 08:38:52 -0700 (PDT) Content-Language: en-US In-Reply-To: <87frs759nm.fsf@gmx.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288972 Archived-At: On 7/18/2024 2:31 AM, Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: > Jim Porter writes: > >> diff --git a/lisp/eshell/esh-proc.el b/lisp/eshell/esh-proc.el >> index 0dcdf3bb76c..fbeb13362f3 100644 >> --- a/lisp/eshell/esh-proc.el >> +++ b/lisp/eshell/esh-proc.el >> + (cond >> + ;; Delay signalling remote processes to prevent >> + ;; "Forbidden reentrant call of Tramp". >> + ((process-get proc 'remote-pid) >> + (run-at-time 0 nil #'signal-process proc 'SIGPIPE)) > > Shouldn't there be a non-nil REMOTE argument? Isn't a process object with the 'remote-pid' property set sufficient here? From my understanding of the code, REMOTE is redundant in that case. (I'll probably need the REMOTE argument in some other Eshell code that we've been discussing recently, but not here I think...)