From: Jim Porter <jporterbugs@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: reza <reza@housseini.me>, 58921@debbugs.gnu.org
Subject: bug#58921: Tab completion hangs in eshell
Date: Fri, 3 Mar 2023 21:37:05 -0800 [thread overview]
Message-ID: <657cb4fc-5162-0a6e-776d-0f34ebce7fc8@gmail.com> (raw)
In-Reply-To: <fdef055d-0975-c216-844e-ffbd0cc3e573@gmail.com>
On 2/23/2023 12:43 PM, Jim Porter wrote:
> Ah, good point. Instead of '(pcomplete-match "\\`--.*=" 0)', I think we
> want to handle all args starting with "--", but not matching "^--\\([^=
> \t\n\f]*\\)\\'". The goal is to call 'pcomplete-here*' exactly once per
> option.
>
> I did this a slightly different way in the updated patch by moving all
> the "--" cases into a single place (likewise with the "-" options). I
> think this is easier to follow than before, and makes it more obvious
> that we're calling 'pcomplete-here*' the right number of times.
Any other thoughts before I merge this patch?
next prev parent reply other threads:[~2023-03-04 5:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2cb2b8aa-0813-5eae-3bfc-27831b3d50dd@housseini.me>
2022-10-31 9:04 ` bug#58921: Tab completion hangs in eshell reza via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-02 7:28 ` Gerd Möllmann
2023-02-10 7:34 ` Jim Porter
2023-02-23 6:57 ` Jim Porter
2023-02-23 18:08 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-23 19:25 ` Jim Porter
2023-02-23 19:34 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-23 20:43 ` Jim Porter
2023-03-04 5:37 ` Jim Porter [this message]
2023-03-08 23:53 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=657cb4fc-5162-0a6e-776d-0f34ebce7fc8@gmail.com \
--to=jporterbugs@gmail.com \
--cc=58921@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=reza@housseini.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).