From: Ken Brown <kbrown@cornell.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Stromeko@nexgo.de, 50666@debbugs.gnu.org, akrl@sdf.org
Subject: bug#50666: 28.0.50; Fix native compilation on Cygwin
Date: Fri, 29 Oct 2021 13:03:29 -0400 [thread overview]
Message-ID: <656dcb30-7637-f900-0d22-235f0ecb884c@cornell.edu> (raw)
In-Reply-To: <838rycs7dh.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 454 bytes --]
On 10/29/2021 1:55 AM, Eli Zaretskii wrote:
>> Date: Thu, 28 Oct 2021 18:22:28 -0400
>> From: Ken Brown <kbrown@cornell.edu>
>> Eli, what do you think of the attached (assuming Achim agrees)?
>
> Assuming this decision of the Cygwin developers is final, I don't
> mind. But why do we want to depend on an environment variable for
> enabling the 32-bit build? why not a configure-time command-line
> option?
Thanks for the suggestion. How's this?
Ken
[-- Attachment #2: 0001-Drop-support-for-native-compilation-on-32-bit-Cygwin.patch --]
[-- Type: text/plain, Size: 1755 bytes --]
From 084b03ae1f81c72a46d4f365c50851db3674b4c1 Mon Sep 17 00:00:00 2001
From: Ken Brown <kbrown@cornell.edu>
Date: Fri, 29 Oct 2021 11:38:55 -0400
Subject: [PATCH] Drop support for native compilation on 32-bit Cygwin
* configure.ac (cygwin32-native-compilation): New option.
[i686-pc-cygwin]: Don't allow native compilation unless that
option is specified. (Bug#50666)
---
configure.ac | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/configure.ac b/configure.ac
index e6ffea0637..6bc194d792 100644
--- a/configure.ac
+++ b/configure.ac
@@ -485,6 +485,7 @@ AC_DEFUN
OPTION_DEFAULT_ON([modules],[don't compile with dynamic modules support])
OPTION_DEFAULT_ON([threads],[don't compile with elisp threading support])
OPTION_DEFAULT_OFF([native-compilation],[compile with Emacs Lisp native compiler support])
+OPTION_DEFAULT_OFF([cygwin32-native-compilation],[use native compilation on 32-bit Cygwin])
AC_ARG_WITH([file-notification],[AS_HELP_STRING([--with-file-notification=LIB],
[use a file notification library (LIB one of: yes, inotify, kqueue, gfile, w32, no)])],
@@ -3814,6 +3815,16 @@ AC_DEFUN
HAVE_NATIVE_COMP=no
LIBGCCJIT_LIBS=
LIBGCCJIT_CFLAGS=
+if test "$canonical" = i686-pc-cygwin; then
+ if test "${with_cygwin32_native_compilation}" = yes; then
+ with_native_compilation=yes
+ elif test "${with_native_compilation}" != no; then
+ AC_MSG_ERROR([Native compilation is not supported on 32-bit Cygwin.
+If you really want to try it anyway, use the configure option
+'--with-cygwin32-native-compilation'.])
+ fi
+fi
+
if test "${with_native_compilation}" != "no"; then
if test "${HAVE_PDUMPER}" = no; then
AC_MSG_ERROR(['--with-native-compilation' requires '--with-dumping=pdumper'])
--
2.33.0
next prev parent reply other threads:[~2021-10-29 17:03 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-18 20:46 bug#50666: 28.0.50; Fix native compilation on Cygwin Ken Brown
2021-09-18 20:58 ` Ken Brown
2021-09-19 5:37 ` Eli Zaretskii
2021-09-19 7:00 ` ASSI
2021-09-19 7:08 ` Eli Zaretskii
2021-09-19 11:31 ` ASSI
2021-09-19 12:06 ` Eli Zaretskii
2021-09-19 12:37 ` Ken Brown
2021-09-19 13:41 ` Eli Zaretskii
2021-09-19 14:27 ` Ken Brown
2021-09-19 15:28 ` Eli Zaretskii
2021-09-19 16:17 ` Ken Brown
2021-09-19 17:12 ` Eli Zaretskii
2021-09-22 21:35 ` Ken Brown
2021-09-23 7:42 ` Eli Zaretskii
2021-09-23 14:20 ` Ken Brown
2021-09-23 16:37 ` Eli Zaretskii
2021-09-23 17:13 ` Ken Brown
2021-09-23 17:29 ` Eli Zaretskii
2021-09-23 17:49 ` Achim Gratz
2021-09-23 18:01 ` Eli Zaretskii
2021-09-23 18:25 ` Achim Gratz
2021-09-23 18:46 ` Eli Zaretskii
2021-10-28 22:22 ` Ken Brown
2021-10-29 5:54 ` Eli Zaretskii
2021-10-29 17:03 ` Ken Brown [this message]
2021-10-29 18:01 ` Eli Zaretskii
2021-10-29 18:12 ` Ken Brown
2021-10-31 20:22 ` Achim Gratz
2021-10-31 23:52 ` Ken Brown
2021-09-23 17:27 ` Achim Gratz
2021-09-23 17:48 ` Eli Zaretskii
2021-09-23 18:29 ` Achim Gratz
2021-09-23 18:57 ` Eli Zaretskii
2021-09-23 19:37 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-24 6:11 ` ASSI
2021-09-24 7:13 ` Eli Zaretskii
2021-09-24 7:32 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-24 9:05 ` ASSI
2021-09-24 10:48 ` Eli Zaretskii
2021-09-25 15:10 ` Eli Zaretskii
2021-09-23 19:11 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-23 19:21 ` Eli Zaretskii
2021-09-24 6:04 ` ASSI
2021-09-24 7:10 ` Eli Zaretskii
2021-09-24 7:26 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-24 11:10 ` Eli Zaretskii
2021-09-24 12:49 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-24 9:15 ` ASSI
2021-09-24 11:03 ` Eli Zaretskii
2021-09-19 5:32 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=656dcb30-7637-f900-0d22-235f0ecb884c@cornell.edu \
--to=kbrown@cornell.edu \
--cc=50666@debbugs.gnu.org \
--cc=Stromeko@nexgo.de \
--cc=akrl@sdf.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).