From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#33006: 27.0.50; `dired-do-find-regexp' doesn't work for remote directories Date: Mon, 22 Oct 2018 02:34:28 +0300 Message-ID: <656af5f6-4968-ff46-8d6a-a6814070d5f0@yandex.ru> References: <87woqnba3j.fsf@gmx.de> <87va5v343x.fsf@gmx.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1540165312 5786 195.159.176.226 (21 Oct 2018 23:41:52 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 21 Oct 2018 23:41:52 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 Cc: Philipp , 33006@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 22 01:41:48 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gENLw-0001Pt-2J for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Oct 2018 01:41:48 +0200 Original-Received: from localhost ([::1]:60603 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gENO2-0005Wi-L8 for geb-bug-gnu-emacs@m.gmane.org; Sun, 21 Oct 2018 19:43:58 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46456) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gENNq-0005S2-CV for bug-gnu-emacs@gnu.org; Sun, 21 Oct 2018 19:43:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gENFO-0008Ve-Mq for bug-gnu-emacs@gnu.org; Sun, 21 Oct 2018 19:35:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58853) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gENFO-0008V7-0Z for bug-gnu-emacs@gnu.org; Sun, 21 Oct 2018 19:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gENFN-00082n-S5 for bug-gnu-emacs@gnu.org; Sun, 21 Oct 2018 19:35:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Oct 2018 23:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33006 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 33006-submit@debbugs.gnu.org id=B33006.154016487930888 (code B ref 33006); Sun, 21 Oct 2018 23:35:01 +0000 Original-Received: (at 33006) by debbugs.gnu.org; 21 Oct 2018 23:34:39 +0000 Original-Received: from localhost ([127.0.0.1]:34878 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gENF0-000827-Q2 for submit@debbugs.gnu.org; Sun, 21 Oct 2018 19:34:38 -0400 Original-Received: from mail-wr1-f43.google.com ([209.85.221.43]:33254) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gENEz-00081u-7x for 33006@debbugs.gnu.org; Sun, 21 Oct 2018 19:34:37 -0400 Original-Received: by mail-wr1-f43.google.com with SMTP id u1-v6so7099020wrn.0 for <33006@debbugs.gnu.org>; Sun, 21 Oct 2018 16:34:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=GTP1jnjtcQIc+f9k0MuwIn895YQ0qVlmehVVquIIcpg=; b=JZjlOVIZT4CiNInAZxhxpwvK1dktoWfOElloE4B0STiVhLjJidyOhHriuu73WFh3iv A1ZB+WIkP6fc+Mw1p1BlS3hhVizAyXhPh4DUx9ECpmhUQ0Zv7NYW+r473a3HegBe14HB dxvWwE8nzIf3qo0mByz9OOmSBNjcYTVQOjowrMGK8w3K/wTCMLD2YeGouX/YAT8HSjzS I6zWbLlEiuJjUsqM469fvaldmHmnd/lRSnzlvVSkmnnUf563ujMXRXQ8/rryCIZ1g3/M zcqIn0qdGpEss+oC+uVPCn/lWF3HQXZCsZUBiPvnxbn6SUKGKqSo2uarRfNmsa4mKqr1 W8kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=GTP1jnjtcQIc+f9k0MuwIn895YQ0qVlmehVVquIIcpg=; b=WsQL+XFJv4hNHtWokW5jrYyooJTcPRSY7UV6hZoHcabDCzT8ahz17CIABrHCJUfTE1 lumZlwnpb2xdd9+MeN83ESLK9xHcCL+uuHDw9C1i5+63wnWVXitTi+AFr1uVUNCnLFEv OKbXRlGuV6JaeqrlxX9cgYs6brDeWKbGAsvoXZ8x55UxxOcFL6DuhqGYqqdMQVqV9nB6 Zmrlbb1Zwn/mZtSgJc5jHHz3aGsxlTn8/NT7/XQsbRpaLJP55glmbMCwd2XK01pjmWC2 EtlbUkyuKDl7MXAaKhSlWDo9PAutkselEga0LVlv7rQRicIp+q19zb81TjQhOdZlT6cL 1Tgg== X-Gm-Message-State: AGRZ1gJg0idc+uFEFt735iHARG8y9T6cEFHAtgg7maaSzoPCGiGwc6je qIoLF9+0HNTJwRyQ9a3xW8LfSF8V X-Google-Smtp-Source: AJdET5dS6WVYF0fpk/Ex1GNdSk5ma2j7HCSe1Vm6M+JHZkGMJawfunupzr85AztOvNRIo8FPl8ILNQ== X-Received: by 2002:a5d:6b4f:: with SMTP id x15-v6mr14460254wrw.304.1540164871066; Sun, 21 Oct 2018 16:34:31 -0700 (PDT) Original-Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id k23-v6sm30625912wrd.85.2018.10.21.16.34.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 21 Oct 2018 16:34:30 -0700 (PDT) In-Reply-To: <87va5v343x.fsf@gmx.de> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:151492 Archived-At: Hi Michael, Sorry for the late reply. On 21.10.2018 14:56, Michael Albinus wrote: >> The appended patch fixes this for me. But since I don't know xref.el in >> detail, I fear I introduce collateral damages. At least a second opinion >> about the patch would be welcome, before I commit it to master. > > Ping. Dmitry, could you pls comment? The patch doesn't look dangerous to me, so you can go ahead and install, thank you. There is, however, a possible inconsistency: it touches xref--collect-matches-1, which is used both in xref-collect-matches and xref-collect-references. And you only changed the former function. Could you check that M-x xref-find-references didn't work on remote directories before your patch anyway? If it did, though, please make sure that it continues to do so. Bonus points for fixing it, at least when Grep is used (the relevant file is lisp/cedet/semantic/symref/grep.el).