From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#71760: [PATCH] js-ts-mode: Fix filling of jsdoc blocks Date: Sat, 3 Aug 2024 20:05:30 -0700 Message-ID: <65638F2B-0895-4560-B41F-C22C0A7ADA4E@gmail.com> References: <875xsoousd.fsf@cassou.me> <87sevqx90w.fsf@cassou.me> <94fbe0b9-004b-49ea-9a22-de1e4f1d6f68@gutov.dev> <965418E3-4D87-4F83-8CFD-4BDDDE749BBF@gmail.com> <9a1f6d7c-b7e6-4da4-845c-c9dee5baa8c1@gutov.dev> <4E0726C0-DF68-46FE-943E-2D242959BD32@gmail.com> <8ae599c2-e5b1-4db8-9862-08bd0940edc9@gutov.dev> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.600.62\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30196"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Damien Cassou , 71760-done@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 04 05:08:10 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1saRbN-0007iA-7L for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Aug 2024 05:08:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1saRay-0002zV-11; Sat, 03 Aug 2024 23:07:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1saRaw-0002yx-FC for bug-gnu-emacs@gnu.org; Sat, 03 Aug 2024 23:07:42 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1saRaw-00082b-6A for bug-gnu-emacs@gnu.org; Sat, 03 Aug 2024 23:07:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:Date:In-Reply-To:From:Mime-Version:To:Subject; bh=N14PFnOIKr3pF0BCm26VbeEYn6G+/FGZqf3c2w56UM0=; b=jPEzL6KCV9l57QMEMdOustX7CjFRTORdpUS2ObqC9JEd2XaeSS16b4ripXxKosot1TThH/9ZoLfXRaurX2VHLCMbj2LdrSZzEOKLz6QGkFUe4c+k8Dv5+WusndrKov5YfT0bAWJCkvF6cLdT0HWM0dpjxNsT50BEY0ynoLsS8Za9GYnPRMekgl0PpQ+Pvyhwm2YL7xQQeQNiBYelvZa1CK+ixoWslpenByqZ3vHjKjsgjxvb9x4EksbT9loei1kdfeOC+GNVbAMHqTpkWI5fpKAe0ZskfvCh5D/fYYQzrI79kT6pTXY5r6qhUHWprGjHb92iyzM97MBd2JSKdTKrkA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1saRbG-0007Io-J9 for bug-gnu-emacs@gnu.org; Sat, 03 Aug 2024 23:08:02 -0400 Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Aug 2024 03:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 71760 X-GNU-PR-Package: emacs Mail-Followup-To: 71760@debbugs.gnu.org, casouri@gmail.com, damien@cassou.me Original-Received: via spool by 71760-done@debbugs.gnu.org id=D71760.172274083127933 (code D ref 71760); Sun, 04 Aug 2024 03:08:02 +0000 Original-Received: (at 71760-done) by debbugs.gnu.org; 4 Aug 2024 03:07:11 +0000 Original-Received: from localhost ([127.0.0.1]:54963 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1saRaR-0007GT-4m for submit@debbugs.gnu.org; Sat, 03 Aug 2024 23:07:11 -0400 Original-Received: from mail-pg1-f172.google.com ([209.85.215.172]:54696) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1saRaP-0007G4-1I for 71760-done@debbugs.gnu.org; Sat, 03 Aug 2024 23:07:09 -0400 Original-Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-7163489149eso6733437a12.1 for <71760-done@debbugs.gnu.org>; Sat, 03 Aug 2024 20:06:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722740742; x=1723345542; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=N14PFnOIKr3pF0BCm26VbeEYn6G+/FGZqf3c2w56UM0=; b=LpNHUH8UXKFA45b6sX27GdC+TwC7xolxF7/yUOgUIoFeTivDyuU67t/8GPRTT7utcQ T+lHZdtxAveOZSC6dqYPFg+HMSWW4oLnxOiwHIlDy+qPdgvItb4nFY5X5hFPm3+7quRd TfX/x53Y/kwR2j/ury4uYuEeG+q+FCIlP4yXeqZwsiu8ee+5nn59KutWkiKujFMDasrR wiadgCCoNvyHrIPZXgQIadb1oRgDFe+AwfRkqAYvHXX6vrLsq1mWYRVvbbJbzJqohxRG 1kwsjJmFrXFD98VtYOTnrzYUH1ICu4iRL8ajDHdoAdytb2jqH6eR/zisSSlrEvHMgsyS kjQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722740742; x=1723345542; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=N14PFnOIKr3pF0BCm26VbeEYn6G+/FGZqf3c2w56UM0=; b=qxbLRmx5XVlPaLnYK+3OLW82xwFfWzXMgo3zCux7O8wT1iHindzESCdeBSmEoEXj2/ nEzUY1yavdwM2L+O/MRYdMXe3BUW5pxe0czpKqGQV/vYVid0H2slyXHz4I20iGSI+fGg qCTRNQnPlfAep24K/2Uor9HU44QUfLJ99uwdxVkKAqpG7yFSVcGi07DJHhRkH6/Y9PLF qvDBl8gWmOMX7JYw57ceB51+ckeyWonquVz8JGlElh4Am2LRIa0GxWAtR0gFA5OB77ze wAu0i6T/lVnSo7Tpt/fYsNzPTmSj53x8HDE+S5h8BEBM4T9I2+RF8eUp8QawjpelK1x4 AfnQ== X-Forwarded-Encrypted: i=1; AJvYcCWZlSNzqyh3Hk1LVlb+01nr90wEe6I1021sNtmsRfZzq6JXBhu1pp3FqGN6ItTG/eeiICFoFv+HiXgSRepPl2HO+9sglwGRXIZatw== X-Gm-Message-State: AOJu0Yz3JBu90Ub6WJrVkSYYgzfUWjDN8UGr8sB3niFzv5hPq7b6BeAQ j1XoNczdwXpbfqGDrfTTFLHkEsDqXt37YmDriclkeuYPHCG7L4Ju X-Google-Smtp-Source: AGHT+IFl+Bo8gBjIeNUMkdYC91IOw3p/U5ahIokV9s4gXs8tr1usxNfChfYxYq8Iufqu8qq3rGMKrg== X-Received: by 2002:a05:6a21:1813:b0:1c0:f1ea:adf with SMTP id adf61e73a8af0-1c699582281mr10544389637.16.1722740742430; Sat, 03 Aug 2024 20:05:42 -0700 (PDT) Original-Received: from smtpclient.apple ([2601:646:8f81:6120:90c7:b430:aa7b:7b1f]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7106ec400f3sm3363758b3a.54.2024.08.03.20.05.41 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 03 Aug 2024 20:05:41 -0700 (PDT) In-Reply-To: <8ae599c2-e5b1-4db8-9862-08bd0940edc9@gutov.dev> X-Mailer: Apple Mail (2.3774.600.62) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289701 Archived-At: > On Aug 3, 2024, at 8:14=E2=80=AFAM, Dmitry Gutov = wrote: >=20 > On 03/08/2024 10:34, Yuan Fu wrote: >>> I think Damien is saying that patch#2 from his submission is not = necessary with your fix (commit 74bb1e5897f, IIUC). >>>=20 >>> So do you think it's a good idea to backport it to emacs-30? >> I=E2=80=99d rather apply Damien=E2=80=99s patch to emacs-30, that=E2=80= =99s a simple fix and doesn=E2=80=99t change the filling behavior. The = change I applied to master is more substantial, and apparently = introduced another regression that I now need to fix =F0=9F=99=81 >=20 > Makes sense. >=20 > It would be great if you could do the applying - while I understand = the tree-sitter part, I'm not quite familiar with the filling code, so = not equipped to give it a "stamp of approval" myself. >=20 > Also, I would probably have to ask whether this patch if a replacement = for that's been added to master, an addition, or a suitable alternative. Of course. I applied the patch. And I think this report can be closed, = so closing :-) Yuan=