From: Yuan Fu <casouri@gmail.com>
To: Dmitry Gutov <dmitry@gutov.dev>
Cc: Damien Cassou <damien@cassou.me>, 71760-done@debbugs.gnu.org
Subject: bug#71760: [PATCH] js-ts-mode: Fix filling of jsdoc blocks
Date: Sat, 3 Aug 2024 20:05:30 -0700 [thread overview]
Message-ID: <65638F2B-0895-4560-B41F-C22C0A7ADA4E@gmail.com> (raw)
In-Reply-To: <8ae599c2-e5b1-4db8-9862-08bd0940edc9@gutov.dev>
> On Aug 3, 2024, at 8:14 AM, Dmitry Gutov <dmitry@gutov.dev> wrote:
>
> On 03/08/2024 10:34, Yuan Fu wrote:
>>> I think Damien is saying that patch#2 from his submission is not necessary with your fix (commit 74bb1e5897f, IIUC).
>>>
>>> So do you think it's a good idea to backport it to emacs-30?
>> I’d rather apply Damien’s patch to emacs-30, that’s a simple fix and doesn’t change the filling behavior. The change I applied to master is more substantial, and apparently introduced another regression that I now need to fix 🙁
>
> Makes sense.
>
> It would be great if you could do the applying - while I understand the tree-sitter part, I'm not quite familiar with the filling code, so not equipped to give it a "stamp of approval" myself.
>
> Also, I would probably have to ask whether this patch if a replacement for that's been added to master, an addition, or a suitable alternative.
Of course. I applied the patch. And I think this report can be closed, so closing :-)
Yuan
prev parent reply other threads:[~2024-08-04 3:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-24 20:23 bug#71760: 31.0.50; Filling jsdoc text doesn't work in js-ts-mode Damien Cassou
2024-07-29 19:36 ` bug#71760: [PATCH] js-ts-mode: Fix filling of jsdoc blocks Damien Cassou
2024-07-31 8:25 ` Damien Cassou
2024-08-01 1:00 ` Dmitry Gutov
2024-08-01 1:07 ` Yuan Fu
2024-08-01 7:36 ` Yuan Fu
2024-08-01 10:26 ` Damien Cassou
2024-08-01 21:26 ` Dmitry Gutov
2024-08-03 7:34 ` Yuan Fu
2024-08-03 15:14 ` Dmitry Gutov
2024-08-04 3:05 ` Yuan Fu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65638F2B-0895-4560-B41F-C22C0A7ADA4E@gmail.com \
--to=casouri@gmail.com \
--cc=71760-done@debbugs.gnu.org \
--cc=damien@cassou.me \
--cc=dmitry@gutov.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).