unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Francis Wright" <f.j.wright@qmul.ac.uk>
To: "'Kenichi Handa'" <handa@m17n.org>, "'Jason Rumney'" <jasonr@gnu.org>
Cc: 3319@emacsbugs.donarmstrong.com
Subject: bug#3319: 23.0.93; Default font
Date: Tue, 19 May 2009 18:14:58 +0100	[thread overview]
Message-ID: <6550.19177725098$1242796777@news.gmane.org> (raw)
In-Reply-To: <E1M6I5e-00041e-Ae@etlken>

> From: Kenichi Handa [mailto:handa@m17n.org]
> Sent: Tuesday 19 May 2009 6:42 am
> To: Jason Rumney
> Cc: 3319@emacsbugs.donarmstrong.com; F.J.Wright@qmul.ac.uk
> Subject: Re: bug#3319: 23.0.93; Default font
> 
> In article <4A1227C1.2010503@gnu.org>, Jason Rumney <jasonr@gnu.org>
> writes:
> 
> > Kenichi Handa wrote:
> > > I think what you intend by :family "outline-lucida sans
> > > typewriter" is actually :foundry "outline" :family "lucida
> > > sans typewriter", right.  If so, I've just installed a fix.
> > > Please try again.
> 
> > Please ensure your fix does not break cases like :family "MingLiU-
> ExtB",
> > where the hyphen really is part of the family name.
> 
> We can't handle that kind of family name without breaking a
> backward compatibility.  We discussed this matter a while
> ago, but didn't reach a conclusion.  I'll put the last mail
> on that thread at the tail.
> 
> Anyway, my change is just this.
> 
> -	  (setq foundry (match-string 2 family)))
> -	(setq family (match-string 1 family)))
> +	  (setq foundry (match-string 1 family)))
> +	(setq family (match-string 2 family)))
> 
> and it is a fix of a bug introduced by this change.
> 
> 2008-10-14  Chong Yidong  <cyd@stupidchicken.com>
> 
> 	* faces.el (set-face-attribute): Set family and foundry before
> 	other attributes.

I just edited the above change into faces.el and recompiled it, but it
doesn't seem to have made any difference. I'll recheck tomorrow.

Francis







  reply	other threads:[~2009-05-19 17:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <001801c9d71a$8bade240$a309a6c0$@J.Wright@qmul.ac.uk>
2009-05-19  1:30 ` bug#3319: 23.0.93; Default font Kenichi Handa
2009-05-19  3:30   ` Jason Rumney
2009-05-19  5:42     ` Kenichi Handa
2009-05-19 17:14       ` Francis Wright [this message]
     [not found]       ` <006601c9d8a5$563b2550$02b16ff0$@j.wright@qmul.ac.uk>
2009-05-20  0:40         ` Kenichi Handa
2009-05-20 16:57           ` Francis Wright
2009-05-19 14:33     ` Stefan Monnier
2009-05-19 17:03       ` Francis Wright
2009-05-20  0:28       ` Kenichi Handa
2009-05-20  2:16         ` Stefan Monnier
2009-05-20  4:14           ` Kenichi Handa
2009-05-20 17:02           ` Francis Wright
2009-05-25 16:34   ` Francis Wright
2009-05-17 18:08 Francis Wright

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='6550.19177725098$1242796777@news.gmane.org' \
    --to=f.j.wright@qmul.ac.uk \
    --cc=3319@emacsbugs.donarmstrong.com \
    --cc=handa@m17n.org \
    --cc=jasonr@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).