From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#33992: 27.0.50; xref-find-definitions wastes too much space Date: Fri, 5 Apr 2019 02:06:57 +0300 Message-ID: <64f42172-460f-a633-1c80-23d34b5c0d07@yandex.ru> References: <87muoe7jrs.fsf@mail.linkov.net> <87a7hp43a5.fsf@mail.linkov.net> <205acda7-07a3-d85c-378c-c178f9f76b55@yandex.ru> <87o95l4ht4.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="105296"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:67.0) Gecko/20100101 Thunderbird/67.0 Cc: 33992@debbugs.gnu.org, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 05 01:08:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hCBSv-000REw-0h for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Apr 2019 01:08:13 +0200 Original-Received: from localhost ([127.0.0.1]:60777 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCBSt-0006Nj-Mp for geb-bug-gnu-emacs@m.gmane.org; Thu, 04 Apr 2019 19:08:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35870) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCBSl-0006NW-Ih for bug-gnu-emacs@gnu.org; Thu, 04 Apr 2019 19:08:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hCBSk-0006tX-NI for bug-gnu-emacs@gnu.org; Thu, 04 Apr 2019 19:08:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59483) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hCBSk-0006r5-HB for bug-gnu-emacs@gnu.org; Thu, 04 Apr 2019 19:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hCBSk-0008Iq-52 for bug-gnu-emacs@gnu.org; Thu, 04 Apr 2019 19:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Apr 2019 23:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 33992-submit@debbugs.gnu.org id=B33992.155441923131852 (code B ref 33992); Thu, 04 Apr 2019 23:08:02 +0000 Original-Received: (at 33992) by debbugs.gnu.org; 4 Apr 2019 23:07:11 +0000 Original-Received: from localhost ([127.0.0.1]:44794 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCBRu-0008Hf-Mo for submit@debbugs.gnu.org; Thu, 04 Apr 2019 19:07:10 -0400 Original-Received: from mail-lf1-f52.google.com ([209.85.167.52]:44941) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCBRs-0008HN-D5 for 33992@debbugs.gnu.org; Thu, 04 Apr 2019 19:07:09 -0400 Original-Received: by mail-lf1-f52.google.com with SMTP id v71so2965579lfa.11 for <33992@debbugs.gnu.org>; Thu, 04 Apr 2019 16:07:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3nWPLM0E762t+FxqUJYmmreJkDLSWt280IuTNqIkLyk=; b=OfwK78B7/C9Tj6ZWqwJdQQp2y6iPzhIeqFWqGbHb3GU0GCvzIc40tb4Kys6mxD0kr9 6G4VPb2lSx83k8eL1fqh2+nwrgp1T4XONcrsbxlYn9vDGeX1PYsXjvMmeMUheQ4MAOB7 KJmd4JVy1wctGp7ycUHpwJ/eJ9aBnayzqmzlijgfOaqV1D2xxuHrW98ACECMSG15n9ZT JbYoYsc6OjEqVBIIn7KqBgeZbUp9lsRjvKXi58xl4R14k7vwXUyzj31N0A+HRx+NImQP dHW9awCJ1lUof2McgOndEkzXFSGywTIdfokSenifBo7chYXqLp8AyMXvDhsCAIVY2MYV h3qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3nWPLM0E762t+FxqUJYmmreJkDLSWt280IuTNqIkLyk=; b=dVxG0O1sh0E7NMjplR8YTl7lPgV6dYWMAVJa7svDIAIL3EYu+TNSpcOL9vNPntst5T omsQivZL6q73l8bgseJA+nCgKKrQ6aEfFfBYDGjJR4ZIfHXjRTySPjekX1Fmkky3daq+ FyVKxGNU4aVgiE7SkxNXtIIvZwwnBn8UC4o1wIYM3alqcQf21JcZijUhAzARD+7YuwhE ZbxeNDyoUVOW6SiqAZdn2KqSJhMfBILsQ4it8pAlpiSHC8umsVt/ukXHuIwd0mbMxNxC rjgoCZU1W1xZ6Z2G1+lizDu1IcogKyLoL9lnp9634HVHkUoOII41DGtjulEz+NdVmla7 3cPA== X-Gm-Message-State: APjAAAWV8stnib1ufPHP8McDogJxV9M4XkdjXjHOAsijVK4ko2c20ugu o/gD0qBWTxO4jrE0ttPAMWDid1uI X-Google-Smtp-Source: APXvYqxqaE2huKHJCJ5/Ul7WYlOXwz0u/mf3mT3hi9Hg7N4yEZBGr57KArv/dutdTdxsMo7SqcnUUA== X-Received: by 2002:a19:c203:: with SMTP id l3mr4519696lfc.39.1554419220953; Thu, 04 Apr 2019 16:07:00 -0700 (PDT) Original-Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id 73sm4637785ljf.72.2019.04.04.16.06.58 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Thu, 04 Apr 2019 16:06:59 -0700 (PDT) In-Reply-To: <87o95l4ht4.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157184 Archived-At: On 04.04.2019 23:49, Juri Linkov wrote: >> Does it feel the same way to you? > > The difference is that completions pop up in a small unobtrusive window. Small window? I usually have a side-by-side fullscreen split, and if I initiate completion in one of the windows, *Completion* takes up the whole other window. Temporarily, of course. > But this should be easy to do in xref now too. > > Thanks to João, we now have configurable window management in xref, > so I tried different customizations, and one of the most appealing > is this: > > (defun display-buffer-condition-xref (buffer-name _action) > (and (string-match-p "\\`\\*\\(xref\\)\\*\\(\\|<[0-9]+>\\)\\'" > buffer-name) > (memq this-command '(xref-find-definitions)))) > > (defun display-buffer-condition-from-xref (_buffer-name _action) > (string-match-p "\\`\\*\\(xref\\)\\*\\(\\|<[0-9]+>\\)\\'" > (buffer-name (current-buffer)))) This function seems unused. > (setq display-buffer-alist > '((display-buffer-condition-xref > display-buffer-in-direction And this function is undefined in my Emacs. > (direction . below) (window-height . fit-window-to-buffer)))) > > (with-eval-after-load 'xref > (define-key xref--button-map [(control ?m)] #'xref-quit-and-goto-xref)) > > How do you like that? I might, but since I can't really try your customization myself yet, I'll repeat a question you might be familiar with already: Will this also affect xref-find-references and project-find-regexp?