From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#33566: [PATCH] RE: bug#33566: 26; `group' :type for defcustom Date: Mon, 3 Dec 2018 12:49:39 -0800 (PST) Message-ID: <64ef54b7-8773-480c-943f-fcde67233332@default> References: <09947acd-9d28-44c8-9fa0-c5cd4a4ee569@default> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1543870101 4109 195.159.176.226 (3 Dec 2018 20:48:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 3 Dec 2018 20:48:21 +0000 (UTC) To: Phil Sainty , 33566@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 03 21:48:16 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gTv8a-0000xc-BE for geb-bug-gnu-emacs@m.gmane.org; Mon, 03 Dec 2018 21:48:16 +0100 Original-Received: from localhost ([::1]:52422 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gTvAh-0000xK-0d for geb-bug-gnu-emacs@m.gmane.org; Mon, 03 Dec 2018 15:50:27 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47149) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gTvAU-0000ux-7w for bug-gnu-emacs@gnu.org; Mon, 03 Dec 2018 15:50:16 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gTvAQ-0003pS-3Z for bug-gnu-emacs@gnu.org; Mon, 03 Dec 2018 15:50:14 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55250) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gTvAJ-0003cz-6F for bug-gnu-emacs@gnu.org; Mon, 03 Dec 2018 15:50:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gTvAI-0007g0-8J for bug-gnu-emacs@gnu.org; Mon, 03 Dec 2018 15:50:03 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <09947acd-9d28-44c8-9fa0-c5cd4a4ee569@default> Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 Dec 2018 20:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33566 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33566-submit@debbugs.gnu.org id=B33566.154387019129487 (code B ref 33566); Mon, 03 Dec 2018 20:50:02 +0000 Original-Received: (at 33566) by debbugs.gnu.org; 3 Dec 2018 20:49:51 +0000 Original-Received: from localhost ([127.0.0.1]:59508 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gTvA7-0007fX-BO for submit@debbugs.gnu.org; Mon, 03 Dec 2018 15:49:51 -0500 Original-Received: from userp2120.oracle.com ([156.151.31.85]:57234) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gTvA4-0007fF-BG for 33566@debbugs.gnu.org; Mon, 03 Dec 2018 15:49:50 -0500 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wB3KiRue115094; Mon, 3 Dec 2018 20:49:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=ANxIzYBdF5HOnxNoG53bdRxgXGksSPA+pY9/rSL4xhc=; b=3cU65BqvybH6MhsFQ/Jxg6aC9kP6mpYCqK7/eD+fadC46L5y3QuTgCoNmwGO/Hkqw6m0 IR/Rr5bCSFMhfN4U01zad+SftBJkOK1ob1AYkg0R2MBx65ciZiCGv4KtRlaOpHcvIA+D +BdQEH0ejWQimlVjQSZElfCY4+C+LB5gtp7Dj+W83dev/jUO4aHMJtUjttpWG50YTYir BCVylSfxxIaOj3pcjRoNBDBK5DpV0UT9fc+huqfyUqJOU2kTmAjEo1CKzTZTGD8xPl8M 4F/k/SlB76H9rnjvqLn+cbHQmrvsOWmm/itwz0uNbQAv2Bbt3W09wH7igvsG5EU7GBX5 kA== Original-Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2120.oracle.com with ESMTP id 2p3jxr8p4r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 03 Dec 2018 20:49:41 +0000 Original-Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id wB3KnfEx026557 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 3 Dec 2018 20:49:41 GMT Original-Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id wB3KneQC015968; Mon, 3 Dec 2018 20:49:40 GMT X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4771.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9096 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=822 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1812030189 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153034 Archived-At: I think the patch below fixes the code bug. Someone else can consider fixing the doc bug: > I think the doc needs to be corrected in (widget) > Editable Text Fields. This is not correct/sufficient; >=20 > *Warning:* In an =E2=80=98editable-field=E2=80=99 widget, the =E2=80=98= %v=E2=80=99 > escape must be preceded by some other text in the > =E2=80=98:format=E2=80=99 string (if specified). >=20 > It's not sufficient that just any old text precede > the `%v'. There must be a colon, AFAICT. >=20 > It should instead say something like this: >=20 > *Warning:* In an =E2=80=98editable-field=E2=80=99 widget, the `%v' > escape must be preceded by a colon (`:') in the > `:format' string (if specified). No tag name need > precede the colon, but the colon must be present. > (Additional text can follow the colon and precede > the `%v'.) ... > I'd also drop the "*Warning:*", personally, and > instead say that this is necessary or you get a > bad format message (or some such). --- diff -u wid-edit.el wid-edit-2018-12-03a-patched.el --- wid-edit.el=092018-12-03 12:37:30.626331700 -0800 +++ wid-edit-2018-12-03a-patched.el=092018-12-03 12:43:05.440329000 -0800 @@ -2746,7 +2746,7 @@ "A widget which groups other widgets inside." :convert-widget 'widget-types-convert-widget :copy 'widget-types-copy - :format "%v" + :format ":\n%v" :value-create 'widget-group-value-create :value-get 'widget-editable-list-value-get :default-get 'widget-group-default-get