From: Drew Adams <drew.adams@oracle.com>
To: Phil Sainty <psainty@orcon.net.nz>, 33566@debbugs.gnu.org
Subject: bug#33566: [PATCH] RE: bug#33566: 26; `group' :type for defcustom
Date: Mon, 3 Dec 2018 12:49:39 -0800 (PST) [thread overview]
Message-ID: <64ef54b7-8773-480c-943f-fcde67233332@default> (raw)
In-Reply-To: <09947acd-9d28-44c8-9fa0-c5cd4a4ee569@default>
I think the patch below fixes the code bug.
Someone else can consider fixing the doc bug:
> I think the doc needs to be corrected in (widget)
> Editable Text Fields. This is not correct/sufficient;
>
> *Warning:* In an ‘editable-field’ widget, the ‘%v’
> escape must be preceded by some other text in the
> ‘:format’ string (if specified).
>
> It's not sufficient that just any old text precede
> the `%v'. There must be a colon, AFAICT.
>
> It should instead say something like this:
>
> *Warning:* In an ‘editable-field’ widget, the `%v'
> escape must be preceded by a colon (`:') in the
> `:format' string (if specified). No tag name need
> precede the colon, but the colon must be present.
> (Additional text can follow the colon and precede
> the `%v'.)
...
> I'd also drop the "*Warning:*", personally, and
> instead say that this is necessary or you get a
> bad format message (or some such).
---
diff -u wid-edit.el wid-edit-2018-12-03a-patched.el
--- wid-edit.el 2018-12-03 12:37:30.626331700 -0800
+++ wid-edit-2018-12-03a-patched.el 2018-12-03 12:43:05.440329000 -0800
@@ -2746,7 +2746,7 @@
"A widget which groups other widgets inside."
:convert-widget 'widget-types-convert-widget
:copy 'widget-types-copy
- :format "%v"
+ :format ":\n%v"
:value-create 'widget-group-value-create
:value-get 'widget-editable-list-value-get
:default-get 'widget-group-default-get
next prev parent reply other threads:[~2018-12-03 20:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-01 20:44 bug#33566: 26; `group' :type for defcustom Drew Adams
2018-12-01 23:11 ` Phil Sainty
2018-12-02 0:31 ` Drew Adams
2018-12-03 20:49 ` Drew Adams [this message]
2018-12-22 23:35 ` bug#33566: [PATCH] " Drew Adams
2018-12-29 8:04 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64ef54b7-8773-480c-943f-fcde67233332@default \
--to=drew.adams@oracle.com \
--cc=33566@debbugs.gnu.org \
--cc=psainty@orcon.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).