From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#25581: 25.1; Incorrect statement in (elisp) `Hooks' Date: Mon, 24 Aug 2020 09:13:24 -0700 (PDT) Message-ID: <646949ae-1130-4d38-ac56-10ceb1ff53a9@default> References: <8e81acfe-ecaa-4fac-9484-24541b232ba1@default> <87k0xo83ww.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6974"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 25581@debbugs.gnu.org To: Stefan Kangas , Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 24 18:14:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kAF6p-0001hn-Ht for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 24 Aug 2020 18:14:11 +0200 Original-Received: from localhost ([::1]:56636 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kAF6o-0004Es-J8 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 24 Aug 2020 12:14:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50202) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kAF6g-0004Ck-Hc for bug-gnu-emacs@gnu.org; Mon, 24 Aug 2020 12:14:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47487) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kAF6g-0003fb-8r for bug-gnu-emacs@gnu.org; Mon, 24 Aug 2020 12:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kAF6g-0002af-4h for bug-gnu-emacs@gnu.org; Mon, 24 Aug 2020 12:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Aug 2020 16:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25581 X-GNU-PR-Package: emacs Original-Received: via spool by 25581-submit@debbugs.gnu.org id=B25581.15982856159915 (code B ref 25581); Mon, 24 Aug 2020 16:14:02 +0000 Original-Received: (at 25581) by debbugs.gnu.org; 24 Aug 2020 16:13:35 +0000 Original-Received: from localhost ([127.0.0.1]:59032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAF6E-0002Zr-UG for submit@debbugs.gnu.org; Mon, 24 Aug 2020 12:13:35 -0400 Original-Received: from userp2130.oracle.com ([156.151.31.86]:37310) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAF6C-0002Za-MO for 25581@debbugs.gnu.org; Mon, 24 Aug 2020 12:13:33 -0400 Original-Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 07OGAW08115414; Mon, 24 Aug 2020 16:13:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=ogEdQv6Eg41xDAmjSd6ArcrDHZJUT3ZUREYSNmUFOIM=; b=zNenzFdcioJkm41j7XFbS9q1cfkEJr4cnoK8FwO8UHWaqBx9xNkoRG/DlLFbNKLSFWQZ dN79u8jD4d8rmKAjc99zQi48jekmqSiNVRIb7Igs/YbFQrzYZfq9gDrJ7E9HUIDEO3fI QMs8zCGtqI57wLmT2JtKcyhyiX8+VaNLvTIWjH1+7G4cny/k24uaSX/DV8c6dFtuREib i3C6Qa6HuId4HnO+qQIc9fsf/S0es2+3EP0HgVXUWw63rrjkU40OTQ+h2QNrHd0oiLUc dIOqcaXTRcbrAnN1P6Uh74r/uBjogc9pRtn4ZUGnnzzLuhvjmAXjyJYwF/vj1sqmFC33 Aw== Original-Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2130.oracle.com with ESMTP id 333cshwj2e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 24 Aug 2020 16:13:26 +0000 Original-Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 07OGAm6R151577; Mon, 24 Aug 2020 16:13:26 GMT Original-Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3030.oracle.com with ESMTP id 333r9hva4t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 24 Aug 2020 16:13:26 +0000 Original-Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 07OGDPKJ028693; Mon, 24 Aug 2020 16:13:25 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5044.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9722 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 bulkscore=0 adultscore=0 spamscore=0 mlxlogscore=999 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008240130 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9723 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 clxscore=1015 spamscore=0 priorityscore=1501 impostorscore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 mlxlogscore=999 phishscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008240130 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:186183 Archived-At: Please see my reply to Lars. I hope I've made things clear about this. There are two uses of vars named `*-function': (1) as a hook, (2) as a single function to call. The first use of such a name is, I think, legacy. I think such vars should be renamed to either `*-hook' or `*-functions', depending on whether they are normal or abnormal. But until they all are (and probably even then, since they could exist in 3rd-party code), the doc should cover them. If I'm right that they are only legacy, and should be renamed (to be confirmed by some old-timer such as RMS), then the doc could make this clear. `add-hook' and `run-hooks' work fine with such vars. The doc about that is not wrong. (Only the cited paragraph is wrong.) But if I'm right about the only-legacy thing, it would probably help for the doc to point out that a hook named `*-function' should probably be renamed (to `*-hook' or `*-functions', depending on whether it is normal or abnormal). And Emacs itself should in that case have its own such hooks renamed. But this understanding should be confirmed first.