From: David Ponce via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 69992@debbugs.gnu.org, joseph@breatheoutbreathe.in
Subject: bug#69992: Minor improvement to image map transformation logic
Date: Sat, 30 Mar 2024 09:55:59 +0100 [thread overview]
Message-ID: <645a1ccd-868b-4e02-bfc3-0ce4ab6b8f38@orange.fr> (raw)
In-Reply-To: <8634s8dtrp.fsf@gnu.org>
On 30/03/2024 09:10, Eli Zaretskii wrote:
>> Date: Fri, 29 Mar 2024 11:19:11 +0100
>> From: David Ponce <da_vid@orange.fr>
>> Cc: Eli Zaretskii <eliz@gnu.org>, Joseph Turner <joseph@breatheoutbreathe.in>
>>
>>> The attached new patch fixes the logic to be consistent with Emacs
>>> internal implementation, plus some other tweaks to check if a
>>> transformation apply before to call the transformation function.
>>> I also updated some tests according to functions changes.
>>> Here is a possible change log:
>>>
>>> 2024-03-28 David Ponce <da_vid@orange.fr>
>>>
>>> * lisp/image.el (image--compute-scaling)
>>> (image--compute-rotation): New functions.
>>> (image--compute-map, image--compute-original-map): Use them.
>>> Ensure all transformations are applied or undone according to what
>>> Emacs does internally. Call a transformation function only when
>>> needed. Fix doc string.
>>> (image--scale-map): Assume effective scale argument.
>>> (image--rotate-map): Assume effective rotation argument.
>>> (image--rotate-coord): Improve doc string.
>>> (image--flip-map): Remove no more used flip argument.
>>>
>>> * test/lisp/image-tests.el (image-create-image-with-map): Use a
>>> valid SVG image otherwise `image-size' will not return a valid
>>> value and calculation of scale could fail.
>>> (image-transform-map): Update according to changed signature of
>>> image--flip-map.
>> [...]
>>
>> Hello,
>>
>> Please find attached a new patch with an additional small fix I forgot to
>> include. Sorry.
>
> Thanks. Please resend with the updated commit log message, and I will
> install it.
Hello Eli,
The change log is the same. The last patch include a slightly modified
version of the new function `image--compute-rotation' to return 0 by default
when no rotation is specified, instead of nil.
Please let me know if you need anything else.
Thanks!
next prev parent reply other threads:[~2024-03-30 8:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 1:00 bug#69992: Minor improvement to image map transformation logic Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-27 11:16 ` David Ponce via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-27 12:50 ` Eli Zaretskii
2024-03-27 14:21 ` David Ponce via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-27 22:17 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-27 23:53 ` David Ponce via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-28 22:22 ` David Ponce via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-29 10:19 ` David Ponce via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-30 8:10 ` Eli Zaretskii
2024-03-30 8:55 ` David Ponce via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-03-30 12:59 ` David Ponce via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-30 13:37 ` Eli Zaretskii
2024-03-30 19:07 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=645a1ccd-868b-4e02-bfc3-0ce4ab6b8f38@orange.fr \
--to=bug-gnu-emacs@gnu.org \
--cc=69992@debbugs.gnu.org \
--cc=da_vid@orange.fr \
--cc=eliz@gnu.org \
--cc=joseph@breatheoutbreathe.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).