From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#61205: 'function' in 3rd element of treesit-font-lock-feature-list Date: Thu, 2 Feb 2023 18:38:37 -0800 Message-ID: <645D27C7-0376-45F9-A5C9-CD84F9467ED4@gmail.com> References: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9167"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 61205@debbugs.gnu.org, Theodor Thornhill , Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= , randy taylor To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 03 03:39:29 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pNlz6-00029O-7f for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 03 Feb 2023 03:39:28 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pNlyi-0007iW-6M; Thu, 02 Feb 2023 21:39:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNlyh-0007iF-6O for bug-gnu-emacs@gnu.org; Thu, 02 Feb 2023 21:39:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pNlyg-0005Y0-Fy for bug-gnu-emacs@gnu.org; Thu, 02 Feb 2023 21:39:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pNlyg-0005y5-1s for bug-gnu-emacs@gnu.org; Thu, 02 Feb 2023 21:39:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Feb 2023 02:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61205 X-GNU-PR-Package: emacs Original-Received: via spool by 61205-submit@debbugs.gnu.org id=B61205.167539193822928 (code B ref 61205); Fri, 03 Feb 2023 02:39:02 +0000 Original-Received: (at 61205) by debbugs.gnu.org; 3 Feb 2023 02:38:58 +0000 Original-Received: from localhost ([127.0.0.1]:36212 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNlyb-0005xk-SV for submit@debbugs.gnu.org; Thu, 02 Feb 2023 21:38:58 -0500 Original-Received: from mail-pl1-f175.google.com ([209.85.214.175]:35444) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNlyZ-0005xT-FW for 61205@debbugs.gnu.org; Thu, 02 Feb 2023 21:38:56 -0500 Original-Received: by mail-pl1-f175.google.com with SMTP id r8so3938625pls.2 for <61205@debbugs.gnu.org>; Thu, 02 Feb 2023 18:38:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=6qdrBmxQ2mphRyqdR+xI+LbjZbo0AFKRCga76Zaociw=; b=lSQT/XBnQWSJP5lm0WBVbXOfj/vN7KGkAdkPIvbp7TI5eQrIBlDGV/+D8TVQIOcJBF 0LEEOrYo4HCUFfUaww+1+YyMnX+hFfzBjKoG/vWDuimM1m/qEtjJefZHthx2nJtW6n2Y Zsfot+nEYlqEt9cJOB6Df4mwQyNmMAGE82S0zWD3RstJ4+eXUMXe5MsqzQj6I5lPcfgO cy/o7i1zloHGpMIDKRCJiZZUwwR/R15rFvfI3pNRu/DSsmqdYMk1/0miTtPicQXgC0OZ 70dHwJpa4FYJ3wLN5OQ9J4gTx49EvgU4mPm2bg6ikRiO8Mj6mKSAVCktFGQXD63rBDfT 2h4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6qdrBmxQ2mphRyqdR+xI+LbjZbo0AFKRCga76Zaociw=; b=peS+okBjJAy/1kXsMOWAxoq5+bXtvwRFRMtYxKqTFY4XR4htRNstORXFJWTO7vYXmm IX2ZM6hDH6culL3ginYj65hTAxWRrcJMPcLw71Wy9rQCcEUoZG6oRECIFI1RAlHAbRQ9 UvlmqlN4ZfKujCJOAZooAeCqEaXKaoKtoQkA1UvAXY3XsKwf2+jZcdw9Ep3jny7qAS9A QYzhduZp10Y+B2udW1K89iSWOV4AivINT97EHC2GQNkmvUAWUM1MdiOMBNG/6pOh0EUz ostGjlhAXDTslk/gUrFRFi7kXQpD15Byq4N+555qOJWPuTuAwyCPaZndRI6mEWaL9Dcg xJhg== X-Gm-Message-State: AO0yUKVDjjNruSUCUW5FP7p7dgFoK8hvC8ocPGpdjEevZHyncc74agzH qHcMQ9pBspyYSvLfmnfI/9o= X-Google-Smtp-Source: AK7set9Ua2B8w5Z8LDmE3bpE7lNwHp6jZfZvvC9zaAjMq/KxG4umq6ToNVGPIIUIFxwiOJMm3LUixQ== X-Received: by 2002:a05:6a20:bc96:b0:be:39b0:42e0 with SMTP id fx22-20020a056a20bc9600b000be39b042e0mr7960718pzb.19.1675391929480; Thu, 02 Feb 2023 18:38:49 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id 5-20020a170902e9c500b0018bde2250fcsm359598plk.203.2023.02.02.18.38.48 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 Feb 2023 18:38:49 -0800 (PST) In-Reply-To: X-Mailer: Apple Mail (2.3731.300.101.1.3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254704 Archived-At: > On Feb 2, 2023, at 12:25 PM, Dmitry Gutov wrote: >=20 > On 01/02/2023 07:18, Yuan Fu wrote: >>> On Jan 31, 2023, at 6:08 PM, Dmitry Gutov wrote: >>>=20 >>> X-Debbugs-Cc: Yuan Fu, Randy Taylor >>>=20 >>> Some new built-in modes has 'function' feature highlighting thus = enabled by default. >>>=20 >>> rust-ts-mode, go-ts-mode, cmake-mode >>>=20 >>> Should we move it to 4 for consistency with the rest? >>>=20 >>> Previously, we talked about that and concluded that function calls = are usually everywhere and are easy to notice without additional = highlighting. >> Right, I think they should be level 4. >=20 > On a related note: 'property' is in level 3 in c-ts-mode. >=20 > Should it to go level 4? I believe property is level 3. Quoting the (emacs) manual: Level 1 This level usually fontifies only comments and function names in function definitions. Level 2 This level adds fontification of keywords, strings, and data types. Level 3 This is the default level; it adds fontification of assignments, numbers, properties, etc. Level 4 This level adds everything else that can be fontified: operators, delimiters, brackets, other punctuation, function names in function calls, variables, etc. Yuan=