unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Tobias Gerdin <tgerdin@gmail.com>, 32029@debbugs.gnu.org
Subject: bug#32029: [PATCH] xref-find-definitions-at-mouse
Date: Wed, 4 Jul 2018 15:24:25 +0300	[thread overview]
Message-ID: <6443125a-32a7-e0a3-cf3d-43481ee146bd@yandex.ru> (raw)
In-Reply-To: <2524b8c0-41cc-863c-9a7f-c9681b11295d@gmail.com>

On 7/4/18 11:03 AM, Tobias Gerdin wrote:
> Den 2018-07-03 kl. 15:15, skrev Dmitry Gutov:
>>> I think this can be written much shorter (call mouse-set-point, then 
>>> interactively call xref-find-definitions), but I'm not sure how.
> Actually, since the mark will be saved before the jump if one could 
> arrange for saving the mark before the call to mouse-set-point and not 
> saving it again before jumping the call to save-excursion would not be 
> needed and xref-find-definitions could be called interactively.
Would that really be a desired behavior, though?

Regarding the patch, I'm fine with it, but I'd like someone else to 
confirm that the name of the new function makes sense.





  reply	other threads:[~2018-07-04 12:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-01 23:18 bug#32029: PATCH: xref-find-definitions-at-mouse Tobias Gerdin
2018-07-03 13:15 ` Dmitry Gutov
2018-07-03 21:37   ` bug#32029: [PATCH] xref-find-definitions-at-mouse Tobias Gerdin
2018-07-04  8:03     ` Tobias Gerdin
2018-07-04 12:24       ` Dmitry Gutov [this message]
2018-07-04 15:17         ` Eli Zaretskii
2018-07-06  8:55     ` Eli Zaretskii
2018-07-06  9:03       ` Dmitry Gutov
2018-07-06 20:23         ` Tobias Gerdin
2018-07-07  9:04           ` Eli Zaretskii
2018-07-07  9:02     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6443125a-32a7-e0a3-cf3d-43481ee146bd@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=32029@debbugs.gnu.org \
    --cc=tgerdin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).