From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Bruno Haible Newsgroups: gmane.emacs.bugs,gmane.comp.lib.gnulib.bugs Subject: bug#57129: 29.0.50; Improve behavior of conditionals in Eshell Date: Mon, 15 Aug 2022 23:22:27 +0200 Message-ID: <6414919.G0QQBjFxQf@nimes> References: <83ilmtgwq3.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30668"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Jim Porter , Eli Zaretskii , larsi@gnus.org, 57129@debbugs.gnu.org To: bug-gnulib@gnu.org, Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 15 23:23:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oNhYG-0007kQ-KE for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 Aug 2022 23:23:12 +0200 Original-Received: from localhost ([::1]:37476 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oNhYF-0007rY-Ha for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 Aug 2022 17:23:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35884) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNhY6-0007pf-RN for bug-gnu-emacs@gnu.org; Mon, 15 Aug 2022 17:23:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54491) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oNhY6-0001zJ-JA for bug-gnu-emacs@gnu.org; Mon, 15 Aug 2022 17:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oNhY6-0007hw-Cl for bug-gnu-emacs@gnu.org; Mon, 15 Aug 2022 17:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Bruno Haible Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Aug 2022 21:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57129 X-GNU-PR-Package: emacs Original-Received: via spool by 57129-submit@debbugs.gnu.org id=B57129.166059855529580 (code B ref 57129); Mon, 15 Aug 2022 21:23:02 +0000 Original-Received: (at 57129) by debbugs.gnu.org; 15 Aug 2022 21:22:35 +0000 Original-Received: from localhost ([127.0.0.1]:44240 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNhXf-0007h2-A3 for submit@debbugs.gnu.org; Mon, 15 Aug 2022 17:22:35 -0400 Original-Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.161]:40145) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNhXc-0007gs-FL for 57129@debbugs.gnu.org; Mon, 15 Aug 2022 17:22:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1660598548; s=strato-dkim-0002; d=clisp.org; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=NTVfemy3C7IP5WnmWxBSzjjMXOt1DHqe62oWQDHNrEY=; b=FRpB8j+3KXQnPilw7VzEAYeoO9Z6BV8m+1iYEeU+Q7qOCz8odzVVb2doBQVirUMouC X9QkbiCnpDtNGXiJ2m24Ix6SOSgTg/jKLY6Uhl+mojwBqledhWhCDNh/5faoGvCuj81x mrHAh2njk1K3x5gKUMocMC8vMc84U7la9FKq4qdGZfRglTn/ISEzu0MDQ5zsZIRAYbnG 5nQYEQfM6hbx6K/LVWSNMEU4Kqia98fWxvLl0/ArUf/duzkOA6rk4UZ4PDYB/Ox6qnB/ h73VZHOJehmkfDEPXYIq3oASAPYL1O9GXXL4+DAr41PKun5LlcSN/R02L55IJ4p2oFkT 9TRQ== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH0WWb0LN8XZoH94zG6tLj91pCQ0eN7ysCnnpESqlYuuWQ2Mis=" X-RZG-CLASS-ID: mo00 Original-Received: from nimes.localnet by smtp.strato.de (RZmta 47.47.0 AUTH) with ESMTPSA id g97246y7FLMRhAz (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Mon, 15 Aug 2022 23:22:27 +0200 (CEST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:239844 gmane.comp.lib.gnulib.bugs:46129 Archived-At: Paul Eggert wrote: > I do see a comment saying that gen_tempname generates "hard-to-predict" > names, which as you note is not correct on MS-DOS, nor even strictly > speaking on all POSIX platforms. I installed the first attached patch > into Gnulib to fix that comment. Another comment fix is as below. Note that both comment fixes need to be propagated to glibc. 2022-08-15 Bruno Haible tempname: Fix a comment. * lib/tempname.c (try_tempname_len): Use of entropy makes the function more, not less, secure. diff --git a/lib/tempname.c b/lib/tempname.c index 75a939e571..e6520191d7 100644 --- a/lib/tempname.c +++ b/lib/tempname.c @@ -273,7 +273,7 @@ try_tempname_len (char *tmpl, int suffixlen, void *args, /* Whether to consume entropy when acquiring random bits. On the first try it's worth the entropy cost with __GT_NOCREATE, which is inherently insecure and can use the entropy to make it a bit - less secure. On the (rare) second and later attempts it might + more secure. On the (rare) second and later attempts it might help against DoS attacks. */ bool use_getrandom = tryfunc == try_nocreate;