From: "Simen Endsjø" <simendsjo@gmail.com>
To: "Eli Zaretskii" <eliz@gnu.org>
Cc: 70914@debbugs.gnu.org
Subject: bug#70914: 29.3; Crashes often on Windows
Date: Mon, 27 May 2024 14:54:22 +0200 [thread overview]
Message-ID: <63f77ba4-7db5-4bbb-9f71-d5626756491d@app.fastmail.com> (raw)
In-Reply-To: <CAHkVV6GxRxE9nOXmByycoOSOWVtup4D-uoyfjiOP24sw0mqJbQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 6574 bytes --]
> Double checked, and no, looks like I've been accidentally running without the
> patch (at least it's unpatched in the working tree)! I'll try running the
> emacs-29 branch instead of emacs-29.3 with the patch manually applied.
>
> Let's see if this fixes the issue ;)
I keep getting these errors even though I'm running with the "//" patch. Common
for the crashes (when attaching gdb to the crashing process) is the following:
#6 0x00007ffef66f49ff in ntdll!.chkstk () from C:\WINDOWS\SYSTEM32\ntdll.dll
#7 0x00007ffef666e466 in ntdll!RtlFindCharInUnicodeString () from C:\WINDOWS\SYSTEM32\ntdll.dll
I've been running without org-superstar and org-fancy-priorities. This time I
got the error when calling `dired-sort-toggle-or-edit`. It's not reproducible in
that folder after restarting though.
Thread 1 (Thread 18588.0x5fd4):
#0 0x00007ffef3ecd313 in KERNELBASE!DebugBreak () from C:\WINDOWS\System32\KernelBase.dll
#1 0x00007ff78c040f28 in emacs_abort ()
#2 0x00007ff78bf0a389 in terminate_due_to_signal ()
#3 0x00007ff78bf2b249 in deliver_fatal_thread_signal ()
#4 0x00007ff78c0a6672 in _gnu_exception_handler (exception_data=0x377f9fdc00) at C:/M/B/src/mingw-w64/mingw-w64-crt/crt/crt_handler.c:213
#5 0x00007ffef4b6b248 in msvcrt!__C_specific_handler () from C:\WINDOWS\System32\msvcrt.dll
#6 0x00007ffef66f49ff in ntdll!.chkstk () from C:\WINDOWS\SYSTEM32\ntdll.dll
#7 0x00007ffef666e466 in ntdll!RtlFindCharInUnicodeString () from C:\WINDOWS\SYSTEM32\ntdll.dll
#8 0x00007ffef66f39ee in ntdll!KiUserExceptionDispatcher () from C:\WINDOWS\SYSTEM32\ntdll.dll
#9 0x00007ff78bfc3aa3 in print_object ()
#10 0x00007ff78bfc55d8 in Fprin1 ()
#11 0x00007ff78bfc5d33 in print_error_message ()
#12 0x00007ff78bf0c73d in Fcommand_error_default_function ()
#13 0x00007ffee4de1907 in F68656c702d636f6d6d616e642d6572726f722d636f6e66757361626c652d73756767657374696f6e73_help_command_error_confusable_suggestions_0 () from c:\programs\emacs\latest\lib\emacs\29.3\native-lisp\29.3-2771a4de\preloaded\help-59d8049f-5432716d.eln
#14 0x00007ff78bfa0032 in Ffuncall ()
#15 0x00007ff78bf1346b in cmd_error_internal ()
#16 0x00007ff78bf135cf in cmd_error ()
#17 0x00007ff78bf9a66d in internal_condition_case ()
#18 0x00007ff78bf0ac32 in command_loop_2 ()
#19 0x00007ff78bf9a59b in internal_catch ()
#20 0x00007ff78bf0abcc in command_loop ()
#21 0x00007ff78bf12fe7 in recursive_edit_1 ()
#22 0x00007ff78bf133b0 in Frecursive_edit ()
#23 0x00007ff78c0b9b7d in main ()
On Fri, May 24, 2024, at 15:08, Simen Endsjø wrote:
> > Are you running with the source of parse_root fixed, as in the current
> > emacs-29 branch? If not, please rebuild Emacs with that patch before
> > doing anything else. If you want, you install the patch locally, see
> > the patch below.
>
> Double checked, and no, looks like I've been accidentally running without the
> patch (at least it's unpatched in the working tree)! I'll try running the
> emacs-29 branch instead of emacs-29.3 with the patch manually applied.
>
> Let's see if this fixes the issue ;)
>
> On Fri, May 24, 2024 at 12:47 PM Eli Zaretskii <eliz@gnu.org> wrote:
> >
> > > From: Simen Endsjø <simendsjo@gmail.com>
> > > Date: Fri, 24 May 2024 12:07:23 +0200
> > > Cc: 70914@debbugs.gnu.org
> > >
> > > I still get these. Should I open a new issue for this as the bug
> > > report has changed towards the path issue?
> > > The path issue was only visible to me when debugging in gdb, so these
> > > crashes (my original case) is still ongoing.
> >
> > Are you running with the source of parse_root fixed, as in the current
> > emacs-29 branch? If not, please rebuild Emacs with that patch before
> > doing anything else. If you want, you install the patch locally, see
> > the patch below.
> >
> > > #0 0x00007ff9672dd313 in KERNELBASE!DebugBreak () from
> > > C:\WINDOWS\System32\KernelBase.dll
> > > #1 0x00007ff719eb0f28 in emacs_abort ()
> > > #2 0x00007ff719d7a389 in terminate_due_to_signal ()
> > > #3 0x00007ff719d9b249 in deliver_fatal_thread_signal ()
> > > #4 0x00007ff719f16672 in _gnu_exception_handler
> > > (exception_data=0xb3a4dfb400) at
> > > C:/M/B/src/mingw-w64/mingw-w64-crt/crt/crt_handler.c:213
> > > #5 0x00007ff968bbb248 in msvcrt!__C_specific_handler () from
> > > C:\WINDOWS\System32\msvcrt.dll
> > > #6 0x00007ff969b549ff in ntdll!.chkstk () from C:\WINDOWS\SYSTEM32\ntdll.dll
> > > #7 0x00007ff969ace466 in ntdll!RtlFindCharInUnicodeString () from
> > > C:\WINDOWS\SYSTEM32\ntdll.dll
> > > #8 0x00007ff969b539ee in ntdll!KiUserExceptionDispatcher () from
> > > C:\WINDOWS\SYSTEM32\ntdll.dll
> > > #9 0x00007ff719dda17d in rpl_re_compile_pattern ()
> > > #10 0x00007ff719dcaf10 in compile_pattern ()
> > > #11 0x00007ff719dcb34d in looking_at_1 ()
> > > #12 0x00007ff719e10032 in Ffuncall ()
> > > #13 0x00007ff8e7591da7 in
> > > F73702d736b69702d666f72776172642d746f2d73796d626f6c_sp_skip_forward_to_symbol_0
> > > ()
> > > from d:\.emacs.d\.local\cache\eln\29.3-2771a4de\smartparens-7ac9a6ec-f08b49fa.eln
> >
> > This seems like a different issue, so if rebuilding with the patch
> > below doesn't help, please do open a new issue. And I will tell you
> > already what we need to know for investigating: the arguments to
> > looking_at_1. You should be able to show them like this:
> >
> > (gdb) frame 11
> > (gdb) p string
> > (gdb) xstring
> >
> > The "frame 11" above assumes that the call to looking_at_1 is at
> > call-stack frame #11, as in the above backtraces; if not, adjust the
> > number accordingly. The command "xstring" is defined in src/.gdbinit,
> > so if GDB says it doesn't know about it, do
> >
> > (gdb) source /path/to/emacs/src/.gdbinit
> >
> > and then repeat the above commands.
> >
> > Here's the patch which prevents crashes due to "//" file names:
> >
> > diff --git a/src/w32.c b/src/w32.c
> > index d463962..a78d556 100644
> > --- a/src/w32.c
> > +++ b/src/w32.c
> > @@ -2572,7 +2572,7 @@ parse_root (const char * name, const char ** pPath)
> > name += 2;
> > do
> > {
> > - if (IS_DIRECTORY_SEP (*name) && --slashes == 0)
> > + if (!*name || (IS_DIRECTORY_SEP (*name) && --slashes == 0))
> > break;
> > name++;
> > }
>
[-- Attachment #2: Type: text/html, Size: 10268 bytes --]
next prev parent reply other threads:[~2024-05-27 12:54 UTC|newest]
Thread overview: 141+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-13 8:47 bug#70914: 29.3; Crashes often on Windows Simen Endsjø
2024-05-13 10:35 ` Eli Zaretskii
2024-05-14 10:14 ` Simen Endsjø
2024-05-14 11:23 ` Eli Zaretskii
2024-05-14 12:08 ` Simen Endsjø
2024-05-14 12:30 ` Eli Zaretskii
2024-05-14 13:58 ` Simen Endsjø
2024-05-14 14:18 ` Eli Zaretskii
2024-05-15 10:25 ` Simen Endsjø
2024-05-15 11:19 ` Simen Endsjø
2024-05-15 11:24 ` Simen Endsjø
2024-05-15 12:20 ` Eli Zaretskii
2024-05-15 12:15 ` Eli Zaretskii
2024-05-15 13:50 ` Simen Endsjø
2024-05-15 12:04 ` Eli Zaretskii
2024-05-15 13:45 ` Simen Endsjø
2024-05-16 7:05 ` Simen Endsjø
2024-05-16 10:11 ` Eli Zaretskii
2024-05-24 10:13 ` Simen Endsjø
2024-05-15 10:53 ` Simen Endsjø
2024-05-15 12:11 ` Eli Zaretskii
2024-05-15 13:00 ` Simen Endsjø
2024-05-15 13:36 ` Simen Endsjø
2024-05-15 13:58 ` Simen Endsjø
2024-05-15 15:25 ` Eli Zaretskii
2024-05-15 18:13 ` Simen Endsjø
2024-05-15 18:21 ` Simen Endsjø
2024-05-15 18:53 ` Eli Zaretskii
2024-05-15 20:03 ` Simen Endsjø
2024-05-16 8:07 ` Eli Zaretskii
2024-05-16 10:50 ` Simen Endsjø
2024-05-16 11:44 ` Simen Endsjø
2024-05-16 12:15 ` Eli Zaretskii
2024-05-18 18:47 ` Simen Endsjø
2024-05-18 19:46 ` Eli Zaretskii
2024-05-18 21:45 ` Simen Endsjø
2024-05-19 5:50 ` Eli Zaretskii
2024-05-19 9:03 ` Eli Zaretskii
2024-05-19 17:41 ` Simen Endsjø
2024-05-19 18:31 ` Eli Zaretskii
2024-05-19 18:38 ` Simen Endsjø
2024-05-20 13:47 ` Eli Zaretskii
2024-05-20 17:54 ` Simen Endsjø
2024-05-20 18:20 ` Eli Zaretskii
2024-05-20 18:41 ` Simen Endsjø
2024-05-20 19:00 ` Eli Zaretskii
2024-05-20 19:22 ` Eli Zaretskii
2024-05-20 20:28 ` Simen Endsjø
2024-05-21 14:06 ` Eli Zaretskii
2024-05-21 17:39 ` Simen Endsjø
2024-05-21 18:29 ` Eli Zaretskii
2024-05-21 19:05 ` Hannes Domani via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-21 19:24 ` Eli Zaretskii
2024-05-21 20:31 ` Simen Endsjø
2024-05-22 4:32 ` Hannes Domani via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-22 4:35 ` Simen Endsjø
2024-05-22 5:08 ` Hannes Domani via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-22 5:57 ` Simen Endsjø
2024-05-22 6:12 ` Hannes Domani via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-22 8:16 ` Simen Endsjø
2024-05-22 8:23 ` Hannes Domani via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-22 8:41 ` Simen Endsjø
2024-05-22 8:50 ` Hannes Domani via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-22 11:09 ` Simen Endsjø
2024-05-22 11:21 ` Simen Endsjø
2024-05-22 11:24 ` Simen Endsjø
2024-05-22 13:26 ` Eli Zaretskii
2024-05-22 13:35 ` Simen Endsjø
2024-05-22 14:07 ` Eli Zaretskii
2024-05-22 11:40 ` Eli Zaretskii
2024-05-22 11:36 ` Eli Zaretskii
2024-05-22 11:24 ` Eli Zaretskii
2024-05-22 13:14 ` Simen Endsjø
2024-05-22 14:03 ` Eli Zaretskii
2024-05-22 16:54 ` Simen Endsjø
2024-05-22 18:19 ` Eli Zaretskii
2024-05-22 19:21 ` Simen Endsjø
2024-05-22 20:28 ` Simen Endsjø
2024-05-23 5:19 ` Eli Zaretskii
2024-05-23 7:31 ` Simen Endsjø
2024-05-23 8:18 ` Eli Zaretskii
2024-05-23 10:05 ` Simen Endsjø
2024-05-23 10:30 ` Ihor Radchenko
2024-05-23 10:39 ` Eli Zaretskii
2024-05-23 10:48 ` Ihor Radchenko
2024-05-23 11:31 ` Eli Zaretskii
2024-05-23 11:51 ` Ihor Radchenko
2024-05-23 13:33 ` Eli Zaretskii
2024-05-23 13:52 ` Ihor Radchenko
2024-05-23 14:05 ` Eli Zaretskii
2024-05-23 14:23 ` Ihor Radchenko
2024-05-23 16:02 ` Eli Zaretskii
2024-05-23 18:33 ` Simen Endsjø
2024-05-23 18:46 ` Eli Zaretskii
2024-05-22 12:26 ` Eli Zaretskii
2024-05-22 13:34 ` Simen Endsjø
2024-05-22 14:05 ` Eli Zaretskii
2024-05-22 14:28 ` Hannes Domani via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-22 14:58 ` Eli Zaretskii
2024-05-22 18:12 ` Hannes Domani via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-22 18:32 ` Eli Zaretskii
2024-05-21 20:01 ` Simen Endsjø
2024-05-16 6:42 ` Simen Endsjø
2024-05-16 10:03 ` Eli Zaretskii
2024-05-16 11:00 ` Simen Endsjø
2024-05-16 12:13 ` Eli Zaretskii
2024-05-16 12:11 ` Andrea Corallo
2024-05-16 12:22 ` Eli Zaretskii
2024-05-16 15:26 ` Andrea Corallo
2024-05-16 16:03 ` Eli Zaretskii
2024-05-16 17:04 ` Andrea Corallo
2024-05-16 18:24 ` Eli Zaretskii
2024-05-24 7:59 ` Andrea Corallo
2024-05-24 10:48 ` Eli Zaretskii
2024-05-27 9:53 ` Andrea Corallo
2024-05-27 11:55 ` Eli Zaretskii
2024-05-16 18:40 ` Simen Endsjø
2024-05-16 19:28 ` Eli Zaretskii
2024-05-16 20:13 ` Simen Endsjø
2024-05-16 21:03 ` Simen Endsjø
2024-05-17 6:51 ` Eli Zaretskii
2024-05-17 18:05 ` Simen Endsjø
2024-05-17 18:38 ` Eli Zaretskii
2024-05-17 20:39 ` Simen Endsjø
2024-05-18 11:18 ` Simen Endsjø
2024-05-18 11:49 ` Eli Zaretskii
2024-05-18 18:36 ` Simen Endsjø
2024-05-18 19:35 ` Eli Zaretskii
2024-05-18 19:43 ` Simen Endsjø
2024-05-18 11:55 ` Eli Zaretskii
2024-05-18 18:42 ` Simen Endsjø
2024-05-18 19:40 ` Eli Zaretskii
2024-05-17 6:16 ` Eli Zaretskii
2024-05-15 18:35 ` Eli Zaretskii
2024-05-15 15:18 ` Eli Zaretskii
2024-05-24 10:07 ` Simen Endsjø
2024-05-24 10:47 ` Eli Zaretskii
2024-05-24 13:08 ` Simen Endsjø
2024-05-27 12:54 ` Simen Endsjø [this message]
2024-05-27 13:22 ` Eli Zaretskii
[not found] ` <87sey1g5dg.fsf@simendsjo.me>
2024-05-28 18:40 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63f77ba4-7db5-4bbb-9f71-d5626756491d@app.fastmail.com \
--to=simendsjo@gmail.com \
--cc=70914@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).