From: Konstantin Kharlamov <hi-angel@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 60854@debbugs.gnu.org
Subject: bug#60854: [PATCH] Make warnings show a "warning" emoji instead of a stop-sign
Date: Fri, 31 Mar 2023 11:10:25 +0300 [thread overview]
Message-ID: <63e35a46b8ea9bbac0fed0fe8e97b06a47b9b563.camel@yandex.ru> (raw)
In-Reply-To: <83h6u12w4u.fsf@gnu.org>
On Fri, 2023-03-31 at 10:54 +0300, Eli Zaretskii wrote:
> > From: Konstantin Kharlamov <hi-angel@yandex.ru>
> > Cc: 60854@debbugs.gnu.org
> > Date: Fri, 31 Mar 2023 10:48:12 +0300
> >
> > FWIW, I co-maintain a color-identifiers mode on github, and I have
> > occasionally
> > introduced new native-comp warnings (about a variable being referred in a
> > function before its `defvar`). This happens because you debug and test ELisp
> > code without it being compiled at all. Then later after everything seems to
> > work, you test that byte-compilation produces no warnings. But at that point
> > you
> > don't know there isn't any warnings from native-comp, so you also need to
> > load
> > the byte-compiled file, which is easy to forget.
>
> Better testing should fix these.
Sure. Setting up a CI to run upon PRs before they're merged would be ideal. But
I don't believe people will start doing that just because there is native-comp
now.
> > That, and given that some modes in (M)Elpa may be unmaintained — I don't see
> > native-comp warnings go away any time soon.
>
> Well, they went away in Emacs a long time ago. So it's doable.
Last I checked Emacs was maintained 😄 For unmaintained modes there will be
simply no one to merge fixes that someone creates.
> > Simply changing emoji would still show interested users there is a problem
> > with
> > their mode that they can fix, but at the same time would avoid attributing
> > negative experience to Emacs per se.
>
> Feel free to suggest defcustoms to allow users to customize the
> symbols. That should leave everyone happy.
The problem is about OOTB behaviour. (although now that I think about that, Doom
Emacs which seems quite popular could maybe replace the emoji in their config.
Hmm…)
> In any case, it's too late to suggest such changes for the emacs-29
> branch.
I see. Oh, well…
next prev parent reply other threads:[~2023-03-31 8:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-11 8:45 bug#61413: [PATCH] Make warnings show a "warning" emoji instead of a stop-sign Konstantin Kharlamov
[not found] ` <handler.61413.B.16761051946467.ack@debbugs.gnu.org>
2023-02-11 8:49 ` bug#61413: Acknowledgement ([PATCH] Make warnings show a "warning" emoji instead of a stop-sign) Konstantin Kharlamov
2023-02-11 10:36 ` bug#61413: [PATCH] Make warnings show a "warning" emoji instead of a stop-sign Eli Zaretskii
2023-02-11 10:56 ` bug#60854: " Konstantin Kharlamov
2023-03-30 20:58 ` bug#60854: " Konstantin Kharlamov
2023-03-31 5:55 ` Eli Zaretskii
2023-03-31 6:19 ` Konstantin Kharlamov
2023-03-31 6:26 ` Konstantin Kharlamov
2023-03-31 7:05 ` Eli Zaretskii
2023-03-31 7:48 ` Konstantin Kharlamov
2023-03-31 7:54 ` Eli Zaretskii
2023-03-31 8:10 ` Konstantin Kharlamov [this message]
2023-03-31 7:00 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63e35a46b8ea9bbac0fed0fe8e97b06a47b9b563.camel@yandex.ru \
--to=hi-angel@yandex.ru \
--cc=60854@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).